* + mm-damon-fix-typos-in-comments.patch added to mm-new branch
@ 2025-12-17 21:51 Andrew Morton
2025-12-17 22:38 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2025-12-17 21:51 UTC (permalink / raw)
To: mm-commits, sj, klourencodev, kevin, akpm
The patch titled
Subject: mm/damon: fix typos in comments
has been added to the -mm mm-new branch. Its filename is
mm-damon-fix-typos-in-comments.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-damon-fix-typos-in-comments.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: kevin <kevin@desktop-mu90jgd.home>
Subject: mm/damon: fix typos in comments
Date: Wed, 17 Dec 2025 19:12:16 +0100
Correct minor spelling mistakes in several files under mm/damon. No
functional changes.
Link: https://lkml.kernel.org/r/20251217181216.47576-1-klourencodev@gmail.com
Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
Cc: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/damon/core.c | 6 +++---
mm/damon/lru_sort.c | 2 +-
mm/damon/reclaim.c | 2 +-
mm/damon/stat.c | 2 +-
mm/damon/tests/core-kunit.h | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
--- a/mm/damon/core.c~mm-damon-fix-typos-in-comments
+++ a/mm/damon/core.c
@@ -284,7 +284,7 @@ struct damos_filter *damos_new_filter(en
}
/**
- * damos_filter_for_ops() - Return if the filter is ops-hndled one.
+ * damos_filter_for_ops() - Return if the filter is ops-handled one.
* @type: type of the filter.
*
* Return: true if the filter of @type needs to be handled by ops layer, false
@@ -1586,7 +1586,7 @@ static unsigned long damon_get_intervals
adaptation_bp = damon_feed_loop_next_input(100000000, score_bp) /
10000;
/*
- * adaptaion_bp ranges from 1 to 20,000. Avoid too rapid reduction of
+ * adaptation_bp ranges from 1 to 20,000. Avoid too rapid reduction of
* the intervals by rescaling [1,10,000] to [5000, 10,000].
*/
if (adaptation_bp <= 10000)
@@ -2756,7 +2756,7 @@ static int kdamond_fn(void *data)
*
* Reset ->next_aggregation_sis to avoid that.
* It will anyway correctly updated after this
- * if caluse.
+ * if clause.
*/
ctx->next_aggregation_sis =
next_aggregation_sis;
--- a/mm/damon/lru_sort.c~mm-damon-fix-typos-in-comments
+++ a/mm/damon/lru_sort.c
@@ -34,7 +34,7 @@ static bool enabled __read_mostly;
*
* Input parameters that updated while DAMON_LRU_SORT is running are not
* applied by default. Once this parameter is set as ``Y``, DAMON_LRU_SORT
- * reads values of parametrs except ``enabled`` again. Once the re-reading is
+ * reads values of parameters except ``enabled`` again. Once the re-reading is
* done, this parameter is set as ``N``. If invalid parameters are found while
* the re-reading, DAMON_LRU_SORT will be disabled.
*/
--- a/mm/damon/reclaim.c~mm-damon-fix-typos-in-comments
+++ a/mm/damon/reclaim.c
@@ -34,7 +34,7 @@ static bool enabled __read_mostly;
*
* Input parameters that updated while DAMON_RECLAIM is running are not applied
* by default. Once this parameter is set as ``Y``, DAMON_RECLAIM reads values
- * of parametrs except ``enabled`` again. Once the re-reading is done, this
+ * of parameters except ``enabled`` again. Once the re-reading is done, this
* parameter is set as ``N``. If invalid parameters are found while the
* re-reading, DAMON_RECLAIM will be disabled.
*/
--- a/mm/damon/stat.c~mm-damon-fix-typos-in-comments
+++ a/mm/damon/stat.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Shows data access monitoring resutls in simple metrics.
+ * Shows data access monitoring results in simple metrics.
*/
#define pr_fmt(fmt) "damon-stat: " fmt
--- a/mm/damon/tests/core-kunit.h~mm-damon-fix-typos-in-comments
+++ a/mm/damon/tests/core-kunit.h
@@ -1159,7 +1159,7 @@ static void damon_test_set_filters_defau
damos_set_filters_default_reject(&scheme);
/*
* A core-handled allow-filter is installed.
- * Rejct by default on core layer filtering stage due to the last
+ * Reject by default on core layer filtering stage due to the last
* core-layer-filter's behavior.
* Allow by default on ops layer filtering stage due to the absence of
* ops layer filters.
_
Patches currently in -mm which might be from kevin@desktop-mu90jgd.home are
mm-damon-fix-typos-in-comments.patch
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: + mm-damon-fix-typos-in-comments.patch added to mm-new branch
2025-12-17 21:51 + mm-damon-fix-typos-in-comments.patch added to mm-new branch Andrew Morton
@ 2025-12-17 22:38 ` SeongJae Park
2025-12-17 22:43 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2025-12-17 22:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: SeongJae Park, mm-commits, klourencodev, kevin
Hello Andrew,
On Wed, 17 Dec 2025 13:51:39 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> The patch titled
> Subject: mm/damon: fix typos in comments
> has been added to the -mm mm-new branch. Its filename is
> mm-damon-fix-typos-in-comments.patch
Thank you for picking this up quickly!
[...]
> ------------------------------------------------------
> From: kevin <kevin@desktop-mu90jgd.home>
> Subject: mm/damon: fix typos in comments
> Date: Wed, 17 Dec 2025 19:12:16 +0100
>
> Correct minor spelling mistakes in several files under mm/damon. No
> functional changes.
>
> Link: https://lkml.kernel.org/r/20251217181216.47576-1-klourencodev@gmail.com
> Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
But, as I noted on my reply [1] to the patch, shouldn't the above
Signed-off-by: and From: match? And to my understanding, we need the author's
agreement at modifying such ones. Correct me if I'm wrong. If I'm not wrong,
could you please drop this at the moment and add back after Kevin clarifies
what should be used as the author's identity?
[1] https://lore.kernel.org/20251217222609.3355-1-sj@kernel.org
> Cc: SeongJae Park <sj@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + mm-damon-fix-typos-in-comments.patch added to mm-new branch
2025-12-17 22:38 ` SeongJae Park
@ 2025-12-17 22:43 ` SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2025-12-17 22:43 UTC (permalink / raw)
To: SeongJae Park; +Cc: Andrew Morton, mm-commits, klourencodev, kevin
On Wed, 17 Dec 2025 14:38:28 -0800 SeongJae Park <sj@kernel.org> wrote:
> Hello Andrew,
>
> On Wed, 17 Dec 2025 13:51:39 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> >
> > The patch titled
> > Subject: mm/damon: fix typos in comments
> > has been added to the -mm mm-new branch. Its filename is
> > mm-damon-fix-typos-in-comments.patch
>
> Thank you for picking this up quickly!
>
> [...]
> > ------------------------------------------------------
> > From: kevin <kevin@desktop-mu90jgd.home>
> > Subject: mm/damon: fix typos in comments
> > Date: Wed, 17 Dec 2025 19:12:16 +0100
> >
> > Correct minor spelling mistakes in several files under mm/damon. No
> > functional changes.
> >
> > Link: https://lkml.kernel.org/r/20251217181216.47576-1-klourencodev@gmail.com
> > Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
>
> But, as I noted on my reply [1] to the patch, shouldn't the above
> Signed-off-by: and From: match? And to my understanding, we need the author's
> agreement at modifying such ones. Correct me if I'm wrong. If I'm not wrong,
> could you please drop this at the moment and add back after Kevin clarifies
> what should be used as the author's identity?
>
> [1] https://lore.kernel.org/20251217222609.3355-1-sj@kernel.org
Seems the above link is not working, since lore URLs are not working without
mailing list at the moment. Please use
https://lore.kernel.org/damon/20251217222609.3355-1-sj@kernel.org
instead if you want to read it before the lore side issue is fixed.
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-17 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 21:51 + mm-damon-fix-typos-in-comments.patch added to mm-new branch Andrew Morton
2025-12-17 22:38 ` SeongJae Park
2025-12-17 22:43 ` SeongJae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.