Re: [PATCH v11 6/6] iio: magnetometer: Add mmc5633 sensor

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Frank Li" <Frank.Li@nxp.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-iio@vger.kernel.org,
	joshua.yeong@starfivetech.com, devicetree@vger.kernel.org,
	linux@roeck-us.net, "Carlos Song" <carlos.song@nxp.com>,
	"Adrian Fluturel" <fluturel.adrian@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v11 6/6] iio: magnetometer: Add mmc5633 sensor
Date: Thu, 18 Dec 2025 11:10:21 +0100	[thread overview]
Message-ID: <202512181010210ddb2a03@mail.local> (raw)
In-Reply-To: <20251109135728.223d3857@jic23-huawei>

On 09/11/2025 13:57:28+0000, Jonathan Cameron wrote:
> On Thu, 06 Nov 2025 12:36:05 -0500
> Frank Li <Frank.Li@nxp.com> wrote:
> 
> > Add mmc5633 sensor basic support.
> > - Support read 20 bits X/Y/Z magnetic.
> > - Support I3C HDR mode to send start measurememt command.
> > - Support I3C HDR mode to read all sensors data by one command.
> > 
> > Co-developed-by: Carlos Song <carlos.song@nxp.com>
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
> > Co-developed-by: Adrian Fluturel <fluturel.adrian@gmail.com>
> > Signed-off-by: Adrian Fluturel <fluturel.adrian@gmail.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > change in v11
> > - add andy shevchenak's reviewed by tag
> > - use unsigned int for regmap
> > - compact mmc5633_read_avail arg list to few lines
> > - move check condition to one line for read_poll_timeout()
> > - leave i3c_xfer as size 1 array to align existed code style in kernel
> > tree, git grep -r i3c_priv_xfer drivers/, leave to jonathan to do decide.
> I don't feel strongly either way, so fine with just having it as
> you have it here.
> 
> I'm assuming there will either be an immutable branch that I can
> pick up to get the i3c changes, or that we'll split this across cycles
> (so i3c bit goes in this cycle, driver next).
> 
> So I'll keep an eye open for how that part merges if everyone is happy
> with it.  Feel free to poke me if I look like I missed it.

I guess you have seen the resend by now but I took the i3c patches quite
late in the previous cycle so I didn't bother creating an immutable
branch. Feel free to review and apply v12 when you have time.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com