From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Benjamin Coddington <bcodding@hammerspace.com>,
Jeff Layton <jlayton@kernel.org>
Cc: Swaraj Gaikwad <swarajgaikwad1925@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: [PATCH v2] VFS: fix dentry_create() kernel-doc comment
Date: Fri, 19 Dec 2025 08:06:19 +0700 [thread overview]
Message-ID: <20251219-dentry-inline-v2-1-c074b5bfb3a6@gmail.com> (raw)
Sphinx reports htmldocs warnings:
Documentation/filesystems/api-summary:56: fs/namei.c:4952: WARNING: Inline emphasis start-string without end-string. [docutils]
Documentation/filesystems/api-summary:56: fs/namei.c:4942: ERROR: Unknown target name: "o". [docutils]
Fix them up.
Fixes: 977de00dfcf87e ("VFS: move dentry_create() from fs/open.c to fs/namei.c")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20251216115252.709078e8@canb.auug.org.au/
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Changes in v2:
- Add ellipsis placeholder on @flags description (Al Viro)
- Phrase return value struct (Al Viro)
- Link to v1: https://lore.kernel.org/r/20251218-dentry-inline-v1-1-0107f4cd8246@gmail.com
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index aefb21bc0944e3..ad6a9930dc68b5 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4939,7 +4939,7 @@ EXPORT_SYMBOL(start_creating_user_path);
/**
* dentry_create - Create and open a file
* @path: path to create
- * @flags: O_ flags
+ * @flags: O\_... flags
* @mode: mode bits for new file
* @cred: credentials to use
*
@@ -4950,7 +4950,7 @@ EXPORT_SYMBOL(start_creating_user_path);
* the new file is to be created. The parent directory and the
* negative dentry must reside on the same filesystem instance.
*
- * On success, returns a "struct file *". Otherwise a ERR_PTR
+ * On success, return a pointer to opened file. Otherwise a ERR_PTR
* is returned.
*/
struct file *dentry_create(struct path *path, int flags, umode_t mode,
---
base-commit: 981be27a72d163610e8e1c342373930bae80ac99
change-id: 20251218-dentry-inline-4091feeae685
Best regards,
--
Bagas Sanjaya <bagasdotme@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya via B4 Relay <devnull+bagasdotme.gmail.com@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Benjamin Coddington <bcodding@hammerspace.com>,
Jeff Layton <jlayton@kernel.org>
Cc: Swaraj Gaikwad <swarajgaikwad1925@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: [PATCH v2] VFS: fix dentry_create() kernel-doc comment
Date: Fri, 19 Dec 2025 08:06:19 +0700 [thread overview]
Message-ID: <20251219-dentry-inline-v2-1-c074b5bfb3a6@gmail.com> (raw)
From: Bagas Sanjaya <bagasdotme@gmail.com>
Sphinx reports htmldocs warnings:
Documentation/filesystems/api-summary:56: fs/namei.c:4952: WARNING: Inline emphasis start-string without end-string. [docutils]
Documentation/filesystems/api-summary:56: fs/namei.c:4942: ERROR: Unknown target name: "o". [docutils]
Fix them up.
Fixes: 977de00dfcf87e ("VFS: move dentry_create() from fs/open.c to fs/namei.c")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20251216115252.709078e8@canb.auug.org.au/
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Changes in v2:
- Add ellipsis placeholder on @flags description (Al Viro)
- Phrase return value struct (Al Viro)
- Link to v1: https://lore.kernel.org/r/20251218-dentry-inline-v1-1-0107f4cd8246@gmail.com
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index aefb21bc0944e3..ad6a9930dc68b5 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4939,7 +4939,7 @@ EXPORT_SYMBOL(start_creating_user_path);
/**
* dentry_create - Create and open a file
* @path: path to create
- * @flags: O_ flags
+ * @flags: O\_... flags
* @mode: mode bits for new file
* @cred: credentials to use
*
@@ -4950,7 +4950,7 @@ EXPORT_SYMBOL(start_creating_user_path);
* the new file is to be created. The parent directory and the
* negative dentry must reside on the same filesystem instance.
*
- * On success, returns a "struct file *". Otherwise a ERR_PTR
+ * On success, return a pointer to opened file. Otherwise a ERR_PTR
* is returned.
*/
struct file *dentry_create(struct path *path, int flags, umode_t mode,
---
base-commit: 981be27a72d163610e8e1c342373930bae80ac99
change-id: 20251218-dentry-inline-4091feeae685
Best regards,
--
Bagas Sanjaya <bagasdotme@gmail.com>
next reply other threads:[~2025-12-19 1:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 1:06 Bagas Sanjaya [this message]
2025-12-19 1:06 ` [PATCH v2] VFS: fix dentry_create() kernel-doc comment Bagas Sanjaya via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219-dentry-inline-v2-1-c074b5bfb3a6@gmail.com \
--to=bagasdotme@gmail.com \
--cc=bcodding@hammerspace.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swarajgaikwad1925@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.