From: Nathan Chancellor <nathan@kernel.org>
To: Guillaume Tucker <gtucker@gtucker.io>
Cc: Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kbuild@vger.kernel.org,
automated-testing@lists.yoctoproject.org,
workflows@vger.kernel.org, llvm@lists.linux.dev,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 1/2] scripts: add tool to run containerized builds
Date: Fri, 19 Dec 2025 14:15:18 -0700 [thread overview]
Message-ID: <20251219211518.GB1407372@ax162> (raw)
In-Reply-To: <20251219194748.GA1404325@ax162>
On Fri, Dec 19, 2025 at 12:47:48PM -0700, Nathan Chancellor wrote:
> Most of these two functions are the same. Maybe they could be abstracted
> into a simple class so that most of the logic could be shared between
> the two implementations? That also might simplify main() a bit and make
> fulfilling David's request a little simpler as well.
Sigh, this is what I get for working through my inbox bottom up since I
see that you did this in v2 :) looks good, I will give a couple more
comments there.
next prev parent reply other threads:[~2025-12-19 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 13:58 [PATCH v1 0/2] scripts: introduce containerized builds Guillaume Tucker
2025-12-10 13:58 ` [PATCH v1 1/2] scripts: add tool to run " Guillaume Tucker
2025-12-13 4:16 ` Guillaume Tucker
2025-12-15 9:24 ` Onur Özkan
2025-12-15 10:15 ` Guillaume Tucker
2025-12-17 9:56 ` [Automated-testing] " David Gow
2025-12-17 13:51 ` Guillaume Tucker
2025-12-19 19:47 ` Nathan Chancellor
2025-12-19 21:15 ` Nathan Chancellor [this message]
2025-12-21 20:04 ` Guillaume Tucker
2025-12-31 16:54 ` Guillaume Tucker
2025-12-10 13:58 ` [PATCH v1 2/2] Documentation: dev-tools: add container.rst page Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219211518.GB1407372@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=automated-testing@lists.yoctoproject.org \
--cc=gtucker@gtucker.io \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.