* [PATCH] mmc: cavium: Use clamp to simplify cvm_mmc_set_clock
@ 2025-12-22 10:03 Thorsten Blum
2025-12-30 15:33 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-12-22 10:03 UTC (permalink / raw)
To: Robert Richter, Ulf Hansson, Huacai Chen, Binbin Zhou
Cc: Thorsten Blum, linux-mmc, linux-kernel
Use clamp() to simplify cvm_mmc_set_clock() and improve its readability.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/mmc/host/cavium.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c
index 9a55db0e657c..37a88f2a0c86 100644
--- a/drivers/mmc/host/cavium.c
+++ b/drivers/mmc/host/cavium.c
@@ -905,9 +905,7 @@ static void cvm_mmc_set_clock(struct cvm_mmc_slot *slot, unsigned int clock)
{
struct mmc_host *mmc = slot->mmc;
- clock = min(clock, mmc->f_max);
- clock = max(clock, mmc->f_min);
- slot->clock = clock;
+ slot->clock = clamp(clock, mmc->f_min, mmc->f_max);
}
static int cvm_mmc_init_lowlevel(struct cvm_mmc_slot *slot)
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: cavium: Use clamp to simplify cvm_mmc_set_clock
2025-12-22 10:03 [PATCH] mmc: cavium: Use clamp to simplify cvm_mmc_set_clock Thorsten Blum
@ 2025-12-30 15:33 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2025-12-30 15:33 UTC (permalink / raw)
To: Thorsten Blum
Cc: Robert Richter, Huacai Chen, Binbin Zhou, linux-mmc, linux-kernel
On Mon, 22 Dec 2025 at 11:03, Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Use clamp() to simplify cvm_mmc_set_clock() and improve its readability.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/cavium.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c
> index 9a55db0e657c..37a88f2a0c86 100644
> --- a/drivers/mmc/host/cavium.c
> +++ b/drivers/mmc/host/cavium.c
> @@ -905,9 +905,7 @@ static void cvm_mmc_set_clock(struct cvm_mmc_slot *slot, unsigned int clock)
> {
> struct mmc_host *mmc = slot->mmc;
>
> - clock = min(clock, mmc->f_max);
> - clock = max(clock, mmc->f_min);
> - slot->clock = clock;
> + slot->clock = clamp(clock, mmc->f_min, mmc->f_max);
> }
>
> static int cvm_mmc_init_lowlevel(struct cvm_mmc_slot *slot)
> --
> Thorsten Blum <thorsten.blum@linux.dev>
> GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-30 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-22 10:03 [PATCH] mmc: cavium: Use clamp to simplify cvm_mmc_set_clock Thorsten Blum
2025-12-30 15:33 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.