All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: joaopeixoto@osyx.tech
Cc: linux-kernel@vger.kernel.org, ajd@linux.ibm.com, alex@ghiti.fr,
	aou@eecs.berkeley.edu, bagasdotme@gmail.com,
	catalin.marinas@arm.com, conor+dt@kernel.org, corbet@lwn.net,
	dan.j.williams@intel.com, davidmcerdeira@osyx.tech,
	devicetree@vger.kernel.org, dev@kael-k.io, haren@linux.ibm.com,
	heiko@sntech.de, jose@osyx.tech, kever.yang@rock-chips.com,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux@armlinux.org.uk, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, maddy@linux.ibm.com,
	mani@kernel.org, nathan@kernel.org, neil.armstrong@linaro.org,
	palmer@dabbelt.com, pjw@kernel.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com, robh@kernel.org,
	will@kernel.org
Subject: Re: [PATCH 2/5] virt: add Bao IPC shared memory driver
Date: Wed, 24 Dec 2025 16:54:40 +0100	[thread overview]
Message-ID: <2025122401-drainer-pedigree-45ae@gregkh> (raw)
In-Reply-To: <20251224135217.25350-3-joaopeixoto@osyx.tech>

On Wed, Dec 24, 2025 at 01:52:14PM +0000, joaopeixoto@osyx.tech wrote:
> +struct class *cl;

Why not just use the misc device api instead?  No need for a full class
for just one char device, right?  Or even if you have multiple ones,
again, no need for a whole class.  That should make the code much
simpler overall.

thanks,

greg k-h


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: joaopeixoto@osyx.tech
Cc: linux-kernel@vger.kernel.org, ajd@linux.ibm.com, alex@ghiti.fr,
	aou@eecs.berkeley.edu, bagasdotme@gmail.com,
	catalin.marinas@arm.com, conor+dt@kernel.org, corbet@lwn.net,
	dan.j.williams@intel.com, davidmcerdeira@osyx.tech,
	devicetree@vger.kernel.org, dev@kael-k.io, haren@linux.ibm.com,
	heiko@sntech.de, jose@osyx.tech, kever.yang@rock-chips.com,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux@armlinux.org.uk, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, maddy@linux.ibm.com,
	mani@kernel.org, nathan@kernel.org, neil.armstrong@linaro.org,
	palmer@dabbelt.com, pjw@kernel.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com, robh@kernel.org,
	will@kernel.org
Subject: Re: [PATCH 2/5] virt: add Bao IPC shared memory driver
Date: Wed, 24 Dec 2025 16:54:40 +0100	[thread overview]
Message-ID: <2025122401-drainer-pedigree-45ae@gregkh> (raw)
In-Reply-To: <20251224135217.25350-3-joaopeixoto@osyx.tech>

On Wed, Dec 24, 2025 at 01:52:14PM +0000, joaopeixoto@osyx.tech wrote:
> +struct class *cl;

Why not just use the misc device api instead?  No need for a full class
for just one char device, right?  Or even if you have multiple ones,
again, no need for a whole class.  That should make the code much
simpler overall.

thanks,

greg k-h

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-12-24 15:55 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24 13:52 [PATCH 0/5] virt: Add Bao hypervisor IPC and I/O dispatcher drivers joaopeixoto
2025-12-24 13:52 ` joaopeixoto
2025-12-24 13:52 ` [PATCH 1/5] dt-bindings: Add Bao IPC shared memory driver binding joaopeixoto
2025-12-24 13:52   ` joaopeixoto
2025-12-24 16:18   ` Rob Herring (Arm)
2025-12-24 16:18     ` Rob Herring (Arm)
2025-12-25  8:57   ` Krzysztof Kozlowski
2025-12-25  8:57     ` Krzysztof Kozlowski
2025-12-24 13:52 ` [PATCH 2/5] virt: add Bao IPC shared memory driver joaopeixoto
2025-12-24 13:52   ` joaopeixoto
2025-12-24 15:53   ` Greg KH
2025-12-24 15:53     ` Greg KH
2025-12-24 15:54   ` Greg KH [this message]
2025-12-24 15:54     ` Greg KH
2025-12-25  9:02   ` Krzysztof Kozlowski
2025-12-25  9:02     ` Krzysztof Kozlowski
2025-12-24 13:52 ` [PATCH 3/5] dt-bindings: Add Bao I/O dispatcher driver binding joaopeixoto
2025-12-24 13:52   ` joaopeixoto
2025-12-24 16:18   ` Rob Herring (Arm)
2025-12-24 16:18     ` Rob Herring (Arm)
2025-12-25  8:58   ` Krzysztof Kozlowski
2025-12-25  8:58     ` Krzysztof Kozlowski
2025-12-24 13:52 ` [PATCH 4/5] virt: add Bao I/O dispatcher driver joaopeixoto
2025-12-25  9:12   ` Krzysztof Kozlowski
2025-12-25  9:12     ` Krzysztof Kozlowski
2025-12-24 13:52 ` [PATCH 5/5] MAINTAINERS: Add entries for Bao hypervisor drivers, headers, and DT bindings joaopeixoto
2025-12-24 13:52   ` joaopeixoto
2025-12-25  8:52   ` Krzysztof Kozlowski
2025-12-25  8:52     ` Krzysztof Kozlowski
2025-12-25  8:51 ` [PATCH 0/5] virt: Add Bao hypervisor IPC and I/O dispatcher drivers Krzysztof Kozlowski
2025-12-25  8:51   ` Krzysztof Kozlowski
2026-01-07 16:28 ` [PATCH v2 0/6] " joaopeixoto
2026-01-07 16:28   ` joaopeixoto
2026-01-07 16:28   ` [PATCH 1/6] dt-bindings: Add Bao IPC shared memory driver binding joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-07 16:46     ` Krzysztof Kozlowski
2026-01-07 16:46       ` Krzysztof Kozlowski
2026-01-07 16:28   ` [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-07 18:54     ` Randy Dunlap
2026-01-07 18:54       ` Randy Dunlap
2026-01-14 20:37     ` Andrew Jones
2026-01-14 20:37       ` Andrew Jones
2026-01-07 16:28   ` [PATCH 3/6] dt-bindings: Add Bao I/O dispatcher driver binding joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-07 16:47     ` Krzysztof Kozlowski
2026-01-07 16:47       ` Krzysztof Kozlowski
2026-01-07 16:28   ` [PATCH 4/6] virt: bao: Add Bao I/O dispatcher driver joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-14 20:32     ` Andrew Jones
2026-01-14 20:32       ` Andrew Jones
2026-01-07 16:28   ` [PATCH 5/6] virt: bao: Move BAO_IPCSHMEM_HYPERCALL_ID to common header joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-07 19:36     ` Greg KH
2026-01-07 19:36       ` Greg KH
2026-01-14 20:34     ` Andrew Jones
2026-01-14 20:34       ` Andrew Jones
2026-01-07 16:28   ` [PATCH 6/6] MAINTAINERS: Add entries for Bao hypervisor drivers, headers, and DT bindings joaopeixoto
2026-01-07 16:28     ` joaopeixoto
2026-01-07 19:37   ` [PATCH v2 0/6] virt: Add Bao hypervisor IPC and I/O dispatcher drivers Greg KH
2026-01-07 19:37     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025122401-drainer-pedigree-45ae@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ajd@linux.ibm.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bagasdotme@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=davidmcerdeira@osyx.tech \
    --cc=dev@kael-k.io \
    --cc=devicetree@vger.kernel.org \
    --cc=haren@linux.ibm.com \
    --cc=heiko@sntech.de \
    --cc=joaopeixoto@osyx.tech \
    --cc=jose@osyx.tech \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=maddy@linux.ibm.com \
    --cc=mani@kernel.org \
    --cc=nathan@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.