From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Jie Gan <jie.gan@oss.qualcomm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Mao Jinlong <jinlong.mao@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Jie Gan <jie.gan@oss.qualcomm.com>
Subject: Re: [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list
Date: Fri, 26 Dec 2025 16:17:14 +0300 [thread overview]
Message-ID: <202512251923.GDSbVal1-lkp@intel.com> (raw)
In-Reply-To: <20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4@oss.qualcomm.com>
Hi Jie,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Jie-Gan/coresight-core-Refactoring-ctcu_get_active_port-and-make-it-generic/20251224-171604
base: 47b7b5e32bb7264b51b89186043e1ada4090b558
patch link: https://lore.kernel.org/r/20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4%40oss.qualcomm.com
patch subject: [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list
config: arm-randconfig-r073-20251225 (https://download.01.org/0day-ci/archive/20251225/202512251923.GDSbVal1-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 4ef602d446057dabf5f61fb221669ecbeda49279)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202512251923.GDSbVal1-lkp@intel.com/
smatch warnings:
drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing freed memory 'new_node' (line 1991)
drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing zero to 'PTR_ERR'
vim +/new_node +1992 drivers/hwtracing/coresight/coresight-tmc-etr.c
34af91eeb7e78e Jie Gan 2025-12-24 1959 int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes)
34af91eeb7e78e Jie Gan 2025-12-24 1960 {
34af91eeb7e78e Jie Gan 2025-12-24 1961 struct etr_buf_node *new_node;
34af91eeb7e78e Jie Gan 2025-12-24 1962 struct etr_buf *sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1963 int i = 0, ret = 0;
34af91eeb7e78e Jie Gan 2025-12-24 1964
34af91eeb7e78e Jie Gan 2025-12-24 1965 /* We dont need a list if there is only one node */
34af91eeb7e78e Jie Gan 2025-12-24 1966 if (num_nodes < 2)
34af91eeb7e78e Jie Gan 2025-12-24 1967 return -EINVAL;
34af91eeb7e78e Jie Gan 2025-12-24 1968
34af91eeb7e78e Jie Gan 2025-12-24 1969 /* We expect that sysfs_buf in drvdata has already been allocated. */
34af91eeb7e78e Jie Gan 2025-12-24 1970 if (drvdata->sysfs_buf) {
34af91eeb7e78e Jie Gan 2025-12-24 1971 /* Directly insert the allocated sysfs_buf into the list first */
34af91eeb7e78e Jie Gan 2025-12-24 1972 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
34af91eeb7e78e Jie Gan 2025-12-24 1973 if (IS_ERR(new_node))
34af91eeb7e78e Jie Gan 2025-12-24 1974 return PTR_ERR(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 1975
34af91eeb7e78e Jie Gan 2025-12-24 1976 new_node->sysfs_buf = drvdata->sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1977 new_node->is_free = false;
34af91eeb7e78e Jie Gan 2025-12-24 1978 list_add(&new_node->node, &drvdata->etr_buf_list);
34af91eeb7e78e Jie Gan 2025-12-24 1979 i++;
34af91eeb7e78e Jie Gan 2025-12-24 1980 }
34af91eeb7e78e Jie Gan 2025-12-24 1981
34af91eeb7e78e Jie Gan 2025-12-24 1982 while (i < num_nodes) {
34af91eeb7e78e Jie Gan 2025-12-24 1983 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
34af91eeb7e78e Jie Gan 2025-12-24 1984 if (IS_ERR(new_node)) {
34af91eeb7e78e Jie Gan 2025-12-24 1985 ret = PTR_ERR(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 1986 break;
34af91eeb7e78e Jie Gan 2025-12-24 1987 }
34af91eeb7e78e Jie Gan 2025-12-24 1988
34af91eeb7e78e Jie Gan 2025-12-24 1989 sysfs_buf = tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0), NULL);
34af91eeb7e78e Jie Gan 2025-12-24 1990 if (IS_ERR(sysfs_buf)) {
34af91eeb7e78e Jie Gan 2025-12-24 @1991 kfree(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 @1992 ret = PTR_ERR(new_node);
s/new_node/sysfs_buf/
34af91eeb7e78e Jie Gan 2025-12-24 1993 break;
34af91eeb7e78e Jie Gan 2025-12-24 1994 }
34af91eeb7e78e Jie Gan 2025-12-24 1995
34af91eeb7e78e Jie Gan 2025-12-24 1996 /* We dont have a available sysfs_buf in drvdata, setup one */
34af91eeb7e78e Jie Gan 2025-12-24 1997 if (!drvdata->sysfs_buf) {
34af91eeb7e78e Jie Gan 2025-12-24 1998 drvdata->sysfs_buf = sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1999 new_node->is_free = false;
34af91eeb7e78e Jie Gan 2025-12-24 2000 } else
34af91eeb7e78e Jie Gan 2025-12-24 2001 new_node->is_free = true;
34af91eeb7e78e Jie Gan 2025-12-24 2002
34af91eeb7e78e Jie Gan 2025-12-24 2003 new_node->sysfs_buf = sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 2004 list_add(&new_node->node, &drvdata->etr_buf_list);
34af91eeb7e78e Jie Gan 2025-12-24 2005 i++;
34af91eeb7e78e Jie Gan 2025-12-24 2006 }
34af91eeb7e78e Jie Gan 2025-12-24 2007
34af91eeb7e78e Jie Gan 2025-12-24 2008 /* Clean the list if there is an error */
34af91eeb7e78e Jie Gan 2025-12-24 2009 if (ret)
34af91eeb7e78e Jie Gan 2025-12-24 2010 tmc_clean_etr_buf_list(drvdata);
34af91eeb7e78e Jie Gan 2025-12-24 2011
34af91eeb7e78e Jie Gan 2025-12-24 2012 return ret;
34af91eeb7e78e Jie Gan 2025-12-24 2013 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list
Date: Thu, 25 Dec 2025 20:00:11 +0800 [thread overview]
Message-ID: <202512251923.GDSbVal1-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4@oss.qualcomm.com>
References: <20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4@oss.qualcomm.com>
TO: Jie Gan <jie.gan@oss.qualcomm.com>
TO: Suzuki K Poulose <suzuki.poulose@arm.com>
TO: Mike Leach <mike.leach@linaro.org>
TO: James Clark <james.clark@linaro.org>
TO: Alexander Shishkin <alexander.shishkin@linux.intel.com>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>
TO: Mao Jinlong <jinlong.mao@oss.qualcomm.com>
TO: Bjorn Andersson <andersson@kernel.org>
TO: Konrad Dybcio <konradybcio@kernel.org>
CC: coresight@lists.linaro.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-msm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: Jie Gan <jie.gan@oss.qualcomm.com>
Hi Jie,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 47b7b5e32bb7264b51b89186043e1ada4090b558]
url: https://github.com/intel-lab-lkp/linux/commits/Jie-Gan/coresight-core-Refactoring-ctcu_get_active_port-and-make-it-generic/20251224-171604
base: 47b7b5e32bb7264b51b89186043e1ada4090b558
patch link: https://lore.kernel.org/r/20251224-enable-byte-cntr-for-ctcu-v9-2-886c4496fed4%40oss.qualcomm.com
patch subject: [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago
config: arm-randconfig-r073-20251225 (https://download.01.org/0day-ci/archive/20251225/202512251923.GDSbVal1-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 4ef602d446057dabf5f61fb221669ecbeda49279)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512251923.GDSbVal1-lkp@intel.com/
smatch warnings:
drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing freed memory 'new_node' (line 1991)
drivers/hwtracing/coresight/coresight-tmc-etr.c:1992 tmc_create_etr_buf_list() warn: passing zero to 'PTR_ERR'
vim +/new_node +1992 drivers/hwtracing/coresight/coresight-tmc-etr.c
34af91eeb7e78e Jie Gan 2025-12-24 1951
34af91eeb7e78e Jie Gan 2025-12-24 1952 /**
34af91eeb7e78e Jie Gan 2025-12-24 1953 * tmc_create_etr_buf_list - create a list to manage the etr_buf_node.
34af91eeb7e78e Jie Gan 2025-12-24 1954 * @drvdata: driver data of the TMC device.
34af91eeb7e78e Jie Gan 2025-12-24 1955 * @num_nodes: number of nodes want to create with the list.
34af91eeb7e78e Jie Gan 2025-12-24 1956 *
34af91eeb7e78e Jie Gan 2025-12-24 1957 * Return 0 upon success and return the error number if fail.
34af91eeb7e78e Jie Gan 2025-12-24 1958 */
34af91eeb7e78e Jie Gan 2025-12-24 1959 int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes)
34af91eeb7e78e Jie Gan 2025-12-24 1960 {
34af91eeb7e78e Jie Gan 2025-12-24 1961 struct etr_buf_node *new_node;
34af91eeb7e78e Jie Gan 2025-12-24 1962 struct etr_buf *sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1963 int i = 0, ret = 0;
34af91eeb7e78e Jie Gan 2025-12-24 1964
34af91eeb7e78e Jie Gan 2025-12-24 1965 /* We dont need a list if there is only one node */
34af91eeb7e78e Jie Gan 2025-12-24 1966 if (num_nodes < 2)
34af91eeb7e78e Jie Gan 2025-12-24 1967 return -EINVAL;
34af91eeb7e78e Jie Gan 2025-12-24 1968
34af91eeb7e78e Jie Gan 2025-12-24 1969 /* We expect that sysfs_buf in drvdata has already been allocated. */
34af91eeb7e78e Jie Gan 2025-12-24 1970 if (drvdata->sysfs_buf) {
34af91eeb7e78e Jie Gan 2025-12-24 1971 /* Directly insert the allocated sysfs_buf into the list first */
34af91eeb7e78e Jie Gan 2025-12-24 1972 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
34af91eeb7e78e Jie Gan 2025-12-24 1973 if (IS_ERR(new_node))
34af91eeb7e78e Jie Gan 2025-12-24 1974 return PTR_ERR(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 1975
34af91eeb7e78e Jie Gan 2025-12-24 1976 new_node->sysfs_buf = drvdata->sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1977 new_node->is_free = false;
34af91eeb7e78e Jie Gan 2025-12-24 1978 list_add(&new_node->node, &drvdata->etr_buf_list);
34af91eeb7e78e Jie Gan 2025-12-24 1979 i++;
34af91eeb7e78e Jie Gan 2025-12-24 1980 }
34af91eeb7e78e Jie Gan 2025-12-24 1981
34af91eeb7e78e Jie Gan 2025-12-24 1982 while (i < num_nodes) {
34af91eeb7e78e Jie Gan 2025-12-24 1983 new_node = kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL);
34af91eeb7e78e Jie Gan 2025-12-24 1984 if (IS_ERR(new_node)) {
34af91eeb7e78e Jie Gan 2025-12-24 1985 ret = PTR_ERR(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 1986 break;
34af91eeb7e78e Jie Gan 2025-12-24 1987 }
34af91eeb7e78e Jie Gan 2025-12-24 1988
34af91eeb7e78e Jie Gan 2025-12-24 1989 sysfs_buf = tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0), NULL);
34af91eeb7e78e Jie Gan 2025-12-24 1990 if (IS_ERR(sysfs_buf)) {
34af91eeb7e78e Jie Gan 2025-12-24 @1991 kfree(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 @1992 ret = PTR_ERR(new_node);
34af91eeb7e78e Jie Gan 2025-12-24 1993 break;
34af91eeb7e78e Jie Gan 2025-12-24 1994 }
34af91eeb7e78e Jie Gan 2025-12-24 1995
34af91eeb7e78e Jie Gan 2025-12-24 1996 /* We dont have a available sysfs_buf in drvdata, setup one */
34af91eeb7e78e Jie Gan 2025-12-24 1997 if (!drvdata->sysfs_buf) {
34af91eeb7e78e Jie Gan 2025-12-24 1998 drvdata->sysfs_buf = sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 1999 new_node->is_free = false;
34af91eeb7e78e Jie Gan 2025-12-24 2000 } else
34af91eeb7e78e Jie Gan 2025-12-24 2001 new_node->is_free = true;
34af91eeb7e78e Jie Gan 2025-12-24 2002
34af91eeb7e78e Jie Gan 2025-12-24 2003 new_node->sysfs_buf = sysfs_buf;
34af91eeb7e78e Jie Gan 2025-12-24 2004 list_add(&new_node->node, &drvdata->etr_buf_list);
34af91eeb7e78e Jie Gan 2025-12-24 2005 i++;
34af91eeb7e78e Jie Gan 2025-12-24 2006 }
34af91eeb7e78e Jie Gan 2025-12-24 2007
34af91eeb7e78e Jie Gan 2025-12-24 2008 /* Clean the list if there is an error */
34af91eeb7e78e Jie Gan 2025-12-24 2009 if (ret)
34af91eeb7e78e Jie Gan 2025-12-24 2010 tmc_clean_etr_buf_list(drvdata);
34af91eeb7e78e Jie Gan 2025-12-24 2011
34af91eeb7e78e Jie Gan 2025-12-24 2012 return ret;
34af91eeb7e78e Jie Gan 2025-12-24 2013 }
34af91eeb7e78e Jie Gan 2025-12-24 2014 EXPORT_SYMBOL_GPL(tmc_create_etr_buf_list);
34af91eeb7e78e Jie Gan 2025-12-24 2015
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2025-12-26 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 12:00 kernel test robot [this message]
2025-12-26 13:17 ` [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list Dan Carpenter
2025-12-29 1:10 ` Jie Gan
-- strict thread matches above, loose matches on Subject: below --
2025-12-24 9:06 [PATCH v9 0/8] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2025-12-24 9:06 ` [PATCH v9 1/8] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2025-12-24 9:06 ` [PATCH v9 2/8] coresight: tmc: add create/clean functions for etr_buf_list Jie Gan
2025-12-24 9:06 ` [PATCH v9 3/8] coresight: tmc: Introduce sysfs_read_ops to wrap sysfs read operations Jie Gan
2025-12-24 9:06 ` [PATCH v9 4/8] coresight: etr: refactor the tmc_etr_get_catu_device function Jie Gan
2025-12-24 9:06 ` [PATCH v9 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2025-12-24 9:06 ` [PATCH v9 6/8] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2025-12-24 9:06 ` [PATCH v9 7/8] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops Jie Gan
2025-12-24 9:06 ` [PATCH v9 8/8] arm64: dts: qcom: lemans: add interrupts to CTCU device Jie Gan
2026-01-06 7:15 ` [PATCH v9 0/8] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2026-01-14 7:48 ` Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512251923.GDSbVal1-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mike.leach@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.