[sj:damon/next 101/108] mm/memory.c:7487:1: sparse: sparse: symbol 'faults_monitor_controls_lock' was not declared. Should it be static?

[sj:damon/next 101/108] mm/memory.c:7487:1: sparse: sparse: symbol 'faults_monitor_controls_lock' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   777b25c5baaa9e69b7ed0f963d0db781b36776c7
commit: e874404e9937c662290222d6cd67b7e07b82420a [101/108] mm/memory: implement functions and data structures for page faults monitoring
config: microblaze-randconfig-r123-20251226 (https://download.01.org/0day-ci/archive/20251226/202512261908.fhV5eWFj-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251226/202512261908.fhV5eWFj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512261908.fhV5eWFj-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> mm/memory.c:7487:1: sparse: sparse: symbol 'faults_monitor_controls_lock' was not declared. Should it be static?
   mm/memory.c:1332:9: sparse: sparse: context imbalance in 'copy_pte_range' - unexpected unlock
   mm/memory.c:2221:16: sparse: sparse: context imbalance in '__get_locked_pte' - different lock contexts for basic block
   mm/memory.c:2327:9: sparse: sparse: context imbalance in 'insert_page' - unexpected unlock
   mm/memory.c:2612:9: sparse: sparse: context imbalance in 'insert_pfn' - unexpected unlock
   mm/memory.c:3194:17: sparse: sparse: context imbalance in 'apply_to_pte_range' - unexpected unlock
   mm/memory.c:3827:42: sparse: sparse: context imbalance in 'wp_page_copy' - different lock contexts for basic block
   mm/memory.c:3866:19: sparse: sparse: context imbalance in 'finish_mkwrite_fault' - different lock contexts for basic block
   mm/memory.c:3897:17: sparse: sparse: context imbalance in 'wp_pfn_shared' - unexpected unlock
   mm/memory.c:3923:17: sparse: sparse: context imbalance in 'wp_page_shared' - unexpected unlock
   mm/memory.c:4089:19: sparse: sparse: context imbalance in 'do_wp_page' - different lock contexts for basic block
   mm/memory.c:4351:9: sparse: sparse: context imbalance in 'remove_device_exclusive_entry' - different lock contexts for basic block
   mm/memory.c:4392:19: sparse: sparse: context imbalance in 'pte_marker_clear' - different lock contexts for basic block
   mm/memory.c:4646:12: sparse: sparse: context imbalance in 'do_swap_page' - unexpected unlock
   mm/memory.c:5263:9: sparse: sparse: context imbalance in 'do_anonymous_page' - different lock contexts for basic block
   mm/memory.c:5495:12: sparse: sparse: context imbalance in 'finish_fault' - different lock contexts for basic block
   mm/memory.c:5879:9: sparse: sparse: context imbalance in 'do_fault' - different lock contexts for basic block
   mm/memory.c:6008:17: sparse: sparse: context imbalance in 'do_numa_page' - unexpected unlock
   mm/memory.c:6225:17: sparse: sparse: context imbalance in 'do_damon_page' - unexpected unlock
   mm/memory.c:6299:34: sparse: sparse: context imbalance in 'handle_pte_fault' - unexpected unlock
   mm/memory.c:6782:5: sparse: sparse: context imbalance in 'follow_pfnmap_start' - different lock contexts for basic block
   mm/memory.c:6868:28: sparse: sparse: context imbalance in 'follow_pfnmap_end' - unexpected unlock

vim +/faults_monitor_controls_lock +7487 mm/memory.c

  7485	
  7486	static LIST_HEAD(faults_monitor_controls);
> 7487	DEFINE_SPINLOCK(faults_monitor_controls_lock);
  7488	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [sj:damon/next 101/108] mm/memory.c:7487:1: sparse: sparse: symbol 'faults_monitor_controls_lock' was not declared. Should it be static?

[SeongJae Park]

On Fri, 26 Dec 2025 20:00:49 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   777b25c5baaa9e69b7ed0f963d0db781b36776c7
> commit: e874404e9937c662290222d6cd67b7e07b82420a [101/108] mm/memory: implement functions and data structures for page faults monitoring
> config: microblaze-randconfig-r123-20251226 (https://download.01.org/0day-ci/archive/20251226/202512261908.fhV5eWFj-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251226/202512261908.fhV5eWFj-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202512261908.fhV5eWFj-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> mm/memory.c:7487:1: sparse: sparse: symbol 'faults_monitor_controls_lock' was not declared. Should it be static?

Thank you for the report, just pushed a fix:
http://git.kernel.org/sj/c/1d3e0ce41f6d


Thanks,
SJ

[...]