Re: [Buildroot] [PATCH 1/2] package/nqptp: Add version 1.2.4

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Trammell,

Sorry for the long delay in taking your contribution into account. I
have merged it after a number of changes, see below.

First, I've adjusted the commit title to:

	package/nqptp: new package

On Sat, 25 Oct 2025 13:05:39 -0600
Trammell Hudson via buildroot <buildroot@buildroot.org> wrote:

> This is the Not Quite PTP timing library necessary for
> AirPlay2 support with shairport-sync.
> 
> Signed-off-by: Trammell Hudson <hudson@trmm.net>
> ---
>  package/Config.in        |  1 +
>  package/nqptp/Config.in  |  6 ++++++
>  package/nqptp/S90nqptp   | 24 ++++++++++++++++++++++++
>  package/nqptp/nqptp.hash |  3 +++
>  package/nqptp/nqptp.mk   | 31 +++++++++++++++++++++++++++++++
>  5 files changed, 65 insertions(+)

I've added an entry in the DEVELOPERS file.


> diff --git a/package/nqptp/Config.in b/package/nqptp/Config.in
> new file mode 100644
> index 0000000000..cddb12e4d0
> --- /dev/null
> +++ b/package/nqptp/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_NQPTP
> +	bool "NQPTP"

Changed to:

	bool "nqptp"

I've added:

	depends on BR2_USE_MMU

as it doesn't build for noMMU platforms.

And also, I've added:

	select BR2_PACKAGE_LIBCONFIG

since you have a build-time dependency on it.

> +	help
> +	  Not Quite PTP for shairport-sync AirPlay 2 support.
> +	  https://github.com/mikebrady/shairport-sync

Changed to:

+         nqptp is a daemon that monitors timing data from PTP clocks
+         it sees on ports 319 and 320. It maintains records for one
+         clock, identified by its Clock ID.
+
+         It is a companion application to Shairport Sync and provides
+         timing information for AirPlay 2 operation.
+
+         https://github.com/mikebrady/nqptp

The important bit being that the homepage URL of the project is on a
separate line, which our coding style requires.

> +
> diff --git a/package/nqptp/S90nqptp b/package/nqptp/S90nqptp
> new file mode 100644
> index 0000000000..41dbb4749a
> --- /dev/null
> +++ b/package/nqptp/S90nqptp
> @@ -0,0 +1,24 @@
> +#! /bin/sh

I've fixed this script so that it is modeled after our standard
package/busybox/S01syslogd script.


> diff --git a/package/nqptp/nqptp.hash b/package/nqptp/nqptp.hash
> new file mode 100644
> index 0000000000..a1b686c1a9
> --- /dev/null
> +++ b/package/nqptp/nqptp.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  1df1d5edd5b713010d6495b3abca4c1cf4ad8fa6029df0abeb9e4de8e0eb707a  nqptp-1.2.4.tar.gz
> +sha256  1daaa904985807b7f9f2fa91f6b19f3faadf8df4e813f7451a691f89a6965e3f  LICENSES

LICENSES didn't exist.

> diff --git a/package/nqptp/nqptp.mk b/package/nqptp/nqptp.mk
> new file mode 100644
> index 0000000000..11dac9f10e
> --- /dev/null
> +++ b/package/nqptp/nqptp.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# nqptp
> +#
> +################################################################################
> +
> +NQPTP_VERSION = 1.2.4
> +NQPTP_SITE = $(call github,mikebrady,nqptp,$(NQPTP_VERSION))
> +

I dropped this empty line.

> +NQPTP_LICENSE = MIT, BSD-3-Clause

License is GPL-2.0.

> +NQPTP_LICENSE_FILES = LICENSES

The file is LICENSE, not LICENSES.

> +NQPTP_DEPENDENCIES = libconfig host-pkgconf
> +
> +# git clone, no configure
> +NQPTP_AUTORECONF = YES
> +
> +NQPTP_CONF_OPTS = 

Dropped.

> +#NQPTP_CONF_ENV += LIBS="$(NQPTP_CONF_LIBS)"

Dropped.

> +
> +define NQPTP_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/nqptp \
> +		$(TARGET_DIR)/usr/bin/nqptp
> +endef
> +
> +define NQPTP_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/nqptp/S90nqptp \
> +		$(TARGET_DIR)/etc/init.d/S90nqptp
> +endef
> +
> +$(eval $(autotools-package))

Applied with all those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot