Re: [Buildroot] [PATCH 2/2] package/shairport-sync: Add support for AirPlay2

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Trammell,

Thanks for your patch, which I have applied, after doing some tweaks.
See below.

On Sat, 25 Oct 2025 13:06:10 -0600
Trammell Hudson via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/shairport-sync/Config.in b/package/shairport-sync/Config.in
> index 528767ba9c..fddba4a439 100644
> --- a/package/shairport-sync/Config.in
> +++ b/package/shairport-sync/Config.in
> @@ -26,6 +26,21 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_CONVOLUTION
>  	help
>  	  Enable audio DSP convolution support.
>  
> +config BR2_PACKAGE_SHAIRPORT_SYNC_AIRPLAY2
> +	bool "AirPlay2 support"
> +	select BR2_PACKAGE_NQPTP

Added an indication in a comment that this is a runtime dependency (as
opposed to a build time dependency).

> +	select BR2_PACKAGE_LIBPLIST
> +	select BR2_PACKAGE_LIBSODIUM
> +	select BR2_PACKAGE_LIBGCRYPT
> +	select BR2_PACKAGE_FFMPEG
> +	select BR2_PACKAGE_FFMPEG_GPL
> +	select BR2_PACKAGE_FFMPEG_NONFREE

These two were not needed according to my testing
(BR2_PACKAGE_FFMPEG_GPL BR2_PACKAGE_FFMPEG_NONFREE).

> +ifeq ($(BR2_PACKAGE_SHAIRPORT_SYNC_AIRPLAY2),y)
> +SHAIRPORT_SYNC_DEPENDENCIES += libplist libsodium libgcrypt ffmpeg util-linux

I've added host-vim in this list because the "xxd" tool is needed on
the host, and the host-vim package provides it.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot