From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: bingbu.cao@linux.intel.com, tian.shu.qiu@intel.com,
antti.laakso@linux.intel.com, mehdi.djait@linux.intel.com
Subject: [PATCH v3 06/13] media: ipu6: Don't check pipeline in stream_start
Date: Tue, 30 Dec 2025 15:10:06 +0200 [thread overview]
Message-ID: <20251230131013.75338-7-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20251230131013.75338-1-sakari.ailus@linux.intel.com>
A pipeline exists when start_streaming has returned so the check for
start_streaming_called is equivalent to having media_pipeline. Use
vb2_start_streaming_called() to perform the check.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
index fdf41b3cf60e..dcad6aafee29 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
@@ -355,8 +355,6 @@ static void buf_queue(struct vb2_buffer *vb)
vb2_buffer_to_ipu6_isys_video_buffer(vvb);
struct ipu6_isys_buffer *ib = &ivb->ib;
struct device *dev = &av->isys->adev->auxdev.dev;
- struct media_pipeline *media_pipe =
- media_entity_pipeline(&av->vdev.entity);
struct ipu6_fw_isys_frame_buff_set_abi *buf = NULL;
struct ipu6_isys_stream *stream = av->stream;
struct ipu6_isys_buffer_list bl;
@@ -374,8 +372,8 @@ static void buf_queue(struct vb2_buffer *vb)
list_add(&ib->head, &aq->incoming);
spin_unlock_irqrestore(&aq->lock, flags);
- if (!media_pipe || !vb->vb2_queue->start_streaming_called) {
- dev_dbg(dev, "media pipeline is not ready for %s\n",
+ if (!vb2_start_streaming_called(vb->vb2_queue)) {
+ dev_dbg(dev, "start_streaming hasn't been called yet on %s\n",
av->vdev.name);
return;
}
--
2.47.3
next prev parent reply other threads:[~2025-12-30 13:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 13:10 [PATCH v3 00/13] IPU6 driver cleanups and fixes Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 01/13] media: ipu6: Ensure stream_mutex is acquired when dealing with node list Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 02/13] media: ipu6: Drop MMU hardware initialisation in probe() Sakari Ailus
2025-12-31 5:38 ` Bingbu Cao
2026-01-01 19:39 ` Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 03/13] media: ipu6: Remove redundant driver data checks Sakari Ailus
2025-12-31 5:43 ` Bingbu Cao
2025-12-30 13:10 ` [PATCH v3 04/13] media: ipu6: Make symbols static Sakari Ailus
2025-12-31 5:46 ` Bingbu Cao
2025-12-30 13:10 ` [PATCH v3 05/13] media: ipu6: Remove redundant streaming start via buffer queueing Sakari Ailus
2025-12-31 6:01 ` Bingbu Cao
2026-01-01 19:51 ` Sakari Ailus
2026-01-05 3:07 ` Bingbu Cao
2025-12-30 13:10 ` Sakari Ailus [this message]
2025-12-30 13:10 ` [PATCH v3 07/13] media: ipu6: Close firmware streams on streaming enable failure Sakari Ailus
2025-12-31 6:11 ` Bingbu Cao
2026-01-01 19:58 ` Sakari Ailus
2026-01-05 3:07 ` Bingbu Cao
2026-01-07 21:55 ` Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 08/13] media: ipu6: Drop error argument from ipu6_isys_stream_start() Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 09/13] media: ipu6: Obtain remote pad using media_pad_remote_pad_unique() Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 10/13] media: ipu6: Obtain unique source pad from remote sub-device Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 11/13] media: ipu6: Remove source_entity from struct ipu6_isys_stream Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 12/13] media: ipu6: Drop custom functions to obtain sd state information Sakari Ailus
2025-12-30 13:10 ` [PATCH v3 13/13] media: ipu6: Always call video_device_pipeline_alloc_start() Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230131013.75338-7-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.