Re: [PATCH v3 05/13] media: ipu6: Remove redundant streaming start via buffer queueing

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Hi, Sakari,

On 12/30/25 9:10 PM, Sakari Ailus wrote:
> The videobuf2 framework will ensure buffers are queued before streaming is
> started.

The logic is only applicable for !start_streaming_called, right?
I am not sure it work for multiplex streams like metadata + frame
capture case.

>Remove support for starting starting streaming via the

double 'starting' here.

> buf_queue() callback.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> index 8f05987cdb4e..fdf41b3cf60e 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> @@ -408,13 +408,6 @@ static void buf_queue(struct vb2_buffer *vb)
>  	ipu6_isys_buf_to_fw_frame_buf(buf, stream, &bl);
>  	ipu6_fw_isys_dump_frame_buff_set(dev, buf, stream->nr_output_pins);
>  
> -	if (!stream->streaming) {
> -		ret = ipu6_isys_stream_start(av, &bl, true);
> -		if (ret)
> -			dev_err(dev, "stream start failed.\n");
> -		goto out;
> -	}
> -
>  	/*
>  	 * We must queue the buffers in the buffer list to the
>  	 * appropriate video buffer queues BEFORE passing them to the
> 

-- 
Best regards,
Bingbu Cao