[PATCH 0/2] arm: dts: lpc32xx: Set motor control PWM clock as required one

[PATCH 0/2] arm: dts: lpc32xx: Set motor control PWM clock as required one

[Vladimir Zapolskiy]

Motor Control PWM depends on its own supply clock, the clock gate control
is present in TIMCLK_CTRL1 register.

Vladimir Zapolskiy (2):
  dt-bindings: pwm: nxp,lpc32xx-pwm: Specify clocks property as mandatory
  arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node

 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml | 4 ++++
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi                     | 1 +
 2 files changed, 5 insertions(+)

-- 
2.43.0

[PATCH 1/2] dt-bindings: pwm: nxp,lpc32xx-pwm: Specify clocks property as mandatory

[Vladimir Zapolskiy]

Both described in the binding PWM controllers depend on supply clocks,
thus it's necessary to specify 'clocks' property in the correspondent
device tree nodes.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
index d8ebb0735c96..cdd83ac29caf 100644
--- a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
@@ -27,6 +27,7 @@ properties:
 required:
   - compatible
   - reg
+  - clocks
   - '#pwm-cells'
 
 allOf:
@@ -36,9 +37,12 @@ unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/lpc32xx-clock.h>
+
     pwm@4005c000 {
         compatible = "nxp,lpc3220-pwm";
         reg = <0x4005c000 0x4>;
+        clocks = <&clk LPC32XX_CLK_PWM1>;
         #pwm-cells = <3>;
     };
 
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: pwm: nxp,lpc32xx-pwm: Specify clocks property as mandatory

[Rob Herring (Arm)]

On Mon, 29 Dec 2025 00:49:06 +0200, Vladimir Zapolskiy wrote:
> Both described in the binding PWM controllers depend on supply clocks,
> thus it's necessary to specify 'clocks' property in the correspondent
> device tree nodes.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/2] dt-bindings: pwm: nxp,lpc32xx-pwm: Specify clocks property as mandatory

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hello,

On Mon, Dec 29, 2025 at 12:49:06AM +0200, Vladimir Zapolskiy wrote:
> Both described in the binding PWM controllers depend on supply clocks,
> thus it's necessary to specify 'clocks' property in the correspondent
> device tree nodes.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>

LGTM, I applied it with Rob's Ack to

	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

as 6.20-rc1 material.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH 2/2] arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node

[Vladimir Zapolskiy]

Motor Control PWM depends on its own supply clock, the clock gate control
is present in TIMCLK_CTRL1 register.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
index 39af48470ed5..abd401fda94e 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
@@ -304,6 +304,7 @@ i2c2: i2c@400a8000 {
 			mpwm: pwm@400e8000 {
 				compatible = "nxp,lpc3220-motor-pwm";
 				reg = <0x400e8000 0x78>;
+				clocks = <&clk LPC32XX_CLK_MCPWM>;
 				#pwm-cells = <3>;
 				status = "disabled";
 			};
-- 
2.43.0

Re: [PATCH 2/2] arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node

[Rob Herring]

On Mon, Dec 29, 2025 at 12:49:07AM +0200, Vladimir Zapolskiy wrote:
> Motor Control PWM depends on its own supply clock, the clock gate control
> is present in TIMCLK_CTRL1 register.

You say it is required, so does that mean this hasn't ever worked? Or it 
happened to work because something else turned on the clock?

> 

Fixes tag?

> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 39af48470ed5..abd401fda94e 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -304,6 +304,7 @@ i2c2: i2c@400a8000 {
>  			mpwm: pwm@400e8000 {
>  				compatible = "nxp,lpc3220-motor-pwm";
>  				reg = <0x400e8000 0x78>;
> +				clocks = <&clk LPC32XX_CLK_MCPWM>;
>  				#pwm-cells = <3>;
>  				status = "disabled";
>  			};
> -- 
> 2.43.0
> 

Re: [PATCH 2/2] arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node

[Vladimir Zapolskiy]

On 12/30/25 19:59, Rob Herring wrote:
> On Mon, Dec 29, 2025 at 12:49:07AM +0200, Vladimir Zapolskiy wrote:
>> Motor Control PWM depends on its own supply clock, the clock gate control
>> is present in TIMCLK_CTRL1 register.
> 
> You say it is required, so does that mean this hasn't ever worked? Or it
> happened to work because something else turned on the clock?

There is no upstream driver for this particular PWM controller, I'm about to
submit one though, and so far I've completed my review of its dt properties.

>>
> 
> Fixes tag?

It'd make sense, however as I've said above formally there is no fixed
runtime bug, if the scope is limited to the upstream only.

Fixes: b7d41c937ed7 ("ARM: LPC32xx: Add the motor PWM to base dts file")

>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>>   arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
>> index 39af48470ed5..abd401fda94e 100644
>> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
>> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
>> @@ -304,6 +304,7 @@ i2c2: i2c@400a8000 {
>>   			mpwm: pwm@400e8000 {
>>   				compatible = "nxp,lpc3220-motor-pwm";
>>   				reg = <0x400e8000 0x78>;
>> +				clocks = <&clk LPC32XX_CLK_MCPWM>;
>>   				#pwm-cells = <3>;
>>   				status = "disabled";
>>   			};
>> -- 
>> 2.43.0
>>

-- 
Best wishes,
Vladimir