* [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats()
@ 2025-12-31 19:52 Puranjay Mohan
2025-12-31 21:41 ` Eduard Zingerman
2025-12-31 21:41 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: Puranjay Mohan @ 2025-12-31 19:52 UTC (permalink / raw)
To: bpf
Cc: Puranjay Mohan, Puranjay Mohan, Alexei Starovoitov,
Andrii Nakryiko, Daniel Borkmann, Martin KaFai Lau,
Eduard Zingerman, Kumar Kartikeya Dwivedi, kernel-team
The order of the variables in the printf() doesn't match the text and
therefore verfistat prints something like this:
Done. Processed 24 files, 0 programs. Skipped 62 files, 0 programs.
When it should print:
Done. Processed 24 files, 62 programs. Skipped 0 files, 0 programs.
Fix the order of variables in the printf() call.
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
---
tools/testing/selftests/bpf/veristat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index e962f133250c..1be1e353d40a 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -2580,7 +2580,7 @@ static void output_stats(const struct verif_stats *s, enum resfmt fmt, bool last
if (last && fmt == RESFMT_TABLE) {
output_header_underlines();
printf("Done. Processed %d files, %d programs. Skipped %d files, %d programs.\n",
- env.files_processed, env.files_skipped, env.progs_processed, env.progs_skipped);
+ env.files_processed, env.progs_processed, env.files_skipped, env.progs_skipped);
}
}
base-commit: 1a8fa7faf4890d201aad4f5d4943f74d840cd0ba
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats()
2025-12-31 19:52 [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats() Puranjay Mohan
@ 2025-12-31 21:41 ` Eduard Zingerman
2025-12-31 21:41 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Eduard Zingerman @ 2025-12-31 21:41 UTC (permalink / raw)
To: Puranjay Mohan, bpf
Cc: Puranjay Mohan, Alexei Starovoitov, Andrii Nakryiko,
Daniel Borkmann, Martin KaFai Lau, Kumar Kartikeya Dwivedi,
kernel-team
On Wed, 2025-12-31 at 11:52 -0800, Puranjay Mohan wrote:
> The order of the variables in the printf() doesn't match the text and
> therefore verfistat prints something like this:
>
> Done. Processed 24 files, 0 programs. Skipped 62 files, 0 programs.
>
> When it should print:
>
> Done. Processed 24 files, 62 programs. Skipped 0 files, 0 programs.
>
> Fix the order of variables in the printf() call.
>
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> ---
Tested-by: Eduard Zingerman <eddyz87@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats()
2025-12-31 19:52 [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats() Puranjay Mohan
2025-12-31 21:41 ` Eduard Zingerman
@ 2025-12-31 21:41 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2025-12-31 21:41 UTC (permalink / raw)
To: Puranjay Mohan
Cc: bpf, Puranjay Mohan, Alexei Starovoitov, Andrii Nakryiko,
Daniel Borkmann, Martin KaFai Lau, Eduard Zingerman,
Kumar Kartikeya Dwivedi, Kernel Team
On Wed, Dec 31, 2025 at 11:52 AM Puranjay Mohan <puranjay@kernel.org> wrote:
>
> The order of the variables in the printf() doesn't match the text and
> therefore verfistat prints something like this:
typo
> Done. Processed 24 files, 0 programs. Skipped 62 files, 0 programs.
>
> When it should print:
>
> Done. Processed 24 files, 62 programs. Skipped 0 files, 0 programs.
>
> Fix the order of variables in the printf() call.
>
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Is there a fixes tag?
Pls cc Mykyta in respin. He takes care of veristat nowadays.
pw-bot: cr
> ---
> tools/testing/selftests/bpf/veristat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
> index e962f133250c..1be1e353d40a 100644
> --- a/tools/testing/selftests/bpf/veristat.c
> +++ b/tools/testing/selftests/bpf/veristat.c
> @@ -2580,7 +2580,7 @@ static void output_stats(const struct verif_stats *s, enum resfmt fmt, bool last
> if (last && fmt == RESFMT_TABLE) {
> output_header_underlines();
> printf("Done. Processed %d files, %d programs. Skipped %d files, %d programs.\n",
> - env.files_processed, env.files_skipped, env.progs_processed, env.progs_skipped);
> + env.files_processed, env.progs_processed, env.files_skipped, env.progs_skipped);
> }
> }
>
>
> base-commit: 1a8fa7faf4890d201aad4f5d4943f74d840cd0ba
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-31 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-31 19:52 [PATCH bpf-next] selftests/bpf: veristat: fix printing order in output_stats() Puranjay Mohan
2025-12-31 21:41 ` Eduard Zingerman
2025-12-31 21:41 ` Alexei Starovoitov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.