[Buildroot] [PATCH 1/1] package/busybox: tidy up klogd init script

[Buildroot] [PATCH 1/1] package/busybox: tidy up klogd init script

[Fiona Klute via buildroot]

* Wait for process to stop before deleting PID file, instead of fixed
  wait during restart

* Use long form options

Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
---
Restarting klogd is probably not common, but it's nicer this way. :-)

 package/busybox/S02klogd | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
index 0677e1e5ca..f76d4e72d4 100644
--- a/package/busybox/S02klogd
+++ b/package/busybox/S02klogd
@@ -13,7 +13,8 @@ KLOGD_ARGS=""
 start() {
 	printf 'Starting %s: ' "$DAEMON"
 	# shellcheck disable=SC2086 # we need the word splitting
-	start-stop-daemon -b -m -S -q -p "$PIDFILE" -x "/sbin/$DAEMON" \
+	start-stop-daemon --start --background --make-pidfile \
+		--pidfile "$PIDFILE" --exec "/sbin/$DAEMON" \
 		-- -n $KLOGD_ARGS
 	status=$?
 	if [ "$status" -eq 0 ]; then
@@ -26,20 +27,24 @@ start() {
 
 stop() {
 	printf 'Stopping %s: ' "$DAEMON"
-	start-stop-daemon -K -q -p "$PIDFILE"
+	start-stop-daemon --stop --pidfile "$PIDFILE" --exec "/sbin/$DAEMON"
 	status=$?
 	if [ "$status" -eq 0 ]; then
-		rm -f "$PIDFILE"
 		echo "OK"
 	else
 		echo "FAIL"
+		return "$status"
 	fi
+	while start-stop-daemon --stop --test --quiet --pidfile "$PIDFILE" \
+		--exec "/sbin/$DAEMON"; do
+		sleep 0.1
+	done
+	rm -f "$PIDFILE"
 	return "$status"
 }
 
 restart() {
 	stop
-	sleep 1
 	start
 }
 
-- 
2.51.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: tidy up klogd init script

[Thomas Petazzoni via buildroot]

On Tue, 30 Dec 2025 15:51:17 +0100
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> * Wait for process to stop before deleting PID file, instead of fixed
>   wait during restart
> 
> * Use long form options
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
> Restarting klogd is probably not common, but it's nicer this way. :-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: tidy up klogd init script

[Arnout Vandecappelle via buildroot]

In reply of:
> * Wait for process to stop before deleting PID file, instead of fixed
>   wait during restart
> 
> * Use long form options
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
> Restarting klogd is probably not common, but it's nicer this way. :-)
> 
>  package/busybox/S02klogd | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/package/busybox/S02klogd b/package/busybox/S02klogd
> index 0677e1e5ca..f76d4e72d4 100644
> --- a/package/busybox/S02klogd
> +++ b/package/busybox/S02klogd
> @@ -13,7 +13,8 @@ KLOGD_ARGS=""
>  start() {
>  	printf 'Starting %s: ' "$DAEMON"
>  	# shellcheck disable=SC2086 # we need the word splitting
> -	start-stop-daemon -b -m -S -q -p "$PIDFILE" -x "/sbin/$DAEMON" \
> +	start-stop-daemon --start --background --make-pidfile \
> +		--pidfile "$PIDFILE" --exec "/sbin/$DAEMON" \
>  		-- -n $KLOGD_ARGS
>  	status=$?
>  	if [ "$status" -eq 0 ]; then
> @@ -26,20 +27,24 @@ start() {
>  
>  stop() {
>  	printf 'Stopping %s: ' "$DAEMON"
> -	start-stop-daemon -K -q -p "$PIDFILE"
> +	start-stop-daemon --stop --pidfile "$PIDFILE" --exec "/sbin/$DAEMON"
>  	status=$?
>  	if [ "$status" -eq 0 ]; then
> -		rm -f "$PIDFILE"
>  		echo "OK"
>  	else
>  		echo "FAIL"
> +		return "$status"
>  	fi
> +	while start-stop-daemon --stop --test --quiet --pidfile "$PIDFILE" \
> +		--exec "/sbin/$DAEMON"; do
> +		sleep 0.1
> +	done
> +	rm -f "$PIDFILE"
>  	return "$status"
>  }
>  
>  restart() {
>  	stop
> -	sleep 1
>  	start
>  }
>  
> -- 
> 2.51.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot