All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libdill: fix build with gcc-15.x
@ 2025-10-26 14:39 Bernd Kuhls
  2026-01-01 15:01 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2025-10-26 14:39 UTC (permalink / raw)
  To: buildroot; +Cc: Angelo Compagnucci

Updated project URL: https://github.com/sustrik/libdill/pull/228

Adding -std=gnu17 was recommended in upstream PR:
https://github.com/sustrik/libdill/issues/229#issuecomment-2865524080

Fixes:
https://autobuild.buildroot.net/results/1a5/1a5e9d7df6c83a921cae39b4dc4b601be4d18e36/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/libdill/Config.in  | 2 +-
 package/libdill/libdill.mk | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/libdill/Config.in b/package/libdill/Config.in
index 2376fc9698..ec649c6600 100644
--- a/package/libdill/Config.in
+++ b/package/libdill/Config.in
@@ -4,4 +4,4 @@ config BR2_PACKAGE_LIBDILL
 	  Libdill is a C library that makes writing structured
 	  concurrent programs easy.
 
-	  http://libdill.org
+	  https://sustrik.github.io/libdill/
diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
index 9dda81d085..e68ee819ec 100644
--- a/package/libdill/libdill.mk
+++ b/package/libdill/libdill.mk
@@ -12,6 +12,13 @@ LIBDILL_INSTALL_STAGING = YES
 # Fetched from Github, with no configure script
 LIBDILL_AUTORECONF = YES
 
+# gcc-15 defaults to -std=gnu23 which introduces build failures.
+# We force "-std=gnu17" for gcc version supporting it. Earlier gcc
+# versions will work, since they are using the older standard.
+ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_8),y)
+LIBDILL_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=gnu17"
+endif
+
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 LIBDILL_CONF_OPTS += --enable-threads
 else
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libdill: fix build with gcc-15.x
  2025-10-26 14:39 [Buildroot] [PATCH 1/1] package/libdill: fix build with gcc-15.x Bernd Kuhls
@ 2026-01-01 15:01 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-01-01 15:01 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Angelo Compagnucci

Hello Bernd,

On Sun, 26 Oct 2025 15:39:16 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Updated project URL: https://github.com/sustrik/libdill/pull/228

This should have been a separate commit.

> Adding -std=gnu17 was recommended in upstream PR:
> https://github.com/sustrik/libdill/issues/229#issuecomment-2865524080
> 
> Fixes:
> https://autobuild.buildroot.net/results/1a5/1a5e9d7df6c83a921cae39b4dc4b601be4d18e36/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

I wanted to test your patch, but libdill doesn't build for me, even
before the gcc 15.x issue, I get an issue during autoreconf:

configure.ac:59: warning: The macro 'AC_PROG_CC_C99' is obsolete.
configure.ac:59: You should run autoupdate.
./lib/autoconf/c.m4:1662: AC_PROG_CC_C99 is expanded from...
configure.ac:59: the top level
configure.ac:210: warning: AC_OUTPUT should be used without arguments.
configure.ac:210: You should run autoupdate.
configure.ac:119: error: possibly undefined macro: AC_CHECK_LIB
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:127: error: possibly undefined macro: AC_MSG_ERROR
autoreconf: error: /home/thomas/projets/buildroot/output-dill/host/bin/autoconf failed with exit status: 1
make: *** [package/pkg-generic.mk:262: /home/thomas/projets/buildroot/output-dill/build/libdill-32d0e8b733416208e0412a56490332772bc5c6e1/.stamp_configured] Error 1
make: Leaving directory '/home/thomas/projets/buildroot'

I would suggest to drop the package. Last tag in February 2019, last
commit in Aug 2022 (and it was following a patch submitted by Fabrice
Fontaine), and before that previous commit in 2021. Lots of issues
opened.

So I think dropping the package is the right thing to do. Do you want
to send such a patch?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-01 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-26 14:39 [Buildroot] [PATCH 1/1] package/libdill: fix build with gcc-15.x Bernd Kuhls
2026-01-01 15:01 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.