[Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters

[Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters

[Florian Fainelli]

Update 0005-Correct-loop-function-signature.patch to include a named
parameter otherwise the following compiler warning turned error is
triggered:

busy.c:6:1: error: parameter name omitted
 void *loop(void *)
 ^~~~

Fixes: https://autobuild.buildroot.org/results/8592e4eb5959124acc885a1cbc2f9d24fb7bcbd1
Fixes: https://autobuild.buildroot.org/results/cf12d080ddd7a2398a79be430d935071ca3250a3/
Fixes: e63181bc0056 ("package/cpulimit: Backport fix for function signature")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 package/cpulimit/0005-Correct-loop-function-signature.patch | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/cpulimit/0005-Correct-loop-function-signature.patch b/package/cpulimit/0005-Correct-loop-function-signature.patch
index 5b7f4a01dd5e..5b44ab9782c2 100644
--- a/package/cpulimit/0005-Correct-loop-function-signature.patch
+++ b/package/cpulimit/0005-Correct-loop-function-signature.patch
@@ -1,4 +1,4 @@
-From 74e95c96e8d82e4e374f86142972fcf4305fe1f2 Mon Sep 17 00:00:00 2001
+From e94b6dd7b3ca884f72f02879fd85792a3aee961d Mon Sep 17 00:00:00 2001
 From: Florian Fainelli <f.fainelli@gmail.com>
 Date: Wed, 2 Jul 2025 20:47:58 -0700
 Subject: [PATCH] Correct loop function signature
@@ -23,7 +23,7 @@ Upstream: https://github.com/opsengine/cpulimit/pull/127
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/tests/busy.c b/tests/busy.c
-index b3afb7cd853b..93f0bcce67a8 100644
+index b3afb7cd853b..8acbcd82e04f 100644
 --- a/tests/busy.c
 +++ b/tests/busy.c
 @@ -3,7 +3,7 @@
@@ -31,7 +31,7 @@ index b3afb7cd853b..93f0bcce67a8 100644
  #include <unistd.h>
  
 -void *loop()
-+void *loop(void *)
++void *loop(void *unused)
  {
  	while(1);
  }
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters

[Thomas Petazzoni via buildroot]

Hello Florian,

Happy New Year and best wishes for 2026! :-)

On Fri, 17 Oct 2025 10:16:08 -0700
Florian Fainelli <f.fainelli@gmail.com> wrote:

> Update 0005-Correct-loop-function-signature.patch to include a named
> parameter otherwise the following compiler warning turned error is
> triggered:
> 
> busy.c:6:1: error: parameter name omitted
>  void *loop(void *)
>  ^~~~
> 
> Fixes: https://autobuild.buildroot.org/results/8592e4eb5959124acc885a1cbc2f9d24fb7bcbd1
> Fixes: https://autobuild.buildroot.org/results/cf12d080ddd7a2398a79be430d935071ca3250a3/
> Fixes: e63181bc0056 ("package/cpulimit: Backport fix for function signature")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  package/cpulimit/0005-Correct-loop-function-signature.patch | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master after extending the commit log to explain a bit which
configurations are affected. Oddly enough recent compilers are happy,
but older GCC versions <= 10.x are not happy with the unnamed parameter.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters

[Arnout Vandecappelle via buildroot]

In reply of:
> Update 0005-Correct-loop-function-signature.patch to include a named
> parameter otherwise the following compiler warning turned error is
> triggered:
> 
> busy.c:6:1: error: parameter name omitted
>  void *loop(void *)
>  ^~~~
> 
> Fixes: https://autobuild.buildroot.org/results/8592e4eb5959124acc885a1cbc2f9d24fb7bcbd1
> Fixes: https://autobuild.buildroot.org/results/cf12d080ddd7a2398a79be430d935071ca3250a3/
> Fixes: e63181bc0056 ("package/cpulimit: Backport fix for function signature")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
>  package/cpulimit/0005-Correct-loop-function-signature.patch | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/cpulimit/0005-Correct-loop-function-signature.patch b/package/cpulimit/0005-Correct-loop-function-signature.patch
> index 5b7f4a01dd5e..5b44ab9782c2 100644
> --- a/package/cpulimit/0005-Correct-loop-function-signature.patch
> +++ b/package/cpulimit/0005-Correct-loop-function-signature.patch
> @@ -1,4 +1,4 @@
> -From 74e95c96e8d82e4e374f86142972fcf4305fe1f2 Mon Sep 17 00:00:00 2001
> +From e94b6dd7b3ca884f72f02879fd85792a3aee961d Mon Sep 17 00:00:00 2001
>  From: Florian Fainelli <f.fainelli@gmail.com>
>  Date: Wed, 2 Jul 2025 20:47:58 -0700
>  Subject: [PATCH] Correct loop function signature
> @@ -23,7 +23,7 @@ Upstream: https://github.com/opsengine/cpulimit/pull/127
>   1 file changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/tests/busy.c b/tests/busy.c
> -index b3afb7cd853b..93f0bcce67a8 100644
> +index b3afb7cd853b..8acbcd82e04f 100644
>  --- a/tests/busy.c
>  +++ b/tests/busy.c
>  @@ -3,7 +3,7 @@
> @@ -31,7 +31,7 @@ index b3afb7cd853b..93f0bcce67a8 100644
>   #include <unistd.h>
>   
>  -void *loop()
> -+void *loop(void *)
> ++void *loop(void *unused)
>   {
>   	while(1);
>   }
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot