All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan
@ 2025-09-09 14:47 Dario Binacchi
  2026-01-02 15:44 ` Thomas Petazzoni via buildroot
  2026-01-13 19:45 ` Arnout Vandecappelle via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Dario Binacchi @ 2025-09-09 14:47 UTC (permalink / raw)
  To: buildroot
  Cc: Jesse Van Gavere, Roy Kollen Svendsen, Thomas Petazzoni,
	linux-amarula, Dario Binacchi

The Vulkan option was appended to QT6BASE_CONFIGURE_OPTS instead of
QT6BASE_CONF_OPTS, which is the variable actually used during CMake
configuration. This prevented the feature from being enabled/disabled
as expected.

Fixes: 1c27f3a12d77b ("package/qt6base: add vulkan option")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/qt6/qt6base/qt6base.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
index 51a4f1b5be7f..3bf4a1221b43 100644
--- a/package/qt6/qt6base/qt6base.mk
+++ b/package/qt6/qt6base/qt6base.mk
@@ -183,9 +183,9 @@ QT6BASE_DEPENDENCIES += freetype
 
 ifeq ($(BR2_PACKAGE_QT6BASE_VULKAN),y)
 QT6BASE_DEPENDENCIES   += vulkan-headers vulkan-loader
-QT6BASE_CONFIGURE_OPTS += -DFEATURE_vulkan=ON
+QT6BASE_CONF_OPTS += -DFEATURE_vulkan=ON
 else
-QT6BASE_CONFIGURE_OPTS += -DFEATURE_vulkan=OFF
+QT6BASE_CONF_OPTS += -DFEATURE_vulkan=OFF
 endif
 
 ifeq ($(BR2_PACKAGE_QT6BASE_LINUXFB),y)
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan
  2025-09-09 14:47 [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan Dario Binacchi
@ 2026-01-02 15:44 ` Thomas Petazzoni via buildroot
  2026-01-13 19:45 ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-01-02 15:44 UTC (permalink / raw)
  To: Dario Binacchi
  Cc: buildroot, Jesse Van Gavere, Roy Kollen Svendsen, linux-amarula

On Tue,  9 Sep 2025 16:47:13 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> The Vulkan option was appended to QT6BASE_CONFIGURE_OPTS instead of
> QT6BASE_CONF_OPTS, which is the variable actually used during CMake
> configuration. This prevented the feature from being enabled/disabled
> as expected.
> 
> Fixes: 1c27f3a12d77b ("package/qt6base: add vulkan option")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  package/qt6/qt6base/qt6base.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan
  2025-09-09 14:47 [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan Dario Binacchi
  2026-01-02 15:44 ` Thomas Petazzoni via buildroot
@ 2026-01-13 19:45 ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2026-01-13 19:45 UTC (permalink / raw)
  To: Dario Binacchi; +Cc: Arnout Vandecappelle, buildroot

In reply of:
> The Vulkan option was appended to QT6BASE_CONFIGURE_OPTS instead of
> QT6BASE_CONF_OPTS, which is the variable actually used during CMake
> configuration. This prevented the feature from being enabled/disabled
> as expected.
> 
> Fixes: 1c27f3a12d77b ("package/qt6base: add vulkan option")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Applied to 2025.02.x and 2025.11.x. Thanks

> ---
>  package/qt6/qt6base/qt6base.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
> index 51a4f1b5be7f..3bf4a1221b43 100644
> --- a/package/qt6/qt6base/qt6base.mk
> +++ b/package/qt6/qt6base/qt6base.mk
> @@ -183,9 +183,9 @@ QT6BASE_DEPENDENCIES += freetype
>  
>  ifeq ($(BR2_PACKAGE_QT6BASE_VULKAN),y)
>  QT6BASE_DEPENDENCIES   += vulkan-headers vulkan-loader
> -QT6BASE_CONFIGURE_OPTS += -DFEATURE_vulkan=ON
> +QT6BASE_CONF_OPTS += -DFEATURE_vulkan=ON
>  else
> -QT6BASE_CONFIGURE_OPTS += -DFEATURE_vulkan=OFF
> +QT6BASE_CONF_OPTS += -DFEATURE_vulkan=OFF
>  endif
>  
>  ifeq ($(BR2_PACKAGE_QT6BASE_LINUXFB),y)
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-13 19:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 14:47 [Buildroot] [PATCH 1/1] package/qt6/qt6base: use QT6BASE_CONF_OPTS for Vulkan Dario Binacchi
2026-01-02 15:44 ` Thomas Petazzoni via buildroot
2026-01-13 19:45 ` Arnout Vandecappelle via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.