[PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Shankari Anand]

Resending the v2 patch series with changes suggested as in the 
v1 patch series [1].
Also re-worded the commit titles to refer to the target subsystem.

Have resent only the patches that haven't been picked up yet in the series.

Thanks and regards,
Shankari

[1] https://lore.kernel.org/all/20251123092438.182251-1-shankari.ak0208@gmail.com/

Shankari Anand (4):
  drivers: android: binder: Update ARef imports from sync::aref
  rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref
  rust: usb: Update AlwaysRefCounted imports to use sync::aref
  rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

 drivers/android/binder/process.rs      | 2 +-
 drivers/android/binder/thread.rs       | 3 +--
 rust/kernel/i2c.rs                     | 10 ++++------
 rust/kernel/types.rs                   | 2 --
 rust/kernel/usb.rs                     | 3 ++-
 5 files changed, 8 insertions(+), 12 deletions(-)

-- 
2.34.1

[PATCH v2 1/4] drivers: android: binder: Update ARef imports from sync::aref

[Shankari Anand]

Update call sites in binder files to import `ARef`
from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
Acked-by: Alice Ryhl <aliceryhl@google.com>
---
No change from v1 -> v2. Carry-forwarded the acked-by.

Link of v1: https://lore.kernel.org/all/20251123092438.182251-2-shankari.ak0208@gmail.com/

---
 drivers/android/binder/process.rs | 2 +-
 drivers/android/binder/thread.rs  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
index 132055b4790f..db25307b5a4a 100644
--- a/drivers/android/binder/process.rs
+++ b/drivers/android/binder/process.rs
@@ -28,11 +28,11 @@
     seq_print,
     sync::poll::PollTable,
     sync::{
+        aref::ARef,
         lock::{spinlock::SpinLockBackend, Guard},
         Arc, ArcBorrow, CondVar, CondVarTimeoutResult, Mutex, SpinLock, UniqueArc,
     },
     task::Task,
-    types::ARef,
     uaccess::{UserSlice, UserSliceReader},
     uapi,
     workqueue::{self, Work},
diff --git a/drivers/android/binder/thread.rs b/drivers/android/binder/thread.rs
index 1a8e6fdc0dc4..6a5c90547844 100644
--- a/drivers/android/binder/thread.rs
+++ b/drivers/android/binder/thread.rs
@@ -16,9 +16,8 @@
     seq_file::SeqFile,
     seq_print,
     sync::poll::{PollCondVar, PollTable},
-    sync::{Arc, SpinLock},
+    sync::{aref::ARef, Arc, SpinLock},
     task::Task,
-    types::ARef,
     uaccess::UserSlice,
     uapi,
 };
-- 
2.34.1

Re: [PATCH v2 1/4] drivers: android: binder: Update ARef imports from sync::aref

[Shankari Anand]

On Sat, Jan 03, 2026 at 01:57:11AM +0530, Shankari Anand wrote:
> Update call sites in binder files to import `ARef`
> from `sync::aref` instead of `types`.
> 
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
> 
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> Acked-by: Alice Ryhl <aliceryhl@google.com>
> ---
> No change from v1 -> v2. Carry-forwarded the acked-by.
> 
> Link of v1: https://lore.kernel.org/all/20251123092438.182251-2-shankari.ak0208@gmail.com/
> 
> ---
>  drivers/android/binder/process.rs | 2 +-
>  drivers/android/binder/thread.rs  | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> index 132055b4790f..db25307b5a4a 100644
> --- a/drivers/android/binder/process.rs
> +++ b/drivers/android/binder/process.rs
> @@ -28,11 +28,11 @@
>      seq_print,
>      sync::poll::PollTable,
>      sync::{
> +        aref::ARef,
>          lock::{spinlock::SpinLockBackend, Guard},
>          Arc, ArcBorrow, CondVar, CondVarTimeoutResult, Mutex, SpinLock, UniqueArc,
>      },
>      task::Task,
> -    types::ARef,
>      uaccess::{UserSlice, UserSliceReader},
>      uapi,
>      workqueue::{self, Work},
> diff --git a/drivers/android/binder/thread.rs b/drivers/android/binder/thread.rs
> index 1a8e6fdc0dc4..6a5c90547844 100644
> --- a/drivers/android/binder/thread.rs
> +++ b/drivers/android/binder/thread.rs
> @@ -16,9 +16,8 @@
>      seq_file::SeqFile,
>      seq_print,
>      sync::poll::{PollCondVar, PollTable},
> -    sync::{Arc, SpinLock},
> +    sync::{aref::ARef, Arc, SpinLock},
>      task::Task,
> -    types::ARef,
>      uaccess::UserSlice,
>      uapi,
>  };
> -- 
> 2.34.1
> 

Hello,
Can this patch be picked up?

Thanks and regards,
Shankari

Re: [PATCH v2 1/4] drivers: android: binder: Update ARef imports from sync::aref

[Greg Kroah-Hartman]

On Sat, Jan 31, 2026 at 05:05:23PM +0530, Shankari Anand wrote:
> On Sat, Jan 03, 2026 at 01:57:11AM +0530, Shankari Anand wrote:
> > Update call sites in binder files to import `ARef`
> > from `sync::aref` instead of `types`.
> > 
> > This aligns with the ongoing effort to move `ARef` and
> > `AlwaysRefCounted` to sync.
> > 
> > Suggested-by: Benno Lossin <lossin@kernel.org>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1173
> > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> > Acked-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > No change from v1 -> v2. Carry-forwarded the acked-by.
> > 
> > Link of v1: https://lore.kernel.org/all/20251123092438.182251-2-shankari.ak0208@gmail.com/
> > 
> > ---
> >  drivers/android/binder/process.rs | 2 +-
> >  drivers/android/binder/thread.rs  | 3 +--
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
> > index 132055b4790f..db25307b5a4a 100644
> > --- a/drivers/android/binder/process.rs
> > +++ b/drivers/android/binder/process.rs
> > @@ -28,11 +28,11 @@
> >      seq_print,
> >      sync::poll::PollTable,
> >      sync::{
> > +        aref::ARef,
> >          lock::{spinlock::SpinLockBackend, Guard},
> >          Arc, ArcBorrow, CondVar, CondVarTimeoutResult, Mutex, SpinLock, UniqueArc,
> >      },
> >      task::Task,
> > -    types::ARef,
> >      uaccess::{UserSlice, UserSliceReader},
> >      uapi,
> >      workqueue::{self, Work},
> > diff --git a/drivers/android/binder/thread.rs b/drivers/android/binder/thread.rs
> > index 1a8e6fdc0dc4..6a5c90547844 100644
> > --- a/drivers/android/binder/thread.rs
> > +++ b/drivers/android/binder/thread.rs
> > @@ -16,9 +16,8 @@
> >      seq_file::SeqFile,
> >      seq_print,
> >      sync::poll::{PollCondVar, PollTable},
> > -    sync::{Arc, SpinLock},
> > +    sync::{aref::ARef, Arc, SpinLock},
> >      task::Task,
> > -    types::ARef,
> >      uaccess::UserSlice,
> >      uapi,
> >  };
> > -- 
> > 2.34.1
> > 
> 
> Hello,
> Can this patch be picked up?

Sorry, trying to pick patches out of the middle of a series is "hard",
next time you do this, please do not make a series if you wish for
different maintainers to be taking them.

I'll go take this now, thanks.

greg k-h

[PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Shankari Anand]

Update call sites in `i2c.rs` to import `ARef` and
`AlwaysRefCounted` from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>
---
v1 -> v2:

Used the direct module name instead of including the path again,
re-worded the commit title to rust: i2c: and
carry-forwarded the Acked-by tag.

Link of v1: https://lore.kernel.org/all/20251123092438.182251-6-shankari.ak0208@gmail.com/

---
 rust/kernel/i2c.rs | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/rust/kernel/i2c.rs b/rust/kernel/i2c.rs
index 491e6cc25cf4..9f5f18792916 100644
--- a/rust/kernel/i2c.rs
+++ b/rust/kernel/i2c.rs
@@ -16,10 +16,8 @@
     error::*,
     of,
     prelude::*,
-    types::{
-        AlwaysRefCounted,
-        Opaque, //
-    }, //
+    sync::aref::AlwaysRefCounted,
+    types::Opaque, //
 };
 
 use core::{
@@ -31,7 +29,7 @@
     }, //
 };
 
-use kernel::types::ARef;
+use kernel::sync::aref::ARef;
 
 /// An I2C device id table.
 #[repr(transparent)]
@@ -407,7 +405,7 @@ pub fn get(index: i32) -> Result<ARef<Self>> {
 kernel::impl_device_context_into_aref!(I2cAdapter);
 
 // SAFETY: Instances of `I2cAdapter` are always reference-counted.
-unsafe impl crate::types::AlwaysRefCounted for I2cAdapter {
+unsafe impl AlwaysRefCounted for I2cAdapter {
     fn inc_ref(&self) {
         // SAFETY: The existence of a shared reference guarantees that the refcount is non-zero.
         unsafe { bindings::i2c_get_adapter(self.index()) };

-- 
2.34.1

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Igor Korotin]

On 1/2/2026 8:27 PM, Shankari Anand wrote:
> Update call sites in `i2c.rs` to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
> 
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
> 
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>
> ---
> v1 -> v2:
> 
> Used the direct module name instead of including the path again,
> re-worded the commit title to rust: i2c: and
> carry-forwarded the Acked-by tag.
> 
> Link of v1: https://lore.kernel.org/all/20251123092438.182251-6-shankari.ak0208@gmail.com/
> 
> ---
>   rust/kernel/i2c.rs | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/rust/kernel/i2c.rs b/rust/kernel/i2c.rs
> index 491e6cc25cf4..9f5f18792916 100644
> --- a/rust/kernel/i2c.rs
> +++ b/rust/kernel/i2c.rs
> @@ -16,10 +16,8 @@
>       error::*,
>       of,
>       prelude::*,
> -    types::{
> -        AlwaysRefCounted,
> -        Opaque, //
> -    }, //
> +    sync::aref::AlwaysRefCounted,
> +    types::Opaque, //
>   };
>   
>   use core::{
> @@ -31,7 +29,7 @@
>       }, //
>   };
>   
> -use kernel::types::ARef;
> +use kernel::sync::aref::ARef;
>   
>   /// An I2C device id table.
>   #[repr(transparent)]
> @@ -407,7 +405,7 @@ pub fn get(index: i32) -> Result<ARef<Self>> {
>   kernel::impl_device_context_into_aref!(I2cAdapter);
>   
>   // SAFETY: Instances of `I2cAdapter` are always reference-counted.
> -unsafe impl crate::types::AlwaysRefCounted for I2cAdapter {
> +unsafe impl AlwaysRefCounted for I2cAdapter {
>       fn inc_ref(&self) {
>           // SAFETY: The existence of a shared reference guarantees that the refcount is non-zero.
>           unsafe { bindings::i2c_get_adapter(self.index()) };
> 

Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>

Since I still don’t yet have a public kernel tree, I’d appreciate it if 
someone could pick this up through their tree.

Thanks
Igor

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Danilo Krummrich]

(Cc: Wolfram)

On Sat Jan 3, 2026 at 7:45 PM CET, Igor Korotin wrote:
> Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>
>
> Since I still don’t yet have a public kernel tree, I’d appreciate it if 
> someone could pick this up through their tree.

Since I've taken the initial I2C code through the driver-core tree I can pick
those patches up as well.

However, maybe it's something for Wolfram to just take through his tree?

Please let me know what you prefer.

- Danilo

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Igor Korotin]

Hello Danilo

On 1/3/2026 8:18 PM, Danilo Krummrich wrote:
> (Cc: Wolfram)
> 
> On Sat Jan 3, 2026 at 7:45 PM CET, Igor Korotin wrote:
>> Acked-by: Igor Korotin <igor.korotin.linux@gmail.com>
>>
>> Since I still don’t yet have a public kernel tree, I’d appreciate it if
>> someone could pick this up through their tree.
> 
> Since I've taken the initial I2C code through the driver-core tree I can pick
> those patches up as well.
> 
> However, maybe it's something for Wolfram to just take through his tree?

I see this change more as a Rust infrastructure change rather than 
something I2C-specific.

If it is not a burden for you, I would appreciate it if you could take 
it through your tree.

Thanks,
Igor

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Miguel Ojeda]

On Sun, Jan 4, 2026 at 12:31 AM Igor Korotin
<igor.korotin.linux@gmail.com> wrote:
>
> I see this change more as a Rust infrastructure change rather than
> something I2C-specific.
>
> If it is not a burden for you, I would appreciate it if you could take
> it through your tree.

This could even go through the Rust tree since it is a general
cleanup, but I imagine Danilo wanted to see what Wolfram thinks first,
since it is the "parent" subsystem.

I.e. in general, even for cleanup patches like this the subsystems
decide (e.g. others in this series went through their subsystems) and
generally pick the patches unless there is a practical reason not to.

Cheers,
Miguel

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Danilo Krummrich]

On Sun Jan 4, 2026 at 12:58 PM CET, Miguel Ojeda wrote:
> On Sun, Jan 4, 2026 at 12:31 AM Igor Korotin
> <igor.korotin.linux@gmail.com> wrote:
>>
>> I see this change more as a Rust infrastructure change rather than
>> something I2C-specific.
>>
>> If it is not a burden for you, I would appreciate it if you could take
>> it through your tree.
>
> This could even go through the Rust tree since it is a general
> cleanup, but I imagine Danilo wanted to see what Wolfram thinks first,
> since it is the "parent" subsystem.

Yes, that was the intention. I think it is a good thing if the C and Rust parts
of subsystems are handled closely. I think making even trivial patches flow
through the corresponding trees can help with that. :)

Re: [PATCH v2 2/4] rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref

[Miguel Ojeda]

On Sun, Jan 4, 2026 at 1:09 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> Yes, that was the intention. I think it is a good thing if the C and Rust parts
> of subsystems are handled closely. I think making even trivial patches flow
> through the corresponding trees can help with that. :)

Indeed!

It makes things easier and is meant to be the default modulo
exceptional cases (most subsystems already handle patches like this,
which is great).

Cheers,
Miguel

[PATCH v2 3/4] rust: usb: Update AlwaysRefCounted imports to use sync::aref

[Shankari Anand]

Update call sites in `usb.rs` to import `AlwaysRefCounted`
from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
v1 -> v2:

Re-worded the commit title to rust: usb:

Link of v1: https://lore.kernel.org/all/20251123092438.182251-9-shankari.ak0208@gmail.com/

---
 rust/kernel/usb.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rust/kernel/usb.rs b/rust/kernel/usb.rs
index d10b65e9fb6a..79ff2f881572 100644
--- a/rust/kernel/usb.rs
+++ b/rust/kernel/usb.rs
@@ -12,7 +12,8 @@
     error::{from_result, to_result, Result},
     prelude::*,
     str::CStr,
-    types::{AlwaysRefCounted, Opaque},
+    sync::aref::AlwaysRefCounted,
+    types::Opaque,
     ThisModule,
 };
 use core::{
-- 
2.34.1

Re: [PATCH v2 3/4] rust: usb: Update AlwaysRefCounted imports to use sync::aref

[Shankari Anand]

On Sat, Jan 03, 2026 at 01:57:13AM +0530, Shankari Anand wrote:
> Update call sites in `usb.rs` to import `AlwaysRefCounted`
> from `sync::aref` instead of `types`.
> 
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
> 
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
> v1 -> v2:
> 
> Re-worded the commit title to rust: usb:
> 
> Link of v1: https://lore.kernel.org/all/20251123092438.182251-9-shankari.ak0208@gmail.com/
> 
> ---
>  rust/kernel/usb.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/usb.rs b/rust/kernel/usb.rs
> index d10b65e9fb6a..79ff2f881572 100644
> --- a/rust/kernel/usb.rs
> +++ b/rust/kernel/usb.rs
> @@ -12,7 +12,8 @@
>      error::{from_result, to_result, Result},
>      prelude::*,
>      str::CStr,
> -    types::{AlwaysRefCounted, Opaque},
> +    sync::aref::AlwaysRefCounted,
> +    types::Opaque,
>      ThisModule,
>  };
>  use core::{
> -- 
> 2.34.1
> 

Hello,
Can this patch be picked up for review please?

Thanks and regards,
Shankari

[PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

Remove the temporary re-exports of `ARef` and `AlwaysRefCounted`
from `types.rs` now that all in-tree users have been updated to
import them directly from `sync::aref`.

These re-exports were originally added to avoid breaking the
kernel build during the transition period while call sites were
incrementally migrated. With all users updated, they are no
longer needed.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
v1 -> v2:

Re-worded the commit title to rust: types:

Link of v1: https://lore.kernel.org/all/20251123092438.182251-11-shankari.ak0208@gmail.com/

---
 rust/kernel/types.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
index 9c5e7dbf1632..4329d3c2c2e5 100644
--- a/rust/kernel/types.rs
+++ b/rust/kernel/types.rs
@@ -11,8 +11,6 @@
 };
 use pin_init::{PinInit, Wrapper, Zeroable};
 
-pub use crate::sync::aref::{ARef, AlwaysRefCounted};
-
 /// Used to transfer ownership to and from foreign (non-Rust) languages.
 ///
 /// Ownership is transferred from Rust to a foreign language by calling [`Self::into_foreign`] and
-- 
2.34.1

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[kernel test robot]

Hi Shankari,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on staging/staging-next staging/staging-linus rust/rust-next usb/usb-testing usb/usb-next usb/usb-linus next-20251219]
[cannot apply to linus/master v6.16-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/rust-i2c-Update-ARef-and-AlwaysRefCounted-imports-to-use-sync-aref/20260103-061451
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260102202714.184223-5-shankari.ak0208%40gmail.com
patch subject: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601030523.4eFrzaYI-lkp@intel.com/

All errors (new ones prefixed by >>):

>> error[E0432]: unresolved import `crate::types::ARef`
   --> rust/kernel/device/property.rs:17:13
   |
   17 |     types::{ARef, Opaque},
   |             ^^^^ no `ARef` in `types`
   |
   = help: consider importing this struct instead:
   crate::sync::aref::ARef
--
>> error[E0432]: unresolved import `crate::types::ARef`
   --> rust/kernel/scatterlist.rs:41:13
   |
   41 |     types::{ARef, Opaque},
   |             ^^^^ no `ARef` in `types`
   |
   = help: consider importing this struct instead:
   crate::sync::aref::ARef
--
>> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
   --> rust/kernel/device/property.rs:362:27
   |
   362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
   |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
   |
   help: consider importing this trait
   |
   7   + use crate::sync::aref::AlwaysRefCounted;
   |
   help: if you import `AlwaysRefCounted`, refer to it directly
   |
   362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
   362 + unsafe impl AlwaysRefCounted for FwNode {
   |

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Shankari Anand]

On Sat, Jan 03, 2026 at 01:57:10AM +0530, Shankari Anand wrote:
Hello Miguel,

> Resending the v2 patch series with changes suggested as in the 
> v1 patch series [1].
> Also re-worded the commit titles to refer to the target subsystem.
> 
> Have resent only the patches that haven't been picked up yet in the series.
> 
> Thanks and regards,
> Shankari
> 
> [1] https://lore.kernel.org/all/20251123092438.182251-1-shankari.ak0208@gmail.com/
> 
> Shankari Anand (4):
>   drivers: android: binder: Update ARef imports from sync::aref
>   rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref
>   rust: usb: Update AlwaysRefCounted imports to use sync::aref
>   rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
> 
>  drivers/android/binder/process.rs      | 2 +-
>  drivers/android/binder/thread.rs       | 3 +--
>  rust/kernel/i2c.rs                     | 10 ++++------
>  rust/kernel/types.rs                   | 2 --
>  rust/kernel/usb.rs                     | 3 ++-
>  5 files changed, 8 insertions(+), 12 deletions(-)
> 
> -- 
> 2.34.1
> 

Would it be possible for you to pickup the 2,3,4 patches of this series so as to
complete this cleanup in one go?
The first one has been picked up already [1].

Thanks and regards,
Shankari

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9caa30dada9e8ec9b1b09cf95e6d1a806c86d101

Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Miguel Ojeda]

On Sat, Mar 7, 2026 at 4:26 PM Shankari Anand <shankari.ak0208@gmail.com> wrote:
>
> Would it be possible for you to pickup the 2,3,4 patches of this series so as to
> complete this cleanup in one go?

It would be nice to get it done, yeah.

I think we were waiting for maintainers to individually pick them up,
or to get Acked-bys otherwise.

Greg, do you mind if I pick #3? (USB)

Thanks!

Cheers,
Miguel

Re: Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Shankari Anand]

On Sat, Mar 07, 2026 at 04:43:51PM +0100, Miguel Ojeda wrote:

> It would be nice to get it done, yeah.
> 
> I think we were waiting for maintainers to individually pick them up,
> or to get Acked-bys otherwise.

Yes, absolutely. The second one has been acked [1] which can probably be picked up.

> Cheers,
> Miguel

Regards,
Shankari

[1] https://lore.kernel.org/rust-for-linux/20260102202714.184223-3-shankari.ak0208@gmail.com/

Re: Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Miguel Ojeda]

On Wed, Mar 11, 2026 at 5:20 PM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Yes, absolutely. The second one has been acked [1] which can probably be picked up.

Yeah, it was, but for that one we were waiting to see if Wolfram
wanted to pick it up.

Anyway, I am picking the remaining ones to finally finish this.

Cheers,
Miguel

Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Miguel Ojeda]

On Fri, Jan 2, 2026 at 11:16 PM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
>   rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref
>   rust: usb: Update AlwaysRefCounted imports to use sync::aref
>   rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

Applied to `rust-next` -- thanks everyone!

    [ Move `ARef` import into the `kernel` `use` tree above. - Miguel ]

    [ Rebase. - Miguel ]

I don't see anything remaining in linux-next, and #1 was already in
v7.0-rc1, so I just applied all the rest, i.e. including the removal
of the temporary re-export. Let's see tomorrow if all goes well.

Thanks Shankari for your patience and keeping track of this!

With this, we are finally done with the move.

Greg, Wolfram: if you didn't want me to pick them up, please shout!

Cheers,
Miguel

Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]


> Greg, Wolfram: if you didn't want me to pick them up, please shout!

All good from my side, thank you for your work!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/4] rust: refactor ARef and AlwaysRefCounted imports

[Greg Kroah-Hartman]

On Sun, Mar 15, 2026 at 10:25:30PM +0100, Miguel Ojeda wrote:
> On Fri, Jan 2, 2026 at 11:16 PM Shankari Anand
> <shankari.ak0208@gmail.com> wrote:
> >
> >   rust: i2c: Update ARef and AlwaysRefCounted imports to use sync::aref
> >   rust: usb: Update AlwaysRefCounted imports to use sync::aref
> >   rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
> 
> Applied to `rust-next` -- thanks everyone!
> 
>     [ Move `ARef` import into the `kernel` `use` tree above. - Miguel ]
> 
>     [ Rebase. - Miguel ]
> 
> I don't see anything remaining in linux-next, and #1 was already in
> v7.0-rc1, so I just applied all the rest, i.e. including the removal
> of the temporary re-export. Let's see tomorrow if all goes well.
> 
> Thanks Shankari for your patience and keeping track of this!
> 
> With this, we are finally done with the move.
> 
> Greg, Wolfram: if you didn't want me to pick them up, please shout!

No objection from me.

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Sat, Jan 03, 2026 at 05:28:31AM +0100, kernel test robot wrote:
> Hi Shankari,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on staging/staging-next staging/staging-linus rust/rust-next usb/usb-testing usb/usb-next usb/usb-linus next-20251219]
> [cannot apply to linus/master v6.16-rc1]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/rust-i2c-Update-ARef-and-AlwaysRefCounted-imports-to-use-sync-aref/20260103-061451
> base:   staging/staging-testing
> patch link:    https://lore.kernel.org/r/20260102202714.184223-5-shankari.ak0208%40gmail.com
> patch subject: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
> config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601030523.4eFrzaYI-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/device/property.rs:17:13
>    |
>    17 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --


Hello Miguel and all,

> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/scatterlist.rs:41:13
>    |
>    41 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --

This change has already been made in [1]. Probably it has showed up on the linux-next
recently which has caused the kernel bot to detect the error.


> >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
>    --> rust/kernel/device/property.rs:362:27
>    |
>    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
>    |
>    help: consider importing this trait
>    |
>    7   + use crate::sync::aref::AlwaysRefCounted;
>    |
>    help: if you import `AlwaysRefCounted`, refer to it directly
>    |
>    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    362 + unsafe impl AlwaysRefCounted for FwNode {
>    |
> 
> --

I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
or put up a separate patch and reference it there?
 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


Please let me know which one would be appropriate and accordingly I'll send the revised patch.
I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.

Thanks a lot!

Regards,
Shankari

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Wed, Jan 07, 2026 at 08:09:35PM +0530, Shankari Anand wrote:
> 
> 
> Hello Miguel and all,
> 
> > >> error[E0432]: unresolved import `crate::types::ARef`
> >    --> rust/kernel/scatterlist.rs:41:13
> >    |
> >    41 |     types::{ARef, Opaque},
> >    |             ^^^^ no `ARef` in `types`
> >    |
> >    = help: consider importing this struct instead:
> >    crate::sync::aref::ARef
> > --
> 
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
> 
> 
> > >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
> >    --> rust/kernel/device/property.rs:362:27
> >    |
> >    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
> >    |
> >    help: consider importing this trait
> >    |
> >    7   + use crate::sync::aref::AlwaysRefCounted;
> >    |
> >    help: if you import `AlwaysRefCounted`, refer to it directly
> >    |
> >    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
> >    362 + unsafe impl AlwaysRefCounted for FwNode {
> >    |
> > 
> > --
> 
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?
>  
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> 
> Please let me know which one would be appropriate and accordingly I'll send the revised patch.
> I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.
> 
> Thanks a lot!
> 
> Regards,
> Shankari


Apologies, I forgot to link [1]


[1] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2da67beda68776842fd0a26f2374e42a5e9b12c8

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Miguel Ojeda]

On Wed, Jan 7, 2026 at 5:37 PM Shankari Anand <shankari.ak0208@gmail.com> wrote:
>
> Hello Miguel and all,
>
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
>
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?

If you mean the `FwNode` one you quoted, then I see it in commit
2e2b4135d1cb ("rust: device: Update ARef and AlwaysRefCounted imports
from sync::aref") which is in -next, so that should be fine.

Thanks!

Cheers,
Miguel

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Danilo Krummrich]

On Wed Jan 7, 2026 at 3:39 PM CET, Shankari Anand wrote:
> Hello Miguel and all,
>
>> >> error[E0432]: unresolved import `crate::types::ARef`
>>    --> rust/kernel/scatterlist.rs:41:13
>>    |
>>    41 |     types::{ARef, Opaque},
>>    |             ^^^^ no `ARef` in `types`
>>    |
>>    = help: consider importing this struct instead:
>>    crate::sync::aref::ARef
>> --
>
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.

This is because the failing build was against the staging tree, which
(obviously) does not contain all the relevant patches to remove the temporary
re-export.

Now, I have no idea why the bot pulled this series to build it against the
staging tree though. But it should help to use --base when running git
format-patch.

Also, note that this patch can only be landed after all other patches went from
their corresponding subsystem trees into Linus' tree.

Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

[Shankari Anand]

On Wed, Jan 07, 2026 at 10:42:44PM +0100, Danilo Krummrich wrote:

>  
> This is because the failing build was against the staging tree, which
> (obviously) does not contain all the relevant patches to remove the temporary
> re-export.
> 
> Now, I have no idea why the bot pulled this series to build it against the
> staging tree though. But it should help to use --base when running git
> format-patch.
>

Ah, I see. I'll ensure to include the base commit henceforth!
 
> Also, note that this patch can only be landed after all other patches went from
> their corresponding subsystem trees into Linus' tree.

Yes, agreed. Hoping other patches get picked up soon so this clean up 
will be completed soon!

Thanks everyone,
Shankari