From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 11/14] f2fs: fix timeout precision of f2fs_io_schedule_timeout_killable()
Date: Sun, 4 Jan 2026 10:07:26 +0800 [thread overview]
Message-ID: <20260104020729.1064529-11-chao@kernel.org> (raw)
In-Reply-To: <20260104020729.1064529-1-chao@kernel.org>
Sometimes, f2fs_io_schedule_timeout_killable(HZ) may delay for about 2
seconds, this is because __f2fs_schedule_timeout(DEFAULT_SCHEDULE_TIMEOUT)
may delay for about 2 * DEFAULT_SCHEDULE_TIMEOUT due to its precision, but
we only account the delay as DEFAULT_SCHEDULE_TIMEOUT as below, fix it.
f2fs_io_schedule_timeout_killable()
..
timeout -= DEFAULT_SCHEDULE_TIMEOUT;
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/f2fs.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index c4d3b37821d6..54cde9a0e24c 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4985,13 +4985,12 @@ static inline void __f2fs_schedule_timeout(long timeout, bool io)
static inline void f2fs_io_schedule_timeout_killable(long timeout)
{
- while (timeout) {
+ unsigned long last_time = jiffies + timeout;
+
+ while (jiffies < last_time) {
if (fatal_signal_pending(current))
return;
__f2fs_schedule_timeout(DEFAULT_SCHEDULE_TIMEOUT, true);
- if (timeout <= DEFAULT_SCHEDULE_TIMEOUT)
- return;
- timeout -= DEFAULT_SCHEDULE_TIMEOUT;
}
}
--
2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH 11/14] f2fs: fix timeout precision of f2fs_io_schedule_timeout_killable()
Date: Sun, 4 Jan 2026 10:07:26 +0800 [thread overview]
Message-ID: <20260104020729.1064529-11-chao@kernel.org> (raw)
In-Reply-To: <20260104020729.1064529-1-chao@kernel.org>
Sometimes, f2fs_io_schedule_timeout_killable(HZ) may delay for about 2
seconds, this is because __f2fs_schedule_timeout(DEFAULT_SCHEDULE_TIMEOUT)
may delay for about 2 * DEFAULT_SCHEDULE_TIMEOUT due to its precision, but
we only account the delay as DEFAULT_SCHEDULE_TIMEOUT as below, fix it.
f2fs_io_schedule_timeout_killable()
..
timeout -= DEFAULT_SCHEDULE_TIMEOUT;
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/f2fs.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index c4d3b37821d6..54cde9a0e24c 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4985,13 +4985,12 @@ static inline void __f2fs_schedule_timeout(long timeout, bool io)
static inline void f2fs_io_schedule_timeout_killable(long timeout)
{
- while (timeout) {
+ unsigned long last_time = jiffies + timeout;
+
+ while (jiffies < last_time) {
if (fatal_signal_pending(current))
return;
__f2fs_schedule_timeout(DEFAULT_SCHEDULE_TIMEOUT, true);
- if (timeout <= DEFAULT_SCHEDULE_TIMEOUT)
- return;
- timeout -= DEFAULT_SCHEDULE_TIMEOUT;
}
}
--
2.49.0
next prev parent reply other threads:[~2026-01-04 2:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 2:07 [f2fs-dev] [PATCH 01/14] f2fs: add lock elapsed time trace facility for f2fs rwsemphore Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 02/14] f2fs: sysfs: introduce max_lock_elapsed_time Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 03/14] f2fs: trace elapsed time for cp_rwsem lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 04/14] f2fs: trace elapsed time for node_change lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 05/14] f2fs: trace elapsed time for node_write lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 06/14] f2fs: trace elapsed time for gc_lock lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 5:35 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-01-04 5:35 ` Jaegeuk Kim
2026-01-04 5:42 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-01-04 5:42 ` Jaegeuk Kim
2026-01-04 6:27 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-01-04 6:27 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 07/14] f2fs: trace elapsed time for cp_global_sem lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 08/14] f2fs: trace elapsed time for io_rwsem lock Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 09/14] f2fs: clean up w/ __f2fs_schedule_timeout() Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 10/14] f2fs: fix to use jiffies based precision for DEFAULT_SCHEDULE_TIMEOUT Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` Chao Yu via Linux-f2fs-devel [this message]
2026-01-04 2:07 ` [PATCH 11/14] f2fs: fix timeout precision of f2fs_io_schedule_timeout_killable() Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 12/14] f2fs: rename FAULT_TIMEOUT to FAULT_ATOMIC_TIMEOUT Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 13/14] f2fs: introduce FAULT_LOCK_TIMEOUT Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 2:07 ` [f2fs-dev] [PATCH 14/14] f2fs: sysfs: introduce inject_lock_timeout Chao Yu via Linux-f2fs-devel
2026-01-04 2:07 ` Chao Yu
2026-01-04 5:28 ` [f2fs-dev] [PATCH 01/14] f2fs: add lock elapsed time trace facility for f2fs rwsemphore Jaegeuk Kim via Linux-f2fs-devel
2026-01-04 5:28 ` Jaegeuk Kim
2026-01-07 3:30 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-01-07 3:30 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104020729.1064529-11-chao@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.