From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Abliyev, Reuven" <reuven.abliyev@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [char-misc] mei: trace: treat reg parameter as string
Date: Tue, 6 Jan 2026 15:46:48 +0100 [thread overview]
Message-ID: <2026010603-wing-widget-232e@gregkh> (raw)
In-Reply-To: <CY5PR11MB6366D9AF6D2BF29743346FF2ED87A@CY5PR11MB6366.namprd11.prod.outlook.com>
On Tue, Jan 06, 2026 at 10:59:26AM +0000, Usyskin, Alexander wrote:
> > Subject: Re: [char-misc] mei: trace: treat reg parameter as string
> >
> > On Sun, Jan 04, 2026 at 10:20:44AM +0200, Alexander Usyskin wrote:
> > > Process the reg string parameter in secure way.
> > >
> >
> > I'm sorry, but I don't understand this changelog text. What exactly is
> > this doing? Why is a string "better" than a char *?
> >
> > thanks,
> >
> > greg k-h
>
> Sorry, I'm bad in changelogs, trying to improve...
It is usually the hardest part of making a code change.
> The string wrapper checks sanity of parameters and prevents internal kernel data leaks.
> Newer kernels refuse to emit event with plain char*, without the wrapper.
> See https://elixir.bootlin.com/linux/v6.19-rc3/source/kernel/trace/trace.c#L3785
Great, please take this information and rewrite this to explain the need
here and what this change is doing.
thanks,
greg k-h
prev parent reply other threads:[~2026-01-06 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 8:20 [char-misc] mei: trace: treat reg parameter as string Alexander Usyskin
2026-01-06 10:17 ` Greg Kroah-Hartman
2026-01-06 10:59 ` Usyskin, Alexander
2026-01-06 14:46 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026010603-wing-widget-232e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reuven.abliyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.