From: Massimiliano Minella <massimiliano.minella@se.com>
To: meta-virtualization@lists.yoctoproject.org
Cc: Massimiliano Minella <massimiliano.minella@se.com>
Subject: [PATCH] libvirt: fix python3 compatibility in hook_support.py
Date: Wed, 07 Jan 2026 17:33:59 +0100 [thread overview]
Message-ID: <20260107-fix_libvirt_hook_script-v1-1-d0016e043ca4@se.com> (raw)
By default Popen expects all the streams to be bytes-like objects but,
in the Popen.communicate() function call, the "input" argument is a
string, making the call fail with the error:
qemu hook error: a bytes-like object is required, not 'str'
Fix the error by setting text mode to True in the subprocess creation.
Also fix the "SyntaxWarning: invalid escape sequence '\w'" in the regex
used to match script names.
Signed-off-by: Massimiliano Minella <massimiliano.minella@se.com>
---
recipes-extended/libvirt/libvirt/hook_support.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git recipes-extended/libvirt/libvirt/hook_support.py recipes-extended/libvirt/libvirt/hook_support.py
index 7c5e2a94..63e78b79 100755
--- recipes-extended/libvirt/libvirt/hook_support.py
+++ recipes-extended/libvirt/libvirt/hook_support.py
@@ -35,7 +35,7 @@ def main():
stdin_save = sys.stdin.readlines()
# Match the name name of the hook + a dash + atleast
# one alpha-numeric character.
- matcher = re.compile( "%s-\w+" % hook_name )
+ matcher = re.compile( rf"%s-\w+" % hook_name )
for file_name in sorted( os.listdir( hook_dir ) ):
file_path = os.path.join( hook_dir, file_name )
if matcher.match( file_name ) \
@@ -43,7 +43,7 @@ def main():
and os.path.isfile( file_path ) \
and return_value == 0:
cmd = [ file_path ] + hook_args
- p = subprocess.Popen( cmd, stdin=subprocess.PIPE )
+ p = subprocess.Popen( cmd, stdin=subprocess.PIPE, text=True )
p.communicate( input = ''.join( stdin_save ) )[0]
return_value = p.wait()
except Exception as e:
---
base-commit: 28d26fd95397bf575e65fcca0cbb302b1e9bc7ff
change-id: 20260107-fix_libvirt_hook_script-c31e952080e9
Best regards,
--
Massimiliano Minella <massimiliano.minella@se.com>
WARNING: multiple messages have this Message-ID (diff)
From: Massimiliano Minella via B4 Relay <devnull+massimiliano.minella.se.com@kernel.org>
To: meta-virtualization@lists.yoctoproject.org
Cc: Massimiliano Minella <massimiliano.minella@se.com>
Subject: [PATCH] libvirt: fix python3 compatibility in hook_support.py
Date: Wed, 07 Jan 2026 17:33:59 +0100 [thread overview]
Message-ID: <20260107-fix_libvirt_hook_script-v1-1-d0016e043ca4@se.com> (raw)
From: Massimiliano Minella <massimiliano.minella@se.com>
By default Popen expects all the streams to be bytes-like objects but,
in the Popen.communicate() function call, the "input" argument is a
string, making the call fail with the error:
qemu hook error: a bytes-like object is required, not 'str'
Fix the error by setting text mode to True in the subprocess creation.
Also fix the "SyntaxWarning: invalid escape sequence '\w'" in the regex
used to match script names.
Signed-off-by: Massimiliano Minella <massimiliano.minella@se.com>
---
recipes-extended/libvirt/libvirt/hook_support.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git recipes-extended/libvirt/libvirt/hook_support.py recipes-extended/libvirt/libvirt/hook_support.py
index 7c5e2a94..63e78b79 100755
--- recipes-extended/libvirt/libvirt/hook_support.py
+++ recipes-extended/libvirt/libvirt/hook_support.py
@@ -35,7 +35,7 @@ def main():
stdin_save = sys.stdin.readlines()
# Match the name name of the hook + a dash + atleast
# one alpha-numeric character.
- matcher = re.compile( "%s-\w+" % hook_name )
+ matcher = re.compile( rf"%s-\w+" % hook_name )
for file_name in sorted( os.listdir( hook_dir ) ):
file_path = os.path.join( hook_dir, file_name )
if matcher.match( file_name ) \
@@ -43,7 +43,7 @@ def main():
and os.path.isfile( file_path ) \
and return_value == 0:
cmd = [ file_path ] + hook_args
- p = subprocess.Popen( cmd, stdin=subprocess.PIPE )
+ p = subprocess.Popen( cmd, stdin=subprocess.PIPE, text=True )
p.communicate( input = ''.join( stdin_save ) )[0]
return_value = p.wait()
except Exception as e:
---
base-commit: 28d26fd95397bf575e65fcca0cbb302b1e9bc7ff
change-id: 20260107-fix_libvirt_hook_script-c31e952080e9
Best regards,
--
Massimiliano Minella <massimiliano.minella@se.com>
next reply other threads:[~2026-01-07 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 16:33 Massimiliano Minella [this message]
2026-01-07 16:33 ` [PATCH] libvirt: fix python3 compatibility in hook_support.py Massimiliano Minella via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107-fix_libvirt_hook_script-v1-1-d0016e043ca4@se.com \
--to=massimiliano.minella@se.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.