All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vishal Verma <vishal.l.verma@intel.com>
To: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
	 kvm@vger.kernel.org
Cc: x86@kernel.org, Chao Gao <chao.gao@intel.com>,
	 Dan Williams <dan.j.williams@intel.com>,
	Kai Huang <kai.huang@intel.com>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,  Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	 "H. Peter Anvin" <hpa@zytor.com>,
	Kiryl Shutsemau <kas@kernel.org>,
	 Rick Edgecombe <rick.p.edgecombe@intel.com>,
	 Vishal Verma <vishal.l.verma@intel.com>
Subject: [PATCH v2 2/2] x86/virt/tdx: Print TDX module version during init
Date: Fri, 09 Jan 2026 12:14:31 -0700	[thread overview]
Message-ID: <20260109-tdx_print_module_version-v2-2-e10e4ca5b450@intel.com> (raw)
In-Reply-To: <20260109-tdx_print_module_version-v2-0-e10e4ca5b450@intel.com>

It is useful to print the TDX module version in dmesg logs. This is
currently the only way to determine the module version from the host. It
also creates a record for any future problems being investigated. This
was also requested in [1].

Include the version in the log messages during init, e.g.:

  virt/tdx: TDX module version: 1.5.24
  virt/tdx: 1034220 KB allocated for PAMT
  virt/tdx: module initialized

Print the version in get_tdx_sys_info(), right after the version
metadata is read, which makes it available even if there are subsequent
initialization failures.

Based on a patch by Kai Huang <kai.huang@intel.com> [2]

Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Chao Gao <chao.gao@intel.com>
Cc: Chao Gao <chao.gao@intel.com>
Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>
Cc: Kai Huang <kai.huang@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/all/CAGtprH8eXwi-TcH2+-Fo5YdbEwGmgLBh9ggcDvd6N=bsKEJ_WQ@mail.gmail.com/ # [1]
Link: https://lore.kernel.org/all/6b5553756f56a8e3222bfc36d0bdb3e5192137b7.1731318868.git.kai.huang@intel.com # [2]
---
 arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
index 0454124803f3..4c9917a9c2c3 100644
--- a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
+++ b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
@@ -105,6 +105,12 @@ static int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
 	int ret = 0;
 
 	ret = ret ?: get_tdx_sys_info_version(&sysinfo->version);
+
+	pr_info("Module version: %u.%u.%02u\n",
+		sysinfo->version.major_version,
+		sysinfo->version.minor_version,
+		sysinfo->version.update_version);
+
 	ret = ret ?: get_tdx_sys_info_features(&sysinfo->features);
 	ret = ret ?: get_tdx_sys_info_tdmr(&sysinfo->tdmr);
 	ret = ret ?: get_tdx_sys_info_td_ctrl(&sysinfo->td_ctrl);

-- 
2.52.0


  parent reply	other threads:[~2026-01-09 19:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 19:14 [PATCH v2 0/2] x86/virt/tdx: Print TDX module version to dmesg Vishal Verma
2026-01-09 19:14 ` [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version Vishal Verma
2026-01-12  2:25   ` Xiaoyao Li
2026-01-12 14:56     ` Dave Hansen
2026-01-13  2:56       ` Xu Yilun
2026-01-13  3:58         ` Xiaoyao Li
2026-01-12  8:30   ` Binbin Wu
2026-01-19  8:12   ` Tony Lindgren
2026-02-25 22:51   ` [tip: x86/tdx] " tip-bot2 for Chao Gao
2026-01-09 19:14 ` Vishal Verma [this message]
2026-01-09 20:00   ` [PATCH v2 2/2] x86/virt/tdx: Print TDX module version during init Edgecombe, Rick P
2026-01-12  2:31   ` Xiaoyao Li
2026-01-12  8:32   ` Binbin Wu
2026-01-12 11:23   ` Kiryl Shutsemau
2026-01-19  8:12   ` Tony Lindgren
2026-02-25 22:51   ` [tip: x86/tdx] " tip-bot2 for Vishal Verma
2026-01-11 22:15 ` [PATCH v2 0/2] x86/virt/tdx: Print TDX module version to dmesg Huang, Kai
2026-02-05 19:05 ` Verma, Vishal L
2026-02-06 11:39   ` Kiryl Shutsemau
2026-02-06 15:10     ` Dave Hansen
2026-02-06 18:35       ` Edgecombe, Rick P
2026-02-09 10:46       ` Kiryl Shutsemau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260109-tdx_print_module_version-v2-2-e10e4ca5b450@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=bp@alien8.de \
    --cc=chao.gao@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kai.huang@intel.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.