From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>, Dave Hansen <dave.hansen@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
kvm@vger.kernel.org, x86@kernel.org,
Chao Gao <chao.gao@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Kai Huang <kai.huang@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Kiryl Shutsemau <kas@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>
Subject: Re: [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version
Date: Tue, 13 Jan 2026 11:58:39 +0800 [thread overview]
Message-ID: <e2f80e63-302a-47a0-b165-e7abe164a4be@intel.com> (raw)
In-Reply-To: <aWW0TZNdWdN/C6Yi@yilunxu-OptiPlex-7050>
On 1/13/2026 10:56 AM, Xu Yilun wrote:
> On Mon, Jan 12, 2026 at 06:56:58AM -0800, Dave Hansen wrote:
>> On 1/11/26 18:25, Xiaoyao Li wrote:
>>> ... I know it's because minor_version has the least field ID among the
>>> three. But the order of the field IDs doesn't stand for the order of the
>>> reading. Reading the middle part y of x.y.z as first step looks a bit odd.
>>
>> I wouldn't sweat it either way. Reading 4, 3, 5 would also look odd. I'm
>> fine with it as-is in the patch.
>
> I prefer 3, 4, 5. The field IDs are not human readable hex magic so
> should take extra care when copying from excel file to C file manually,
> A different list order would make the code adding & reviewing even
> harder.
I guess eventually we will introduce MACROs for these magic numbers to
make the code more readable given that the decision is no longer
auto-generate the code by the script? Though I'm not sure when that will
happen.
next prev parent reply other threads:[~2026-01-13 3:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 19:14 [PATCH v2 0/2] x86/virt/tdx: Print TDX module version to dmesg Vishal Verma
2026-01-09 19:14 ` [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version Vishal Verma
2026-01-12 2:25 ` Xiaoyao Li
2026-01-12 14:56 ` Dave Hansen
2026-01-13 2:56 ` Xu Yilun
2026-01-13 3:58 ` Xiaoyao Li [this message]
2026-01-12 8:30 ` Binbin Wu
2026-01-19 8:12 ` Tony Lindgren
2026-02-25 22:51 ` [tip: x86/tdx] " tip-bot2 for Chao Gao
2026-01-09 19:14 ` [PATCH v2 2/2] x86/virt/tdx: Print TDX module version during init Vishal Verma
2026-01-09 20:00 ` Edgecombe, Rick P
2026-01-12 2:31 ` Xiaoyao Li
2026-01-12 8:32 ` Binbin Wu
2026-01-12 11:23 ` Kiryl Shutsemau
2026-01-19 8:12 ` Tony Lindgren
2026-02-25 22:51 ` [tip: x86/tdx] " tip-bot2 for Vishal Verma
2026-01-11 22:15 ` [PATCH v2 0/2] x86/virt/tdx: Print TDX module version to dmesg Huang, Kai
2026-02-05 19:05 ` Verma, Vishal L
2026-02-06 11:39 ` Kiryl Shutsemau
2026-02-06 15:10 ` Dave Hansen
2026-02-06 18:35 ` Edgecombe, Rick P
2026-02-09 10:46 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f80e63-302a-47a0-b165-e7abe164a4be@intel.com \
--to=xiaoyao.li@intel.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kai.huang@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.