* [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
@ 2026-01-12 2:39 Hal Feng
2026-01-12 9:41 ` Quentin Schulz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Hal Feng @ 2026-01-12 2:39 UTC (permalink / raw)
To: Tom Rini, Leo, Peng Fan, Jaehoon Chung, Quentin Schulz,
oliver Fendt, Kuan Lim Lee, Wei Liang Lim
Cc: Hal Feng, u-boot
The license of the file is not valid. Fix it to GPL-2.0+.
Fixes: fe11aa0b8ca3 ("mmc: sdhci-cadence: Add support for Cadence sdmmc v6")
Reported-by: Quentin Schulz <quentin.schulz@cherry.de>
Reported-by: oliver Fendt <ofendt@googlemail.com>
Closes: https://lore.kernel.org/all/CAFoF8fC4foffYJgYm9CkViET83gDu05noVRxLxgs+KWXN_-LBQ@mail.gmail.com/
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
drivers/mmc/sdhci-cadence6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sdhci-cadence6.c b/drivers/mmc/sdhci-cadence6.c
index 91a245aa490..ca1086e2359 100644
--- a/drivers/mmc/sdhci-cadence6.c
+++ b/drivers/mmc/sdhci-cadence6.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-or-platform_driver
+// SPDX-License-Identifier: GPL-2.0+
/*
* Copyright (C) 2023 Starfive.
* Author: Kuan Lim Lee <kuanlim.lee@starfivetech.com>
base-commit: 1bcb2fe324180d0a8cfbdb0511737eba1d5b8550
--
2.43.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
2026-01-12 2:39 [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+ Hal Feng
@ 2026-01-12 9:41 ` Quentin Schulz
2026-01-12 10:10 ` Tanmay Kathpalia
2026-01-13 9:08 ` Peng Fan
2026-01-22 8:24 ` Peng Fan (OSS)
2 siblings, 1 reply; 5+ messages in thread
From: Quentin Schulz @ 2026-01-12 9:41 UTC (permalink / raw)
To: Hal Feng, Tom Rini, Leo, Peng Fan, Jaehoon Chung, oliver Fendt,
Kuan Lim Lee, Wei Liang Lim
Cc: u-boot, Tanmay Kathpalia
Hi Hal,
On 1/12/26 3:39 AM, Hal Feng wrote:
> The license of the file is not valid. Fix it to GPL-2.0+.
>
This matches the license used in the header file added in the same
commit (see Fixes trailer).
> Fixes: fe11aa0b8ca3 ("mmc: sdhci-cadence: Add support for Cadence sdmmc v6")
> Reported-by: Quentin Schulz <quentin.schulz@cherry.de>
> Reported-by: oliver Fendt <ofendt@googlemail.com>
> Closes: https://lore.kernel.org/all/CAFoF8fC4foffYJgYm9CkViET83gDu05noVRxLxgs+KWXN_-LBQ@mail.gmail.com/
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> drivers/mmc/sdhci-cadence6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/sdhci-cadence6.c b/drivers/mmc/sdhci-cadence6.c
> index 91a245aa490..ca1086e2359 100644
> --- a/drivers/mmc/sdhci-cadence6.c
> +++ b/drivers/mmc/sdhci-cadence6.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0-or-platform_driver
> +// SPDX-License-Identifier: GPL-2.0+
Would have preferred the canonical version (GPL-2.0-or-later) but that's
good enough here.
IANAL, so I don't know if we need approval from all contributors to the
file. Fortunately, there's only been one outside of the two starfivetech
contributors (whose mails bounce), so adding this contributor (Tanmay
Kathpalia) in Cc so they can just provide their Acked-by/Reviewed-by so
we don't have to find out.
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
2026-01-12 9:41 ` Quentin Schulz
@ 2026-01-12 10:10 ` Tanmay Kathpalia
0 siblings, 0 replies; 5+ messages in thread
From: Tanmay Kathpalia @ 2026-01-12 10:10 UTC (permalink / raw)
To: Quentin Schulz, Hal Feng, Tom Rini, Leo, Peng Fan, Jaehoon Chung,
oliver Fendt, Kuan Lim Lee, Wei Liang Lim
Cc: u-boot
Hi Quentin, Hal
Thank you for including me in the discussion.
On 1/12/2026 3:11 PM, Quentin Schulz wrote:
> Hi Hal,
>
> On 1/12/26 3:39 AM, Hal Feng wrote:
>> The license of the file is not valid. Fix it to GPL-2.0+.
>>
>
> This matches the license used in the header file added in the same
> commit (see Fixes trailer).
>
>> Fixes: fe11aa0b8ca3 ("mmc: sdhci-cadence: Add support for Cadence
>> sdmmc v6")
>> Reported-by: Quentin Schulz <quentin.schulz@cherry.de>
>> Reported-by: oliver Fendt <ofendt@googlemail.com>
>> Closes: https://lore.kernel.org/all/
>> CAFoF8fC4foffYJgYm9CkViET83gDu05noVRxLxgs+KWXN_-LBQ@mail.gmail.com/
>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>> drivers/mmc/sdhci-cadence6.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/sdhci-cadence6.c b/drivers/mmc/sdhci-cadence6.c
>> index 91a245aa490..ca1086e2359 100644
>> --- a/drivers/mmc/sdhci-cadence6.c
>> +++ b/drivers/mmc/sdhci-cadence6.c
>> @@ -1,4 +1,4 @@
>> -// SPDX-License-Identifier: GPL-2.0-or-platform_driver
>> +// SPDX-License-Identifier: GPL-2.0+
>
> Would have preferred the canonical version (GPL-2.0-or-later) but that's
> good enough here.
>
> IANAL, so I don't know if we need approval from all contributors to the
> file. Fortunately, there's only been one outside of the two starfivetech
> contributors (whose mails bounce), so adding this contributor (Tanmay
> Kathpalia) in Cc so they can just provide their Acked-by/Reviewed-by so
> we don't have to find out.
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Thanks!
> Quentin
Reviewed-by: Tanmay Kathpalia <tanmay.kathpalia@altera.com>
Regards,
Tanmay
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
2026-01-12 2:39 [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+ Hal Feng
2026-01-12 9:41 ` Quentin Schulz
@ 2026-01-13 9:08 ` Peng Fan
2026-01-22 8:24 ` Peng Fan (OSS)
2 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2026-01-13 9:08 UTC (permalink / raw)
To: Hal Feng
Cc: Tom Rini, Leo, Peng Fan, Jaehoon Chung, Quentin Schulz,
oliver Fendt, Kuan Lim Lee, Wei Liang Lim, u-boot
On Mon, Jan 12, 2026 at 10:39:47AM +0800, Hal Feng wrote:
>The license of the file is not valid. Fix it to GPL-2.0+.
>
>Fixes: fe11aa0b8ca3 ("mmc: sdhci-cadence: Add support for Cadence sdmmc v6")
>Reported-by: Quentin Schulz <quentin.schulz@cherry.de>
>Reported-by: oliver Fendt <ofendt@googlemail.com>
>Closes: https://lore.kernel.org/all/CAFoF8fC4foffYJgYm9CkViET83gDu05noVRxLxgs+KWXN_-LBQ@mail.gmail.com/
>Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
2026-01-12 2:39 [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+ Hal Feng
2026-01-12 9:41 ` Quentin Schulz
2026-01-13 9:08 ` Peng Fan
@ 2026-01-22 8:24 ` Peng Fan (OSS)
2 siblings, 0 replies; 5+ messages in thread
From: Peng Fan (OSS) @ 2026-01-22 8:24 UTC (permalink / raw)
To: u-boot, Tom Rini, Leo, Jaehoon Chung, Quentin Schulz,
oliver Fendt, Kuan Lim Lee, Wei Liang Lim, Hal Feng
Cc: Peng Fan
From: Peng Fan <peng.fan@nxp.com>
On Mon, 12 Jan 2026 10:39:47 +0800, Hal Feng wrote:
> The license of the file is not valid. Fix it to GPL-2.0+.
>
>
Applied, thanks!
[1/1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+
commit: 0e6ed6117552e6b0ba8675980ef9580fea2ae3ac
Best regards,
--
Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-22 7:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-12 2:39 [PATCH v1] mmc: sdhci-cadence6: Fix the license to GPL-2.0+ Hal Feng
2026-01-12 9:41 ` Quentin Schulz
2026-01-12 10:10 ` Tanmay Kathpalia
2026-01-13 9:08 ` Peng Fan
2026-01-22 8:24 ` Peng Fan (OSS)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.