All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	mahad.ibrahim.dev@gmail.com
Subject: [PATCH 03/10] staging: rtl8723bs: Fix style and formatting in HalHWImg8723B_MAC.c
Date: Mon, 12 Jan 2026 22:42:20 +0500	[thread overview]
Message-ID: <20260112174227.14922-4-mahad.ibrahim.dev@gmail.com> (raw)
In-Reply-To: <20260112174227.14922-1-mahad.ibrahim.dev@gmail.com>

Fix multiple checkpatch.pl warnings/checks in HalHWImg8723B_MAC.c.

The checkpatch.pl warnings/checks constituted:
-Lines should not end with a '('
-Please don't use multiple blank lines
-Missing a blank line after declarations
-line length of <Int> exceeds 100 columns

Adhere to kernel coding style by fixing style, alignment and line length
checkpatch.pl checks/warnings.

Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
---
 drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
index 9c07df254eaa..0bf9eaceeb4a 100644
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
@@ -8,9 +8,7 @@
 #include <linux/kernel.h>
 #include "odm_precomp.h"
 
-static bool CheckPositive(
-	struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2
-)
+static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2)
 {
 	u8 _BoardType =
 		((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /*  _GLNA */
@@ -33,7 +31,6 @@ static bool CheckPositive(
 		pDM_Odm->TypeALNA << 16 |
 		pDM_Odm->TypeAPA  << 24;
 
-
 	/*  Value Defined Check =============== */
 	/* QFN Type [15:12] and Cut Version [27:24] need to do value check */
 
@@ -50,6 +47,7 @@ static bool CheckPositive(
 
 	if ((cond1 & driver1) == cond1) {
 		u32 bitMask = 0;
+
 		if ((cond1 & 0x0F) == 0) /*  BoardType is DONTCARE */
 			return true;
 
@@ -62,7 +60,8 @@ static bool CheckPositive(
 		if ((cond1 & BIT3) != 0) /* APA */
 			bitMask |= 0xFF000000;
 
-		if ((cond2 & bitMask) == (driver2 & bitMask)) /*  BoardType of each RF path is matched */
+		/*  BoardType of each RF path is matched */
+		if ((cond2 & bitMask) == (driver2 & bitMask))
 			return true;
 	}
 	return false;
@@ -212,7 +211,10 @@ void ODM_ReadAndConfig_MP_8723B_MAC_REG(struct dm_odm_t *pDM_Odm)
 			}
 
 			if (!bMatched) {
-				/*  Condition isn't matched. Discard the following (offset, data) pairs. */
+				/*
+				 *  Condition isn't matched.
+				 *  Discard the following (offset, data) pairs.
+				 */
 				while (v1 < 0x40000000 && i < ArrayLen - 2)
 					READ_NEXT_PAIR(v1, v2, i);
 
-- 
2.47.3


  parent reply	other threads:[~2026-01-12 17:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 17:42 [PATCH 00/10] staging: rtl8723bs: HAL coding style cleanup Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 01/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_MAC.c Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 02/10] staging: rtl8723bs: Fix spaces around operator checks " Mahad Ibrahim
2026-01-12 17:42 ` Mahad Ibrahim [this message]
2026-01-16 13:01   ` [PATCH 03/10] staging: rtl8723bs: Fix style and formatting " Greg KH
2026-01-12 17:42 ` [PATCH 04/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_BB.c Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 05/10] staging: rtl8723bs: Fix spacing coding style issues " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line " Mahad Ibrahim
2026-01-16 13:03   ` Greg KH
2026-01-17 15:29     ` Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 07/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_RF.c Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 08/10] staging: rtl8723bs: Fix style and alignment issues " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 09/10] staging: rtl8723bs: Fix operator spacing " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 10/10] staging: rtl8723bs: Fix blank line checks " Mahad Ibrahim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112174227.14922-4-mahad.ibrahim.dev@gmail.com \
    --to=mahad.ibrahim.dev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.