From: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
mahad.ibrahim.dev@gmail.com
Subject: [PATCH 05/10] staging: rtl8723bs: Fix spacing coding style issues in HalHWImg8723B_BB.c
Date: Mon, 12 Jan 2026 22:42:22 +0500 [thread overview]
Message-ID: <20260112174227.14922-6-mahad.ibrahim.dev@gmail.com> (raw)
In-Reply-To: <20260112174227.14922-1-mahad.ibrahim.dev@gmail.com>
Fix checkpatch.pl checks regarding "spaces preferred around that"
operator.
Adhere to kernel coding standards by adding spaces around arithmetic and
bitwise operations.
Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
---
.../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 34 +++++++++----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
index 630dace0af47..5fcb9420fb3d 100644
--- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
+++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c
@@ -217,7 +217,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
for (i = 0; i < ArrayLen; i += 2) {
u32 v1 = Array[i];
- u32 v2 = Array[i+1];
+ u32 v2 = Array[i + 1];
/* This (offset, data) pair doesn't care the condition. */
if (v1 < 0x40000000) {
@@ -226,7 +226,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
} else {
/* This line is the beginning of branch. */
bool bMatched = true;
- u8 cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+ u8 cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
if (cCond == COND_ELSE) { /* ELSE, ENDIF */
bMatched = true;
@@ -246,22 +246,22 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
* Condition isn't matched.
* Discard the following (offset, data) pairs.
*/
- while (v1 < 0x40000000 && i < ArrayLen-2)
+ while (v1 < 0x40000000 && i < ArrayLen - 2)
READ_NEXT_PAIR(v1, v2, i);
i -= 2; /* prevent from for-loop += 2 */
} else {
/* Configure matched pairs and skip to end of if-else. */
- while (v1 < 0x40000000 && i < ArrayLen-2) {
+ while (v1 < 0x40000000 && i < ArrayLen - 2) {
odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2);
READ_NEXT_PAIR(v1, v2, i);
}
/* Keeps reading until ENDIF. */
- cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
- while (cCond != COND_ENDIF && i < ArrayLen-2) {
+ cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
+ while (cCond != COND_ENDIF && i < ArrayLen - 2) {
READ_NEXT_PAIR(v1, v2, i);
- cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+ cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
}
}
}
@@ -477,7 +477,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
for (i = 0; i < ArrayLen; i += 2) {
u32 v1 = Array[i];
- u32 v2 = Array[i+1];
+ u32 v2 = Array[i + 1];
/* This (offset, data) pair doesn't care the condition. */
if (v1 < 0x40000000) {
@@ -486,7 +486,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
} else {
/* This line is the beginning of branch. */
bool bMatched = true;
- u8 cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+ u8 cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
if (cCond == COND_ELSE) { /* ELSE, ENDIF */
bMatched = true;
@@ -506,21 +506,21 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
* Condition isn't matched.
* Discard the following (offset, data) pairs.
*/
- while (v1 < 0x40000000 && i < ArrayLen-2)
+ while (v1 < 0x40000000 && i < ArrayLen - 2)
READ_NEXT_PAIR(v1, v2, i);
i -= 2; /* prevent from for-loop += 2 */
} else { /* Configure matched pairs and skip to end of if-else. */
- while (v1 < 0x40000000 && i < ArrayLen-2) {
+ while (v1 < 0x40000000 && i < ArrayLen - 2) {
odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2);
READ_NEXT_PAIR(v1, v2, i);
}
/* Keeps reading until ENDIF. */
- cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
- while (cCond != COND_ENDIF && i < ArrayLen-2) {
+ cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
+ while (cCond != COND_ENDIF && i < ArrayLen - 2) {
READ_NEXT_PAIR(v1, v2, i);
- cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+ cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
}
}
}
@@ -550,9 +550,9 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG_PG(struct dm_odm_t *pDM_Odm)
for (i = 0; i < ARRAY_SIZE(Array_MP_8723B_PHY_REG_PG); i += 4) {
u32 v1 = Array[i];
- u32 v2 = Array[i+1];
- u32 v3 = Array[i+2];
- u32 v4 = Array[i+3];
+ u32 v2 = Array[i + 1];
+ u32 v3 = Array[i + 2];
+ u32 v4 = Array[i + 3];
odm_ConfigBB_PHY_REG_PG_8723B(pDM_Odm, v1, v2, v3, v4);
}
--
2.47.3
next prev parent reply other threads:[~2026-01-12 17:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 17:42 [PATCH 00/10] staging: rtl8723bs: HAL coding style cleanup Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 01/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_MAC.c Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 02/10] staging: rtl8723bs: Fix spaces around operator checks " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 03/10] staging: rtl8723bs: Fix style and formatting " Mahad Ibrahim
2026-01-16 13:01 ` Greg KH
2026-01-12 17:42 ` [PATCH 04/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_BB.c Mahad Ibrahim
2026-01-12 17:42 ` Mahad Ibrahim [this message]
2026-01-12 17:42 ` [PATCH 06/10] staging: rtl8723bs: Fix parenthesis and blank line issues " Mahad Ibrahim
2026-01-16 13:03 ` Greg KH
2026-01-17 15:29 ` Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 07/10] staging: rtl8723bs: Fix block comment alignment in HalHWImg8723B_RF.c Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 08/10] staging: rtl8723bs: Fix style and alignment issues " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 09/10] staging: rtl8723bs: Fix operator spacing " Mahad Ibrahim
2026-01-12 17:42 ` [PATCH 10/10] staging: rtl8723bs: Fix blank line checks " Mahad Ibrahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112174227.14922-6-mahad.ibrahim.dev@gmail.com \
--to=mahad.ibrahim.dev@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.