From: Christoph Hellwig <hch@lst.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
nitheshshetty@gmail.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state
Date: Tue, 13 Jan 2026 08:24:08 +0100 [thread overview]
Message-ID: <20260113072408.GA26776@lst.de> (raw)
In-Reply-To: <20260112142822.tk34ei4evgypw3qv@green245.gost>
On Mon, Jan 12, 2026 at 07:58:22PM +0530, Nitesh Shetty wrote:
>> Hu... Why is this not squashed with the previous patch ? If only patch 1 is
>> applied, this will not compile, right ?
>>
> I couldn’t decide whether to use the layering convention or a unified patch,
> so I chose one patch per layer.
> Agreed, independently this doesn't compile, merging make sense.
> I will resend.
Rule number one is: don't break compilation after each step.
Everything else is secondary.
Also I'm only seeing patch 2 anyway, and not patch 1.
prev parent reply other threads:[~2026-01-13 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260112140159epcas5p35303b39d11d8379b8527026e72bf0f40@epcas5p3.samsung.com>
2026-01-12 13:57 ` [PATCH 1/2] block: remove unused dma_iova_state function parameter Nitesh Shetty
2026-01-12 13:57 ` [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state Nitesh Shetty
2026-01-12 14:08 ` Damien Le Moal
2026-01-12 14:28 ` Nitesh Shetty
2026-01-13 7:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113072408.GA26776@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.