* [PATCH 1/2] block: remove unused dma_iova_state function parameter [not found] <CGME20260112140159epcas5p35303b39d11d8379b8527026e72bf0f40@epcas5p3.samsung.com> @ 2026-01-12 13:57 ` Nitesh Shetty 2026-01-12 13:57 ` [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state Nitesh Shetty 0 siblings, 1 reply; 5+ messages in thread From: Nitesh Shetty @ 2026-01-12 13:57 UTC (permalink / raw) To: Jens Axboe Cc: nitheshshetty, Nitesh Shetty, linux-block, linux-kernel, linux-nvme DMA IOVA state is not used inside blk_rq_dma_map_iter_next Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> --- block/blk-mq-dma.c | 3 +-- include/linux/blk-mq-dma.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c index 752060d7261cb..3c87779cdc19d 100644 --- a/block/blk-mq-dma.c +++ b/block/blk-mq-dma.c @@ -233,7 +233,6 @@ EXPORT_SYMBOL_GPL(blk_rq_dma_map_iter_start); * blk_rq_dma_map_iter_next - map the next DMA segment for a request * @req: request to map * @dma_dev: device to map to - * @state: DMA IOVA state * @iter: block layer DMA iterator * * Iterate to the next mapping after a previous call to @@ -248,7 +247,7 @@ EXPORT_SYMBOL_GPL(blk_rq_dma_map_iter_start); * returned in @iter.status. */ bool blk_rq_dma_map_iter_next(struct request *req, struct device *dma_dev, - struct dma_iova_state *state, struct blk_dma_iter *iter) + struct blk_dma_iter *iter) { struct phys_vec vec; diff --git a/include/linux/blk-mq-dma.h b/include/linux/blk-mq-dma.h index cb88fc791fbd1..214c181ff2c9c 100644 --- a/include/linux/blk-mq-dma.h +++ b/include/linux/blk-mq-dma.h @@ -28,7 +28,7 @@ struct blk_dma_iter { bool blk_rq_dma_map_iter_start(struct request *req, struct device *dma_dev, struct dma_iova_state *state, struct blk_dma_iter *iter); bool blk_rq_dma_map_iter_next(struct request *req, struct device *dma_dev, - struct dma_iova_state *state, struct blk_dma_iter *iter); + struct blk_dma_iter *iter); /** * blk_rq_dma_map_coalesce - were all segments coalesced? -- 2.39.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state 2026-01-12 13:57 ` [PATCH 1/2] block: remove unused dma_iova_state function parameter Nitesh Shetty @ 2026-01-12 13:57 ` Nitesh Shetty 2026-01-12 14:08 ` Damien Le Moal 0 siblings, 1 reply; 5+ messages in thread From: Nitesh Shetty @ 2026-01-12 13:57 UTC (permalink / raw) To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg Cc: nitheshshetty, Nitesh Shetty, linux-block, linux-kernel, linux-nvme DMA IOVA state is not used inside blk_rq_dma_map_iter_next Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> --- drivers/nvme/host/pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 3b528369f5454..065555576d2f9 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -823,7 +823,7 @@ static bool nvme_pci_prp_iter_next(struct request *req, struct device *dma_dev, if (iter->len) return true; - if (!blk_rq_dma_map_iter_next(req, dma_dev, &iod->dma_state, iter)) + if (!blk_rq_dma_map_iter_next(req, dma_dev, iter)) return false; if (!dma_use_iova(&iod->dma_state) && dma_need_unmap(dma_dev)) { iod->dma_vecs[iod->nr_dma_vecs].addr = iter->addr; @@ -1010,8 +1010,7 @@ static blk_status_t nvme_pci_setup_data_sgl(struct request *req, } nvme_pci_sgl_set_data(&sg_list[mapped++], iter); iod->total_len += iter->len; - } while (blk_rq_dma_map_iter_next(req, nvmeq->dev->dev, &iod->dma_state, - iter)); + } while (blk_rq_dma_map_iter_next(req, nvmeq->dev->dev, iter)); nvme_pci_sgl_set_seg(&iod->cmd.common.dptr.sgl, sgl_dma, mapped); if (unlikely(iter->status)) -- 2.39.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state 2026-01-12 13:57 ` [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state Nitesh Shetty @ 2026-01-12 14:08 ` Damien Le Moal 2026-01-12 14:28 ` Nitesh Shetty 0 siblings, 1 reply; 5+ messages in thread From: Damien Le Moal @ 2026-01-12 14:08 UTC (permalink / raw) To: Nitesh Shetty, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg Cc: nitheshshetty, linux-block, linux-kernel, linux-nvme On 1/12/26 14:57, Nitesh Shetty wrote: > DMA IOVA state is not used inside blk_rq_dma_map_iter_next > > Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> > --- > drivers/nvme/host/pci.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index 3b528369f5454..065555576d2f9 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -823,7 +823,7 @@ static bool nvme_pci_prp_iter_next(struct request *req, struct device *dma_dev, > > if (iter->len) > return true; > - if (!blk_rq_dma_map_iter_next(req, dma_dev, &iod->dma_state, iter)) > + if (!blk_rq_dma_map_iter_next(req, dma_dev, iter)) Hu... Why is this not squashed with the previous patch ? If only patch 1 is applied, this will not compile, right ? > return false; > if (!dma_use_iova(&iod->dma_state) && dma_need_unmap(dma_dev)) { > iod->dma_vecs[iod->nr_dma_vecs].addr = iter->addr; > @@ -1010,8 +1010,7 @@ static blk_status_t nvme_pci_setup_data_sgl(struct request *req, > } > nvme_pci_sgl_set_data(&sg_list[mapped++], iter); > iod->total_len += iter->len; > - } while (blk_rq_dma_map_iter_next(req, nvmeq->dev->dev, &iod->dma_state, > - iter)); > + } while (blk_rq_dma_map_iter_next(req, nvmeq->dev->dev, iter)); > > nvme_pci_sgl_set_seg(&iod->cmd.common.dptr.sgl, sgl_dma, mapped); > if (unlikely(iter->status)) -- Damien Le Moal Western Digital Research ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state 2026-01-12 14:08 ` Damien Le Moal @ 2026-01-12 14:28 ` Nitesh Shetty 2026-01-13 7:24 ` Christoph Hellwig 0 siblings, 1 reply; 5+ messages in thread From: Nitesh Shetty @ 2026-01-12 14:28 UTC (permalink / raw) To: Damien Le Moal Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, nitheshshetty, linux-block, linux-kernel, linux-nvme [-- Attachment #1: Type: text/plain, Size: 1083 bytes --] On 12/01/26 03:08PM, Damien Le Moal wrote: >On 1/12/26 14:57, Nitesh Shetty wrote: >> DMA IOVA state is not used inside blk_rq_dma_map_iter_next >> >> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> >> --- >> drivers/nvme/host/pci.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c >> index 3b528369f5454..065555576d2f9 100644 >> --- a/drivers/nvme/host/pci.c >> +++ b/drivers/nvme/host/pci.c >> @@ -823,7 +823,7 @@ static bool nvme_pci_prp_iter_next(struct request *req, struct device *dma_dev, >> >> if (iter->len) >> return true; >> - if (!blk_rq_dma_map_iter_next(req, dma_dev, &iod->dma_state, iter)) >> + if (!blk_rq_dma_map_iter_next(req, dma_dev, iter)) > >Hu... Why is this not squashed with the previous patch ? If only patch 1 is >applied, this will not compile, right ? > I couldn’t decide whether to use the layering convention or a unified patch, so I chose one patch per layer. Agreed, independently this doesn't compile, merging make sense. I will resend. Thanks, Nitesh [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state 2026-01-12 14:28 ` Nitesh Shetty @ 2026-01-13 7:24 ` Christoph Hellwig 0 siblings, 0 replies; 5+ messages in thread From: Christoph Hellwig @ 2026-01-13 7:24 UTC (permalink / raw) To: Nitesh Shetty Cc: Damien Le Moal, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, nitheshshetty, linux-block, linux-kernel, linux-nvme On Mon, Jan 12, 2026 at 07:58:22PM +0530, Nitesh Shetty wrote: >> Hu... Why is this not squashed with the previous patch ? If only patch 1 is >> applied, this will not compile, right ? >> > I couldn’t decide whether to use the layering convention or a unified patch, > so I chose one patch per layer. > Agreed, independently this doesn't compile, merging make sense. > I will resend. Rule number one is: don't break compilation after each step. Everything else is secondary. Also I'm only seeing patch 2 anyway, and not patch 1. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-13 7:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20260112140159epcas5p35303b39d11d8379b8527026e72bf0f40@epcas5p3.samsung.com>
2026-01-12 13:57 ` [PATCH 1/2] block: remove unused dma_iova_state function parameter Nitesh Shetty
2026-01-12 13:57 ` [PATCH 2/2] nvme: blk_rq_dma_map_iter_next is no longer using iova state Nitesh Shetty
2026-01-12 14:08 ` Damien Le Moal
2026-01-12 14:28 ` Nitesh Shetty
2026-01-13 7:24 ` Christoph Hellwig
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.