From: Jonathan Cameron via <qemu-arm@nongnu.org>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
<eric.auger@redhat.com>, <alex@shazbot.org>, <clg@redhat.com>,
<cohuck@redhat.com>, <mst@redhat.com>, <nicolinc@nvidia.com>,
<nathanc@nvidia.com>, <mochs@nvidia.com>, <jgg@nvidia.com>,
<kjaju@nvidia.com>
Subject: Re: [PATCH v2 3/4] hw/vfio: Add helper to retrieve device feature
Date: Wed, 14 Jan 2026 10:19:49 +0000 [thread overview]
Message-ID: <20260114101949.0000669d@huawei.com> (raw)
In-Reply-To: <20260113113754.1189-4-skolothumtho@nvidia.com>
On Tue, 13 Jan 2026 11:37:53 +0000
Shameer Kolothum <skolothumtho@nvidia.com> wrote:
> Add vfio_device_get_feature() as a common helper to retrieve
> VFIO device features.
>
> No functional change intended.
>
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Hi Shameer,
Happy new year.
Trivial thing noticed whilst glancing at this.
> diff --git a/hw/vfio/device.c b/hw/vfio/device.c
> index 100532f35d..0d9f42a1f0 100644
> --- a/hw/vfio/device.c
> +++ b/hw/vfio/device.c
> @@ -516,6 +516,7 @@ void vfio_device_unprepare(VFIODevice *vbasedev)
> vbasedev->bcontainer = NULL;
> }
>
> +
Stray change.
> bool vfio_device_get_viommu_flags_want_nesting(VFIODevice *vbasedev)
> {
> VFIOPCIDevice *vdev = vfio_pci_from_vfio_device(vbasedev);
> @@ -527,6 +528,15 @@ bool vfio_device_get_viommu_flags_want_nesting(VFIODevice *vbasedev)
> return false;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via qemu development <qemu-devel@nongnu.org>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
<eric.auger@redhat.com>, <alex@shazbot.org>, <clg@redhat.com>,
<cohuck@redhat.com>, <mst@redhat.com>, <nicolinc@nvidia.com>,
<nathanc@nvidia.com>, <mochs@nvidia.com>, <jgg@nvidia.com>,
<kjaju@nvidia.com>
Subject: Re: [PATCH v2 3/4] hw/vfio: Add helper to retrieve device feature
Date: Wed, 14 Jan 2026 10:19:49 +0000 [thread overview]
Message-ID: <20260114101949.0000669d@huawei.com> (raw)
In-Reply-To: <20260113113754.1189-4-skolothumtho@nvidia.com>
On Tue, 13 Jan 2026 11:37:53 +0000
Shameer Kolothum <skolothumtho@nvidia.com> wrote:
> Add vfio_device_get_feature() as a common helper to retrieve
> VFIO device features.
>
> No functional change intended.
>
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Hi Shameer,
Happy new year.
Trivial thing noticed whilst glancing at this.
> diff --git a/hw/vfio/device.c b/hw/vfio/device.c
> index 100532f35d..0d9f42a1f0 100644
> --- a/hw/vfio/device.c
> +++ b/hw/vfio/device.c
> @@ -516,6 +516,7 @@ void vfio_device_unprepare(VFIODevice *vbasedev)
> vbasedev->bcontainer = NULL;
> }
>
> +
Stray change.
> bool vfio_device_get_viommu_flags_want_nesting(VFIODevice *vbasedev)
> {
> VFIOPCIDevice *vdev = vfio_pci_from_vfio_device(vbasedev);
> @@ -527,6 +528,15 @@ bool vfio_device_get_viommu_flags_want_nesting(VFIODevice *vbasedev)
> return false;
> }
next prev parent reply other threads:[~2026-01-14 10:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 11:37 [PATCH v2 0/4] vfio: Add DMABUF support for PCI BAR regions Shameer Kolothum
2026-01-13 11:37 ` [PATCH v2 1/4] linux-headers: Update to Linux v6.19-rc1 Shameer Kolothum
2026-01-15 12:45 ` Cédric Le Goater
2026-01-13 11:37 ` [PATCH v2 2/4] hw/net/virtio-net: Adapt hash handling to updated UAPI Shameer Kolothum
2026-01-15 12:45 ` Cédric Le Goater
2026-02-03 17:32 ` Michael S. Tsirkin
2026-01-13 11:37 ` [PATCH v2 3/4] hw/vfio: Add helper to retrieve device feature Shameer Kolothum
2026-01-14 10:19 ` Jonathan Cameron via [this message]
2026-01-14 10:19 ` Jonathan Cameron via qemu development
2026-01-15 12:44 ` Cédric Le Goater
2026-01-15 12:46 ` Cédric Le Goater
2026-01-13 11:37 ` [PATCH v2 4/4] hw/vfio/region: Create dmabuf for PCI BAR per region Shameer Kolothum
2026-01-14 9:16 ` Duan, Zhenzhong
2026-01-15 12:50 ` Cédric Le Goater
2026-01-15 14:32 ` Shameer Kolothum
2026-01-15 15:58 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114101949.0000669d@huawei.com \
--to=qemu-arm@nongnu.org \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kjaju@nvidia.com \
--cc=mochs@nvidia.com \
--cc=mst@redhat.com \
--cc=nathanc@nvidia.com \
--cc=nicolinc@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=skolothumtho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.