Re: [PATCH v7 32/36] backends/iommufd: Add get_pasid_info() callback

[Jonathan Cameron via <qemu-arm@nongnu.org>]

On Sun, 11 Jan 2026 19:53:18 +0000
Shameer Kolothum <skolothumtho@nvidia.com> wrote:

> The get_pasid_info callback retrieves PASID capability information
> when the HostIOMMUDevice backend supports it. Currently, only the
> Linux IOMMUFD backend provides this information.
> 
> This will be used by a subsequent patch to synthesize a PASID
> capability for vfio-pci devices behind a vIOMMU that supports PASID.
> 
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Hi Shameer,

Trivial missing parameter docs comment below.  Assuming you just duplicate
the equivalent docs from just above:

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

J
> diff --git a/include/system/host_iommu_device.h b/include/system/host_iommu_device.h
> index bfb2b60478..4fbada638f 100644
> --- a/include/system/host_iommu_device.h
> +++ b/include/system/host_iommu_device.h
...
>  /**
>   * struct HostIOMMUDeviceClass - The base class for all host IOMMU devices.
>   *
> @@ -116,6 +122,15 @@ struct HostIOMMUDeviceClass {
>       * @hiod: handle to the host IOMMU device
>       */
>      uint64_t (*get_page_size_mask)(HostIOMMUDevice *hiod);
> +    /**
> +     * @get_pasid_info: Return the PASID information associated with the Host
> +     * IOMMU device.
> +     *

Feels like it should be complete and say what hiod is as well (see call above).

> +     * @pasid_info: If success, returns the PASID related information.
> +     *
> +     * Returns: true on success, false on failure.
> +     */
> +    bool (*get_pasid_info)(HostIOMMUDevice *hiod, PasidInfo *pasid_info);
>  };
>  
>  /*