From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <wqu@suse.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"André Almeida" <andrealmeid@igalia.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Carlos Maiolino" <cem@kernel.org>,
"Amir Goldstein" <amir73il@gmail.com>, "Chris Mason" <clm@fb.com>,
"David Sterba" <dsterba@suse.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Christian Brauner" <brauner@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Jan Kara" <jack@suse.cz>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
kernel-dev@igalia.com
Subject: Re: [PATCH 3/3] ovl: Use real disk UUID for origin file handles
Date: Thu, 15 Jan 2026 09:31:31 +0100 [thread overview]
Message-ID: <20260115083131.GA12267@lst.de> (raw)
In-Reply-To: <461fc582-71ba-4238-9696-3d8bdd8a0207@suse.com>
On Thu, Jan 15, 2026 at 06:39:05PM +1030, Qu Wenruo wrote:
>>> Then for those SINGLE_DEV fses, disable any multi-device related features,
>>> and use their dev_t to distinguish different fses just like EXT4/XFS,
>>> without bothering the current tempfsid hack, and just return the same fsid.
>>
>> dev_t is not related to the uuid in any way for XFS, and while I'm not
>> an expert there I'm pretty sure ext4 uses the same not dev related uuid
>> generation.
>
> My bad, by dev_t I mean bdev holder, which is a pointer to the super block
> of the mounted fs. (And btrfs just recently join this common usage)
How is that related? That prevents multiple callers from exclusively
using a block device. Cloned file systems will sit on different devices.
> Yeah, although it's possible to mount different devices with same fsid
> separately, I don't think it's really that a good idea either.
>
> Thus I really prefer to have special flags for those "uncommon" use cases,
> other than the current automatically enabled tempfsid feature.
For XFS we require the nouuid option to allows additional mounts of
file systems with the same uuid. I think that is the equivalent to
what btrfs calls the fsid.
next prev parent reply other threads:[~2026-01-15 8:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 4:31 [PATCH 0/3] fs: Support btrfs cloned images and overlayfs André Almeida
2026-01-14 4:31 ` [PATCH 1/3] exportfs: Rename get_uuid() to get_disk_uuid() André Almeida
2026-01-14 6:10 ` Darrick J. Wong
2026-01-14 6:24 ` Christoph Hellwig
2026-01-14 10:12 ` Amir Goldstein
2026-01-14 13:11 ` Christoph Hellwig
2026-01-14 16:38 ` André Almeida
2026-01-14 17:58 ` Amir Goldstein
2026-01-14 4:31 ` [PATCH 2/3] btrfs: Implement get_disk_uuid() André Almeida
2026-01-14 4:31 ` [PATCH 3/3] ovl: Use real disk UUID for origin file handles André Almeida
2026-01-14 6:26 ` Christoph Hellwig
2026-01-14 16:17 ` André Almeida
2026-01-15 6:29 ` Christoph Hellwig
2026-01-15 6:51 ` Qu Wenruo
2026-01-15 7:23 ` Christoph Hellwig
2026-01-15 8:09 ` Qu Wenruo
2026-01-15 8:31 ` Christoph Hellwig [this message]
2026-01-15 15:42 ` André Almeida
2026-01-15 16:07 ` Amir Goldstein
2026-01-15 18:55 ` André Almeida
2026-01-16 9:36 ` Christoph Hellwig
2026-01-16 9:55 ` Amir Goldstein
2026-01-16 13:27 ` André Almeida
2026-01-16 17:06 ` Amir Goldstein
2026-01-19 16:56 ` André Almeida
2026-01-20 15:12 ` Amir Goldstein
2026-01-22 20:07 ` Amir Goldstein
2026-01-23 13:24 ` André Almeida
2026-01-23 20:08 ` André Almeida
2026-01-24 10:45 ` Amir Goldstein
2026-01-28 11:49 ` Amir Goldstein
2026-02-05 20:34 ` André Almeida
2026-02-06 13:12 ` Amir Goldstein
2026-02-16 14:59 ` André Almeida
2026-02-17 13:26 ` Amir Goldstein
2026-01-15 16:08 ` Christoph Hellwig
2026-01-14 17:54 ` Amir Goldstein
2026-01-15 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115083131.GA12267@lst.de \
--to=hch@lst.de \
--cc=Dai.Ngo@oracle.com \
--cc=amir73il@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.