From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
"David Hildenbrand (Red Hat)" <david@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oscar Salvador" <osalvador@suse.de>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jerrin Shaji George" <jerrin.shaji-george@broadcom.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>, "Zi Yan" <ziy@nvidia.com>
Subject: [PATCH v2 12/23] mm/balloon_compaction: remove balloon_page_push/pop()
Date: Thu, 15 Jan 2026 10:20:02 +0100 [thread overview]
Message-ID: <20260115092015.3928975-13-david@kernel.org> (raw)
In-Reply-To: <20260115092015.3928975-1-david@kernel.org>
Let's remove these helpers as they are unused now.
Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>
---
include/linux/balloon_compaction.h | 30 ------------------------------
mm/balloon_compaction.c | 5 ++---
2 files changed, 2 insertions(+), 33 deletions(-)
diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
index 1452ea0635245..e5451cf1f6589 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -126,34 +126,4 @@ static inline void balloon_page_finalize(struct page *page)
set_page_private(page, 0);
/* PageOffline is sticky until the page is freed to the buddy. */
}
-
-/*
- * balloon_page_push - insert a page into a page list.
- * @head : pointer to list
- * @page : page to be added
- *
- * Caller must ensure the page is private and protect the list.
- */
-static inline void balloon_page_push(struct list_head *pages, struct page *page)
-{
- list_add(&page->lru, pages);
-}
-
-/*
- * balloon_page_pop - remove a page from a page list.
- * @head : pointer to list
- * @page : page to be added
- *
- * Caller must ensure the page is private and protect the list.
- */
-static inline struct page *balloon_page_pop(struct list_head *pages)
-{
- struct page *page = list_first_entry_or_null(pages, struct page, lru);
-
- if (!page)
- return NULL;
-
- list_del(&page->lru);
- return page;
-}
#endif /* _LINUX_BALLOON_COMPACTION_H */
diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
index c44e0b62203cc..90b2d61a593b7 100644
--- a/mm/balloon_compaction.c
+++ b/mm/balloon_compaction.c
@@ -128,9 +128,8 @@ EXPORT_SYMBOL_GPL(balloon_page_alloc);
* Drivers must call this function to properly enqueue a new allocated balloon
* page before definitively removing the page from the guest system.
*
- * Drivers must not call balloon_page_enqueue on pages that have been pushed to
- * a list with balloon_page_push before removing them with balloon_page_pop. To
- * enqueue a list of pages, use balloon_page_list_enqueue instead.
+ * Drivers must not enqueue pages while page->lru is still in
+ * use, and must not use page->lru until a page was unqueued again.
*/
void balloon_page_enqueue(struct balloon_dev_info *b_dev_info,
struct page *page)
--
2.52.0
next prev parent reply other threads:[~2026-01-15 9:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 9:19 [PATCH v2 00/23] mm: balloon infrastructure cleanups David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating David Hildenbrand (Red Hat)
2026-01-15 9:56 ` Lorenzo Stoakes
2026-01-15 9:19 ` [PATCH v2 02/23] vmw_balloon: remove vmballoon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:20 ` Lorenzo Stoakes
2026-01-15 9:19 ` [PATCH v2 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:46 ` Lorenzo Stoakes
2026-01-19 22:44 ` David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 04/23] mm/balloon_compaction: centralize basic page migration handling David Hildenbrand (Red Hat)
2026-01-15 12:18 ` Lorenzo Stoakes
2026-01-15 12:57 ` David Hildenbrand (Red Hat)
2026-01-19 22:22 ` David Hildenbrand (Red Hat)
2026-01-19 22:25 ` David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 05/23] mm/balloon_compaction: centralize adjust_managed_page_count() handling David Hildenbrand (Red Hat)
2026-01-15 14:06 ` Liam R. Howlett
2026-01-15 9:19 ` [PATCH v2 06/23] vmw_balloon: stop using the balloon_dev_info lock David Hildenbrand (Red Hat)
2026-01-15 12:21 ` Lorenzo Stoakes
2026-01-15 12:26 ` David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 07/23] mm/balloon_compaction: use a device-independent balloon (list) lock David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 08/23] mm/balloon_compaction: remove dependency on page lock David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 09/23] mm/balloon_compaction: make balloon_mops static David Hildenbrand (Red Hat)
2026-01-15 12:22 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 12:25 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 11/23] drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() David Hildenbrand (Red Hat)
2026-01-15 12:28 ` Lorenzo Stoakes
2026-01-15 9:20 ` David Hildenbrand (Red Hat) [this message]
2026-01-15 12:29 ` [PATCH v2 12/23] mm/balloon_compaction: remove balloon_page_push/pop() Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 13/23] mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc() David Hildenbrand (Red Hat)
2026-01-15 12:30 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 14/23] mm/balloon_compaction: move internal helpers to balloon_compaction.c David Hildenbrand (Red Hat)
2026-01-15 12:32 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 15/23] mm/balloon_compaction: assert that the balloon_pages_lock is held David Hildenbrand (Red Hat)
2026-01-15 12:32 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc David Hildenbrand (Red Hat)
2026-01-15 12:33 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 17/23] mm/balloon_compaction: remove "extern" from functions David Hildenbrand (Red Hat)
2026-01-15 12:34 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 18/23] mm/vmscan: drop inclusion of balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 13:42 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 19/23] mm: rename balloon_compaction.(c|h) to balloon.(c|h) David Hildenbrand (Red Hat)
2026-01-15 13:45 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:47 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 21/23] mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:52 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON David Hildenbrand (Red Hat)
2026-01-15 13:55 ` Lorenzo Stoakes
2026-01-15 16:33 ` David Hildenbrand (Red Hat)
2026-01-15 16:50 ` Michael S. Tsirkin
2026-01-15 16:53 ` Michael S. Tsirkin
2026-01-15 16:56 ` David Hildenbrand (Red Hat)
2026-01-15 16:57 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 23/23] MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON" David Hildenbrand (Red Hat)
2026-01-15 9:32 ` Michael S. Tsirkin
2026-01-15 11:21 ` David Hildenbrand (Red Hat)
2026-01-15 9:38 ` Lance Yang
2026-01-15 11:22 ` David Hildenbrand (Red Hat)
2026-01-15 9:39 ` Lorenzo Stoakes
2026-01-15 11:25 ` David Hildenbrand (Red Hat)
2026-01-15 12:01 ` Vlastimil Babka
2026-01-15 9:32 ` [PATCH v2 00/23] mm: balloon infrastructure cleanups Michael S. Tsirkin
2026-01-15 11:26 ` David Hildenbrand (Red Hat)
2026-01-15 18:49 ` Andrew Morton
2026-01-15 19:47 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115092015.3928975-13-david@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jerrin.shaji-george@broadcom.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.