All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
	"David Hildenbrand (Red Hat)" <david@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Oscar Salvador" <osalvador@suse.de>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jerrin Shaji George" <jerrin.shaji-george@broadcom.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Eugenio Pérez" <eperezma@redhat.com>, "Zi Yan" <ziy@nvidia.com>
Subject: [PATCH v2 14/23] mm/balloon_compaction: move internal helpers to balloon_compaction.c
Date: Thu, 15 Jan 2026 10:20:04 +0100	[thread overview]
Message-ID: <20260115092015.3928975-15-david@kernel.org> (raw)
In-Reply-To: <20260115092015.3928975-1-david@kernel.org>

Let's move the helpers that are not required by drivers anymore.

While at it, drop the doc of balloon_page_device() as it is trivial.

Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>
---
 include/linux/balloon_compaction.h | 44 ------------------------------
 mm/balloon_compaction.c            | 38 ++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 44 deletions(-)

diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
index d1d4739398978..eec8994056a44 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -75,48 +75,4 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon)
 	balloon->migratepage = NULL;
 	balloon->adjust_managed_page_count = false;
 }
-
-#ifdef CONFIG_BALLOON_COMPACTION
-/*
- * balloon_page_device - get the b_dev_info descriptor for the balloon device
- *			 that enqueues the given page.
- */
-static inline struct balloon_dev_info *balloon_page_device(struct page *page)
-{
-	return (struct balloon_dev_info *)page_private(page);
-}
-#endif /* CONFIG_BALLOON_COMPACTION */
-
-/*
- * balloon_page_insert - insert a page into the balloon's page list and make
- *			 the page->private assignment accordingly.
- * @balloon : pointer to balloon device
- * @page    : page to be assigned as a 'balloon page'
- *
- * Caller must ensure the balloon_pages_lock is held.
- */
-static inline void balloon_page_insert(struct balloon_dev_info *balloon,
-				       struct page *page)
-{
-	__SetPageOffline(page);
-	if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) {
-		SetPageMovableOps(page);
-		set_page_private(page, (unsigned long)balloon);
-	}
-	list_add(&page->lru, &balloon->pages);
-}
-
-/*
- * balloon_page_finalize - prepare a balloon page that was removed from the
- *			   balloon list for release to the page allocator
- * @page: page to be released to the page allocator
- *
- * Caller must ensure the balloon_pages_lock is held.
- */
-static inline void balloon_page_finalize(struct page *page)
-{
-	if (IS_ENABLED(CONFIG_BALLOON_COMPACTION))
-		set_page_private(page, 0);
-	/* PageOffline is sticky until the page is freed to the buddy. */
-}
 #endif /* _LINUX_BALLOON_COMPACTION_H */
diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
index 709c57c00b481..717bc43732d09 100644
--- a/mm/balloon_compaction.c
+++ b/mm/balloon_compaction.c
@@ -17,6 +17,44 @@
  */
 static DEFINE_SPINLOCK(balloon_pages_lock);
 
+static inline struct balloon_dev_info *balloon_page_device(struct page *page)
+{
+	return (struct balloon_dev_info *)page_private(page);
+}
+
+/*
+ * balloon_page_insert - insert a page into the balloon's page list and make
+ *			 the page->private assignment accordingly.
+ * @balloon : pointer to balloon device
+ * @page    : page to be assigned as a 'balloon page'
+ *
+ * Caller must ensure the balloon_pages_lock is held.
+ */
+static inline void balloon_page_insert(struct balloon_dev_info *balloon,
+				       struct page *page)
+{
+	__SetPageOffline(page);
+	if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) {
+		SetPageMovableOps(page);
+		set_page_private(page, (unsigned long)balloon);
+	}
+	list_add(&page->lru, &balloon->pages);
+}
+
+/*
+ * balloon_page_finalize - prepare a balloon page that was removed from the
+ *			   balloon list for release to the page allocator
+ * @page: page to be released to the page allocator
+ *
+ * Caller must ensure the balloon_pages_lock is held.
+ */
+static inline void balloon_page_finalize(struct page *page)
+{
+	if (IS_ENABLED(CONFIG_BALLOON_COMPACTION))
+		set_page_private(page, 0);
+	/* PageOffline is sticky until the page is freed to the buddy. */
+}
+
 static void balloon_page_enqueue_one(struct balloon_dev_info *b_dev_info,
 				     struct page *page)
 {
-- 
2.52.0


  parent reply	other threads:[~2026-01-15  9:22 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  9:19 [PATCH v2 00/23] mm: balloon infrastructure cleanups David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating David Hildenbrand (Red Hat)
2026-01-15  9:56   ` Lorenzo Stoakes
2026-01-15  9:19 ` [PATCH v2 02/23] vmw_balloon: remove vmballoon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:20   ` Lorenzo Stoakes
2026-01-15  9:19 ` [PATCH v2 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:46   ` Lorenzo Stoakes
2026-01-19 22:44     ` David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 04/23] mm/balloon_compaction: centralize basic page migration handling David Hildenbrand (Red Hat)
2026-01-15 12:18   ` Lorenzo Stoakes
2026-01-15 12:57     ` David Hildenbrand (Red Hat)
2026-01-19 22:22   ` David Hildenbrand (Red Hat)
2026-01-19 22:25     ` David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 05/23] mm/balloon_compaction: centralize adjust_managed_page_count() handling David Hildenbrand (Red Hat)
2026-01-15 14:06   ` Liam R. Howlett
2026-01-15  9:19 ` [PATCH v2 06/23] vmw_balloon: stop using the balloon_dev_info lock David Hildenbrand (Red Hat)
2026-01-15 12:21   ` Lorenzo Stoakes
2026-01-15 12:26     ` David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 07/23] mm/balloon_compaction: use a device-independent balloon (list) lock David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 08/23] mm/balloon_compaction: remove dependency on page lock David Hildenbrand (Red Hat)
2026-01-15  9:19 ` [PATCH v2 09/23] mm/balloon_compaction: make balloon_mops static David Hildenbrand (Red Hat)
2026-01-15 12:22   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 12:25   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 11/23] drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() David Hildenbrand (Red Hat)
2026-01-15 12:28   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 12/23] mm/balloon_compaction: remove balloon_page_push/pop() David Hildenbrand (Red Hat)
2026-01-15 12:29   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 13/23] mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc() David Hildenbrand (Red Hat)
2026-01-15 12:30   ` Lorenzo Stoakes
2026-01-15  9:20 ` David Hildenbrand (Red Hat) [this message]
2026-01-15 12:32   ` [PATCH v2 14/23] mm/balloon_compaction: move internal helpers to balloon_compaction.c Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 15/23] mm/balloon_compaction: assert that the balloon_pages_lock is held David Hildenbrand (Red Hat)
2026-01-15 12:32   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc David Hildenbrand (Red Hat)
2026-01-15 12:33   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 17/23] mm/balloon_compaction: remove "extern" from functions David Hildenbrand (Red Hat)
2026-01-15 12:34   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 18/23] mm/vmscan: drop inclusion of balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 13:42   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 19/23] mm: rename balloon_compaction.(c|h) to balloon.(c|h) David Hildenbrand (Red Hat)
2026-01-15 13:45   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:47   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 21/23] mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:52   ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON David Hildenbrand (Red Hat)
2026-01-15 13:55   ` Lorenzo Stoakes
2026-01-15 16:33     ` David Hildenbrand (Red Hat)
2026-01-15 16:50       ` Michael S. Tsirkin
2026-01-15 16:53       ` Michael S. Tsirkin
2026-01-15 16:56         ` David Hildenbrand (Red Hat)
2026-01-15 16:57       ` Lorenzo Stoakes
2026-01-15  9:20 ` [PATCH v2 23/23] MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON" David Hildenbrand (Red Hat)
2026-01-15  9:32   ` Michael S. Tsirkin
2026-01-15 11:21     ` David Hildenbrand (Red Hat)
2026-01-15  9:38   ` Lance Yang
2026-01-15 11:22     ` David Hildenbrand (Red Hat)
2026-01-15  9:39   ` Lorenzo Stoakes
2026-01-15 11:25     ` David Hildenbrand (Red Hat)
2026-01-15 12:01       ` Vlastimil Babka
2026-01-15  9:32 ` [PATCH v2 00/23] mm: balloon infrastructure cleanups Michael S. Tsirkin
2026-01-15 11:26   ` David Hildenbrand (Red Hat)
2026-01-15 18:49 ` Andrew Morton
2026-01-15 19:47   ` David Hildenbrand (Red Hat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115092015.3928975-15-david@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=eperezma@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=jerrin.shaji-george@broadcom.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maddy@linux.ibm.com \
    --cc=mhocko@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=osalvador@suse.de \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.