All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: Drew Fustini <dfustini@oss.tenstorrent.com>,
	 Joel Stanley <jms@oss.tenstorrent.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	joel@jms.id.au, fustini@kernel.org,  mpe@kernel.org,
	mpe@oss.tenstorrent.com, npiggin@oss.tenstorrent.com,
	 agross@kernel.org, agross@oss.tenstorrent.com
Subject: Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Date: Fri, 16 Jan 2026 10:02:01 +0100	[thread overview]
Message-ID: <20260116-unique-devious-elephant-e9de6d@quoll> (raw)
In-Reply-To: <20260115-atlantis-clocks-v1-4-7356e671f28b@oss.tenstorrent.com>

On Thu, Jan 15, 2026 at 05:42:03PM -0600, Anirudh Srinivasan wrote:
> Document resets from RCPU syscon for atlantis.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> ---
>  .../tenstorrent/tenstorrent,atlantis-syscon.yaml   |  5 ++++
>  .../clock/tenstorrent,atlantis-syscon.h            | 34 ++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> index 3915d78dfeda..7e9c8d85ba9e 100644
> --- a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> +++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml

There is no such file in linux-next.

> @@ -31,11 +31,15 @@ properties:
>      description:
>        See <dt-bindings/clock/tenstorrent,atlantis-syscon.h> for valid indices.
>  
> +  "#reset-cells":
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
>    - clocks
>    - "#clock-cells"
> +  - "#reset-cells"

Why aren't you posting COMPLETE bindings on first posting? This is now
ABI break for no good reasons - you knew your device has resets.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: Drew Fustini <dfustini@oss.tenstorrent.com>,
	 Joel Stanley <jms@oss.tenstorrent.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	joel@jms.id.au, fustini@kernel.org,  mpe@kernel.org,
	mpe@oss.tenstorrent.com, npiggin@oss.tenstorrent.com,
	 agross@kernel.org, agross@oss.tenstorrent.com
Subject: Re: [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets
Date: Fri, 16 Jan 2026 10:02:01 +0100	[thread overview]
Message-ID: <20260116-unique-devious-elephant-e9de6d@quoll> (raw)
In-Reply-To: <20260115-atlantis-clocks-v1-4-7356e671f28b@oss.tenstorrent.com>

On Thu, Jan 15, 2026 at 05:42:03PM -0600, Anirudh Srinivasan wrote:
> Document resets from RCPU syscon for atlantis.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> ---
>  .../tenstorrent/tenstorrent,atlantis-syscon.yaml   |  5 ++++
>  .../clock/tenstorrent,atlantis-syscon.h            | 34 ++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> index 3915d78dfeda..7e9c8d85ba9e 100644
> --- a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml
> +++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml

There is no such file in linux-next.

> @@ -31,11 +31,15 @@ properties:
>      description:
>        See <dt-bindings/clock/tenstorrent,atlantis-syscon.h> for valid indices.
>  
> +  "#reset-cells":
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
>    - clocks
>    - "#clock-cells"
> +  - "#reset-cells"

Why aren't you posting COMPLETE bindings on first posting? This is now
ABI break for no good reasons - you knew your device has resets.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-01-16  9:02 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 23:41 [PATCH 0/8] Add Tenstorrent Atlantis Clock/Reset Controller Anirudh Srinivasan
2026-01-15 23:41 ` Anirudh Srinivasan
2026-01-15 23:42 ` [PATCH 1/8] dt-bindings: soc: tenstorrent: Add tenstorrent,atlantis-syscon Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  3:18   ` Rob Herring (Arm)
2026-01-16  3:18     ` Rob Herring (Arm)
2026-01-16  4:03   ` Rob Herring
2026-01-16  4:03     ` Rob Herring
2026-01-16 21:48     ` Anirudh Srinivasan
2026-01-16 21:48       ` Anirudh Srinivasan
2026-01-16  9:04   ` Krzysztof Kozlowski
2026-01-16  9:04     ` Krzysztof Kozlowski
2026-01-16 21:47     ` Anirudh Srinivasan
2026-01-16 21:47       ` Anirudh Srinivasan
2026-01-15 23:42 ` [PATCH 2/8] soc: tenstorrent: Add header with Atlantis syscon register offsets Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  9:06   ` Krzysztof Kozlowski
2026-01-16  9:06     ` Krzysztof Kozlowski
2026-01-16 21:34     ` Anirudh Srinivasan
2026-01-16 21:34       ` Anirudh Srinivasan
2026-01-15 23:42 ` [PATCH 3/8] clk: tenstorrent: Add Atlantis clock controller driver Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  2:05   ` Brian Masney
2026-01-16  2:05     ` Brian Masney
2026-01-16  9:00     ` Krzysztof Kozlowski
2026-01-16  9:00       ` Krzysztof Kozlowski
2026-01-16 20:32       ` Anirudh Srinivasan
2026-01-16 20:32         ` Anirudh Srinivasan
2026-01-16 20:46     ` Anirudh Srinivasan
2026-01-16 20:46       ` Anirudh Srinivasan
2026-01-16 11:56   ` kernel test robot
2026-01-16 11:56     ` kernel test robot
2026-01-15 23:42 ` [PATCH 4/8] dt-bindings: soc: tenstorrent: Add atlantis resets Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  9:02   ` Krzysztof Kozlowski [this message]
2026-01-16  9:02     ` Krzysztof Kozlowski
2026-01-16  9:03     ` Krzysztof Kozlowski
2026-01-16  9:03       ` Krzysztof Kozlowski
2026-01-16 21:25       ` Anirudh Srinivasan
2026-01-16 21:25         ` Anirudh Srinivasan
2026-01-17 10:50         ` Krzysztof Kozlowski
2026-01-17 10:50           ` Krzysztof Kozlowski
2026-01-15 23:42 ` [PATCH 5/8] soc: tenstorrent: Add rcpu syscon reset register definitions Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  9:06   ` Krzysztof Kozlowski
2026-01-16  9:06     ` Krzysztof Kozlowski
2026-01-15 23:42 ` [PATCH 6/8] soc: tenstorrent: Add auxiliary device definitions for Atlantis Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  9:07   ` Krzysztof Kozlowski
2026-01-16  9:07     ` Krzysztof Kozlowski
2026-01-15 23:42 ` [PATCH 7/8] reset: tenstorrent: Add reset controller " Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-15 23:42 ` [PATCH 8/8] clk: tenstorrent: Add reset controller to Atlantis clock controller probe Anirudh Srinivasan
2026-01-15 23:42   ` Anirudh Srinivasan
2026-01-16  9:08   ` Krzysztof Kozlowski
2026-01-16  9:08     ` Krzysztof Kozlowski
2026-01-16 21:30     ` Anirudh Srinivasan
2026-01-16 21:30       ` Anirudh Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260116-unique-devious-elephant-e9de6d@quoll \
    --to=krzk@kernel.org \
    --cc=agross@kernel.org \
    --cc=agross@oss.tenstorrent.com \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dfustini@oss.tenstorrent.com \
    --cc=fustini@kernel.org \
    --cc=jms@oss.tenstorrent.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mpe@kernel.org \
    --cc=mpe@oss.tenstorrent.com \
    --cc=mturquette@baylibre.com \
    --cc=npiggin@oss.tenstorrent.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.