From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH v2] f2fs: fix error path handling in f2fs_read_data_large_folio()
Date: Fri, 16 Jan 2026 14:29:27 +0800 [thread overview]
Message-ID: <20260116062927.21725-1-chao@kernel.org> (raw)
In error path of f2fs_read_data_large_folio(), if bio is valid, it
may submit bio twice, fix it.
Signed-off-by: Chao Yu <chao@kernel.org>
---
v2:
- rebase the code
fs/f2fs/data.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5b4832956196..d685c889f7b6 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2577,17 +2577,14 @@ static int f2fs_read_data_large_folio(struct inode *inode,
folio_end_read(folio, !ret);
return ret;
}
-
+out:
+ f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
if (ret) {
- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
-
/* Wait bios and clear uptodate. */
folio_lock(folio);
folio_clear_uptodate(folio);
folio_unlock(folio);
}
-out:
- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
return ret;
}
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH v2] f2fs: fix error path handling in f2fs_read_data_large_folio()
Date: Fri, 16 Jan 2026 14:29:27 +0800 [thread overview]
Message-ID: <20260116062927.21725-1-chao@kernel.org> (raw)
In error path of f2fs_read_data_large_folio(), if bio is valid, it
may submit bio twice, fix it.
Signed-off-by: Chao Yu <chao@kernel.org>
---
v2:
- rebase the code
fs/f2fs/data.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5b4832956196..d685c889f7b6 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2577,17 +2577,14 @@ static int f2fs_read_data_large_folio(struct inode *inode,
folio_end_read(folio, !ret);
return ret;
}
-
+out:
+ f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
if (ret) {
- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
-
/* Wait bios and clear uptodate. */
folio_lock(folio);
folio_clear_uptodate(folio);
folio_unlock(folio);
}
-out:
- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
return ret;
}
--
2.40.1
next reply other threads:[~2026-01-16 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 6:29 Chao Yu via Linux-f2fs-devel [this message]
2026-01-16 6:29 ` [PATCH v2] f2fs: fix error path handling in f2fs_read_data_large_folio() Chao Yu
2026-01-22 23:50 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-01-22 23:50 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116062927.21725-1-chao@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.