From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 12/17] firmware: arm_scmi: Add Telemetry components view
Date: Sat, 17 Jan 2026 06:02:17 +0800 [thread overview]
Message-ID: <202601170503.pgixUrV3-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260114114638.2290765-13-cristian.marussi@arm.com>
References: <20260114114638.2290765-13-cristian.marussi@arm.com>
TO: Cristian Marussi <cristian.marussi@arm.com>
Hi Cristian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on soc/for-next]
[also build test WARNING on trace/for-next linus/master v6.19-rc5 next-20260116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/firmware-arm_scmi-Define-a-common-SCMI_MAX_PROTOCOLS-value/20260114-195913
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20260114114638.2290765-13-cristian.marussi%40arm.com
patch subject: [PATCH v2 12/17] firmware: arm_scmi: Add Telemetry components view
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: sparc-randconfig-r073-20260117 (https://download.01.org/0day-ci/archive/20260117/202601170503.pgixUrV3-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.4.0
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601170503.pgixUrV3-lkp@intel.com/
smatch warnings:
drivers/firmware/arm_scmi/scmi_system_telemetry.c:2238 scmi_telemetry_de_subdir_symlink() error: uninitialized symbol 'ret'.
vim +/ret +2238 drivers/firmware/arm_scmi/scmi_system_telemetry.c
47d6794dcab7828 Cristian Marussi 2026-01-14 2195
289dce6d3bc91dc Cristian Marussi 2026-01-14 2196 static int scmi_telemetry_de_subdir_symlink(struct super_block *sb,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2197 struct scmi_tlm_setup *tsp,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2198 const struct scmi_telemetry_de *de,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2199 struct dentry *parent)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2200 {
289dce6d3bc91dc Cristian Marussi 2026-01-14 2201 struct dentry *dentry;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2202 struct inode *inode;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2203 int ret;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2204
289dce6d3bc91dc Cristian Marussi 2026-01-14 2205 if (IS_ERR(parent))
289dce6d3bc91dc Cristian Marussi 2026-01-14 2206 return 0;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2207
289dce6d3bc91dc Cristian Marussi 2026-01-14 2208 char *name __free(kfree) = kasprintf(GFP_KERNEL, "0x%08X", de->info->id);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2209 if (!name)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2210 return -ENOMEM;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2211
289dce6d3bc91dc Cristian Marussi 2026-01-14 2212 char *link __free(kfree) =
289dce6d3bc91dc Cristian Marussi 2026-01-14 2213 kasprintf(GFP_KERNEL, "../../../../../des/0x%08X", de->info->id);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2214 if (!link)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2215 return -ENOMEM;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2216
289dce6d3bc91dc Cristian Marussi 2026-01-14 2217 dentry = simple_start_creating(parent, name);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2218 if (IS_ERR(dentry))
289dce6d3bc91dc Cristian Marussi 2026-01-14 2219 return PTR_ERR(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2220
289dce6d3bc91dc Cristian Marussi 2026-01-14 2221 inode = stlmfs_get_inode(sb);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2222 if (unlikely(!inode)) {
289dce6d3bc91dc Cristian Marussi 2026-01-14 2223 dev_err(tsp->dev,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2224 "out of free dentries, cannot create '%s'", name);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2225 return stlmfs_failed_creating(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2226 }
289dce6d3bc91dc Cristian Marussi 2026-01-14 2227
289dce6d3bc91dc Cristian Marussi 2026-01-14 2228 inode->i_mode = S_IFLNK | 0777;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2229 inode->i_op = &simple_symlink_inode_operations;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2230 inode_init_owner(&nop_mnt_idmap, inode, NULL, inode->i_mode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2231 inode->i_link = no_free_ptr(link);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2232
289dce6d3bc91dc Cristian Marussi 2026-01-14 2233 //d_add(dentry, inode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2234 d_make_persistent(dentry, inode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2235
289dce6d3bc91dc Cristian Marussi 2026-01-14 2236 simple_done_creating(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2237
289dce6d3bc91dc Cristian Marussi 2026-01-14 @2238 return ret;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2239 }
289dce6d3bc91dc Cristian Marussi 2026-01-14 2240
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Cristian Marussi <cristian.marussi@arm.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 12/17] firmware: arm_scmi: Add Telemetry components view
Date: Mon, 19 Jan 2026 09:39:05 +0300 [thread overview]
Message-ID: <202601170503.pgixUrV3-lkp@intel.com> (raw)
Message-ID: <20260119063905.G3NvmQX4_USjKDLYgsEL7bS2YpSObDfowbE2h4SrOnw@z> (raw)
In-Reply-To: <20260114114638.2290765-13-cristian.marussi@arm.com>
Hi Cristian,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cristian-Marussi/firmware-arm_scmi-Define-a-common-SCMI_MAX_PROTOCOLS-value/20260114-195913
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20260114114638.2290765-13-cristian.marussi%40arm.com
patch subject: [PATCH v2 12/17] firmware: arm_scmi: Add Telemetry components view
config: sparc-randconfig-r073-20260117 (https://download.01.org/0day-ci/archive/20260117/202601170503.pgixUrV3-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.4.0
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202601170503.pgixUrV3-lkp@intel.com/
smatch warnings:
drivers/firmware/arm_scmi/scmi_system_telemetry.c:2238 scmi_telemetry_de_subdir_symlink() error: uninitialized symbol 'ret'.
vim +/ret +2238 drivers/firmware/arm_scmi/scmi_system_telemetry.c
289dce6d3bc91dc Cristian Marussi 2026-01-14 2196 static int scmi_telemetry_de_subdir_symlink(struct super_block *sb,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2197 struct scmi_tlm_setup *tsp,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2198 const struct scmi_telemetry_de *de,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2199 struct dentry *parent)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2200 {
289dce6d3bc91dc Cristian Marussi 2026-01-14 2201 struct dentry *dentry;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2202 struct inode *inode;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2203 int ret;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2204
289dce6d3bc91dc Cristian Marussi 2026-01-14 2205 if (IS_ERR(parent))
289dce6d3bc91dc Cristian Marussi 2026-01-14 2206 return 0;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2207
289dce6d3bc91dc Cristian Marussi 2026-01-14 2208 char *name __free(kfree) = kasprintf(GFP_KERNEL, "0x%08X", de->info->id);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2209 if (!name)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2210 return -ENOMEM;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2211
289dce6d3bc91dc Cristian Marussi 2026-01-14 2212 char *link __free(kfree) =
289dce6d3bc91dc Cristian Marussi 2026-01-14 2213 kasprintf(GFP_KERNEL, "../../../../../des/0x%08X", de->info->id);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2214 if (!link)
289dce6d3bc91dc Cristian Marussi 2026-01-14 2215 return -ENOMEM;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2216
289dce6d3bc91dc Cristian Marussi 2026-01-14 2217 dentry = simple_start_creating(parent, name);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2218 if (IS_ERR(dentry))
289dce6d3bc91dc Cristian Marussi 2026-01-14 2219 return PTR_ERR(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2220
289dce6d3bc91dc Cristian Marussi 2026-01-14 2221 inode = stlmfs_get_inode(sb);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2222 if (unlikely(!inode)) {
289dce6d3bc91dc Cristian Marussi 2026-01-14 2223 dev_err(tsp->dev,
289dce6d3bc91dc Cristian Marussi 2026-01-14 2224 "out of free dentries, cannot create '%s'", name);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2225 return stlmfs_failed_creating(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2226 }
289dce6d3bc91dc Cristian Marussi 2026-01-14 2227
289dce6d3bc91dc Cristian Marussi 2026-01-14 2228 inode->i_mode = S_IFLNK | 0777;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2229 inode->i_op = &simple_symlink_inode_operations;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2230 inode_init_owner(&nop_mnt_idmap, inode, NULL, inode->i_mode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2231 inode->i_link = no_free_ptr(link);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2232
289dce6d3bc91dc Cristian Marussi 2026-01-14 2233 //d_add(dentry, inode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2234 d_make_persistent(dentry, inode);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2235
289dce6d3bc91dc Cristian Marussi 2026-01-14 2236 simple_done_creating(dentry);
289dce6d3bc91dc Cristian Marussi 2026-01-14 2237
289dce6d3bc91dc Cristian Marussi 2026-01-14 @2238 return ret;
s/ret/0/;
289dce6d3bc91dc Cristian Marussi 2026-01-14 2239 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev reply other threads:[~2026-01-16 22:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 11:46 [PATCH v2 00/17] Introduce SCMI Telemetry FS support Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 01/17] firmware: arm_scmi: Define a common SCMI_MAX_PROTOCOLS value Cristian Marussi
2026-01-19 11:18 ` Jonathan Cameron
2026-01-19 15:43 ` Cristian Marussi
2026-01-20 6:44 ` Dhruva Gole
2026-01-20 10:55 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 02/17] firmware: arm_scmi: Reduce the scope of protocols mutex Cristian Marussi
2026-01-19 11:21 ` Jonathan Cameron
2026-01-19 15:45 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 03/17] firmware: arm_scmi: Allow protocols to register for notifications Cristian Marussi
2026-01-19 11:33 ` Jonathan Cameron
2026-01-19 15:49 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 04/17] uapi: Add ARM SCMI definitions Cristian Marussi
2026-01-19 11:43 ` Jonathan Cameron
2026-01-19 15:51 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 05/17] firmware: arm_scmi: Add Telemetry protocol support Cristian Marussi
2026-01-19 16:29 ` Jonathan Cameron
2026-01-19 18:25 ` Cristian Marussi
2026-01-23 11:00 ` Elif Topuz
2026-03-26 13:32 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 06/17] include: trace: Add Telemetry trace events Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 07/17] firmware: arm_scmi: Use new Telemetry traces Cristian Marussi
2026-01-16 20:01 ` kernel test robot
2026-01-23 11:43 ` Elif Topuz
2026-03-26 15:35 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 08/17] firmware: arm_scmi: Add System Telemetry driver Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 09/17] fs/stlmfs: Document ARM SCMI Telemetry filesystem Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 10/17] firmware: arm_scmi: Add System Telemetry ioctls support Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 11/17] fs/stlmfs: Document alternative ioctl based binary interface Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 12/17] firmware: arm_scmi: Add Telemetry components view Cristian Marussi
2026-01-16 13:35 ` Elif Topuz
2026-01-19 15:42 ` Cristian Marussi
2026-01-16 22:02 ` kernel test robot [this message]
2026-01-19 6:39 ` Dan Carpenter
2026-01-19 16:07 ` Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 13/17] fs/stlmfs: Document alternative topological view Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 14/17] [RFC] docs: stlmfs: Document ARM SCMI Telemetry FS ABI Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 15/17] [RFC] firmware: arm_scmi: Add lazy population support to Telemetry FS Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 16/17] fs/stlmfs: Document lazy mode and related mount option Cristian Marussi
2026-01-14 11:46 ` [PATCH v2 17/17] [RFC] tools/scmi: Add SCMI Telemetry testing tool Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601170503.pgixUrV3-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.