From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
Date: Tue, 20 Jan 2026 03:58:25 +0800 [thread overview]
Message-ID: <202601200310.Qy35J0Pm-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Manivannan Sadhasivam <mani@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
commit: 7ef502fb35b283e0f85ed7b34e2d963343981a8c PCI: Add Renesas RZ/G3S host controller driver
date: 8 weeks ago
:::::: branch date: 20 hours ago
:::::: commit date: 8 weeks ago
config: loongarch-randconfig-r072-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200310.Qy35J0Pm-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601200310.Qy35J0Pm-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
Old smatch warnings:
drivers/pci/controller/pcie-rzg3s-host.c:1348 rzg3s_pcie_parse_map_dma_ranges() warn: iterator 'i' not incremented
arch/loongarch/include/asm/atomic.h:135 arch_atomic_fetch_add_unless() warn: inconsistent indenting
vim +1675 drivers/pci/controller/pcie-rzg3s-host.c
7ef502fb35b283 Claudiu Beznea 2025-11-19 1632
7ef502fb35b283 Claudiu Beznea 2025-11-19 1633 static int rzg3s_pcie_suspend_noirq(struct device *dev)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1634 {
7ef502fb35b283 Claudiu Beznea 2025-11-19 1635 struct rzg3s_pcie_host *host = dev_get_drvdata(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1636 const struct rzg3s_pcie_soc_data *data = host->data;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1637 struct rzg3s_pcie_port *port = &host->port;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1638 struct regmap *sysc = host->sysc;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1639 int ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1640
7ef502fb35b283 Claudiu Beznea 2025-11-19 1641 ret = pm_runtime_put_sync(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1642 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1643 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1644
7ef502fb35b283 Claudiu Beznea 2025-11-19 1645 clk_disable_unprepare(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1646
7ef502fb35b283 Claudiu Beznea 2025-11-19 1647 ret = reset_control_bulk_assert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1648 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1649 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1650 goto refclk_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1651
7ef502fb35b283 Claudiu Beznea 2025-11-19 1652 ret = reset_control_bulk_assert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1653 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1654 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1655 goto power_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1656
7ef502fb35b283 Claudiu Beznea 2025-11-19 1657 ret = regmap_update_bits(sysc, RZG3S_SYS_PCIE_RST_RSM_B,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1658 RZG3S_SYS_PCIE_RST_RSM_B_MASK,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1659 FIELD_PREP(RZG3S_SYS_PCIE_RST_RSM_B_MASK, 0));
7ef502fb35b283 Claudiu Beznea 2025-11-19 1660 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1661 goto cfg_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1662
7ef502fb35b283 Claudiu Beznea 2025-11-19 1663 return 0;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1664
7ef502fb35b283 Claudiu Beznea 2025-11-19 1665 /* Restore the previous state if any error happens */
7ef502fb35b283 Claudiu Beznea 2025-11-19 1666 cfg_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1667 reset_control_bulk_deassert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1668 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1669 power_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1670 reset_control_bulk_deassert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1671 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1672 refclk_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1673 clk_prepare_enable(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1674 pm_runtime_resume_and_get(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 @1675 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1676 }
7ef502fb35b283 Claudiu Beznea 2025-11-19 1677
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-01-19 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 19:58 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 8:04 drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601200310.Qy35J0Pm-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.