* drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
@ 2026-01-19 19:58 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-01-19 19:58 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Manivannan Sadhasivam <mani@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
commit: 7ef502fb35b283e0f85ed7b34e2d963343981a8c PCI: Add Renesas RZ/G3S host controller driver
date: 8 weeks ago
:::::: branch date: 20 hours ago
:::::: commit date: 8 weeks ago
config: loongarch-randconfig-r072-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200310.Qy35J0Pm-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202601200310.Qy35J0Pm-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
Old smatch warnings:
drivers/pci/controller/pcie-rzg3s-host.c:1348 rzg3s_pcie_parse_map_dma_ranges() warn: iterator 'i' not incremented
arch/loongarch/include/asm/atomic.h:135 arch_atomic_fetch_add_unless() warn: inconsistent indenting
vim +1675 drivers/pci/controller/pcie-rzg3s-host.c
7ef502fb35b283 Claudiu Beznea 2025-11-19 1632
7ef502fb35b283 Claudiu Beznea 2025-11-19 1633 static int rzg3s_pcie_suspend_noirq(struct device *dev)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1634 {
7ef502fb35b283 Claudiu Beznea 2025-11-19 1635 struct rzg3s_pcie_host *host = dev_get_drvdata(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1636 const struct rzg3s_pcie_soc_data *data = host->data;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1637 struct rzg3s_pcie_port *port = &host->port;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1638 struct regmap *sysc = host->sysc;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1639 int ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1640
7ef502fb35b283 Claudiu Beznea 2025-11-19 1641 ret = pm_runtime_put_sync(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1642 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1643 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1644
7ef502fb35b283 Claudiu Beznea 2025-11-19 1645 clk_disable_unprepare(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1646
7ef502fb35b283 Claudiu Beznea 2025-11-19 1647 ret = reset_control_bulk_assert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1648 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1649 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1650 goto refclk_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1651
7ef502fb35b283 Claudiu Beznea 2025-11-19 1652 ret = reset_control_bulk_assert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1653 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1654 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1655 goto power_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1656
7ef502fb35b283 Claudiu Beznea 2025-11-19 1657 ret = regmap_update_bits(sysc, RZG3S_SYS_PCIE_RST_RSM_B,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1658 RZG3S_SYS_PCIE_RST_RSM_B_MASK,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1659 FIELD_PREP(RZG3S_SYS_PCIE_RST_RSM_B_MASK, 0));
7ef502fb35b283 Claudiu Beznea 2025-11-19 1660 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1661 goto cfg_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1662
7ef502fb35b283 Claudiu Beznea 2025-11-19 1663 return 0;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1664
7ef502fb35b283 Claudiu Beznea 2025-11-19 1665 /* Restore the previous state if any error happens */
7ef502fb35b283 Claudiu Beznea 2025-11-19 1666 cfg_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1667 reset_control_bulk_deassert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1668 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1669 power_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1670 reset_control_bulk_deassert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1671 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1672 refclk_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1673 clk_prepare_enable(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1674 pm_runtime_resume_and_get(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 @1675 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1676 }
7ef502fb35b283 Claudiu Beznea 2025-11-19 1677
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
@ 2026-05-14 8:04 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-05-14 8:04 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Manivannan Sadhasivam <mani@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e1914add2799225a87502051415fc5c32aeb02ae
commit: 7ef502fb35b283e0f85ed7b34e2d963343981a8c PCI: Add Renesas RZ/G3S host controller driver
date: 6 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 6 months ago
config: alpha-randconfig-r071-20260514 (https://download.01.org/0day-ci/archive/20260514/202605141513.i0HxcVmM-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.5.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 7ef502fb35b2 ("PCI: Add Renesas RZ/G3S host controller driver")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202605141513.i0HxcVmM-lkp@intel.com/
New smatch warnings:
drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675.
Old smatch warnings:
internal error: arch/alpha/include/asm/io_trivial.h:70 SQL error #2: near "and": syntax error
internal error: arch/alpha/include/asm/io_trivial.h:70 SQL: 'select * from return_states where and type = 1044 and parameter = -1 and key = '$' limit 1;'
vim +1675 drivers/pci/controller/pcie-rzg3s-host.c
7ef502fb35b283 Claudiu Beznea 2025-11-19 1632
7ef502fb35b283 Claudiu Beznea 2025-11-19 1633 static int rzg3s_pcie_suspend_noirq(struct device *dev)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1634 {
7ef502fb35b283 Claudiu Beznea 2025-11-19 1635 struct rzg3s_pcie_host *host = dev_get_drvdata(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1636 const struct rzg3s_pcie_soc_data *data = host->data;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1637 struct rzg3s_pcie_port *port = &host->port;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1638 struct regmap *sysc = host->sysc;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1639 int ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1640
7ef502fb35b283 Claudiu Beznea 2025-11-19 1641 ret = pm_runtime_put_sync(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1642 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1643 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1644
7ef502fb35b283 Claudiu Beznea 2025-11-19 1645 clk_disable_unprepare(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1646
7ef502fb35b283 Claudiu Beznea 2025-11-19 1647 ret = reset_control_bulk_assert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1648 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1649 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1650 goto refclk_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1651
7ef502fb35b283 Claudiu Beznea 2025-11-19 1652 ret = reset_control_bulk_assert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1653 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1654 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1655 goto power_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1656
7ef502fb35b283 Claudiu Beznea 2025-11-19 1657 ret = regmap_update_bits(sysc, RZG3S_SYS_PCIE_RST_RSM_B,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1658 RZG3S_SYS_PCIE_RST_RSM_B_MASK,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1659 FIELD_PREP(RZG3S_SYS_PCIE_RST_RSM_B_MASK, 0));
7ef502fb35b283 Claudiu Beznea 2025-11-19 1660 if (ret)
7ef502fb35b283 Claudiu Beznea 2025-11-19 1661 goto cfg_resets_restore;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1662
7ef502fb35b283 Claudiu Beznea 2025-11-19 1663 return 0;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1664
7ef502fb35b283 Claudiu Beznea 2025-11-19 1665 /* Restore the previous state if any error happens */
7ef502fb35b283 Claudiu Beznea 2025-11-19 1666 cfg_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1667 reset_control_bulk_deassert(data->num_cfg_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1668 host->cfg_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1669 power_resets_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1670 reset_control_bulk_deassert(data->num_power_resets,
7ef502fb35b283 Claudiu Beznea 2025-11-19 1671 host->power_resets);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1672 refclk_restore:
7ef502fb35b283 Claudiu Beznea 2025-11-19 1673 clk_prepare_enable(port->refclk);
7ef502fb35b283 Claudiu Beznea 2025-11-19 1674 pm_runtime_resume_and_get(dev);
7ef502fb35b283 Claudiu Beznea 2025-11-19 @1675 return ret;
7ef502fb35b283 Claudiu Beznea 2025-11-19 1676 }
7ef502fb35b283 Claudiu Beznea 2025-11-19 1677
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-14 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-19 19:58 drivers/pci/controller/pcie-rzg3s-host.c:1675 rzg3s_pcie_suspend_noirq() warn: 'port->refclk' from clk_prepare_enable() not released on lines: 1675 kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 8:04 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.