All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron via qemu development <qemu-devel@nongnu.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Michael S Tsirkin <mst@redhat.com>,
	Shiju Jose <shiju.jose@huawei.com>, <qemu-devel@nongnu.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 13/13] scripts/ghes_inject: improve help message
Date: Wed, 21 Jan 2026 13:43:35 +0000	[thread overview]
Message-ID: <20260121134335.00001c2b@huawei.com> (raw)
In-Reply-To: <5b4efacb92c898d5b345e6df1579756a79b586dc.1768993993.git.mchehab+huawei@kernel.org>

On Wed, 21 Jan 2026 12:25:21 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> Add a one-liner help message for each type of error inject
> command, and use raw formatter to keep line breaks.
> 
> While here, use a more uniform language.
> 
> With that, "ghes_inject -h" will now show:
> 
>   usage: ghes_inject.py [options]
> 
>   Handles ACPI GHESv2 error injection via the QEMU QMP interface.
> 
>   It uses UEFI BIOS APEI features to generate GHES records, which helps to
>   test CPER and GHES drivers on the guest OS and see how user‑space
>   applications on that guest handle such errors.
> 
>   positional arguments:
>     {arm,pcie-bus,fuzzy-test,fuzzy,raw-error,raw}
>       arm                 Inject an ARM processor error CPER, compatible with
>                           UEFI 2.9A Errata.
>       pcie-bus            Inject a PCIe bus error CPER
>       fuzzy-test (fuzzy)  Inject fuzzy test CPER packets
>       raw-error (raw)     Inject CPER records from previously recorded ones.
> 
>   options:
>     -h, --help            show this help message and exit
> 
>   QEMU QMP socket options:
>     -H, --host HOST       host name (default: localhost)
>     -P, --port PORT       TCP port number (default: 4445)
>     -d, --debug           enable debug output (default: False)
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

LGTM
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>




      reply	other threads:[~2026-01-21 13:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 11:25 [PATCH 00/13] Add more commands to scripts/ghes_inject.py Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 01/13] scripts/qmp_helper: add a return code to send_cper Mauro Carvalho Chehab
2026-01-21 12:08   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 02/13] scripts/qmp_helper: add missing CXL UEFI GUID Mauro Carvalho Chehab
2026-01-21 12:26   ` Jonathan Cameron
2026-01-21 12:26     ` Jonathan Cameron via qemu development
2026-01-21 15:45     ` Mauro Carvalho Chehab
2026-01-22 10:52       ` Jonathan Cameron
2026-01-22 10:52         ` Jonathan Cameron via qemu development
2026-01-22 15:08         ` Mauro Carvalho Chehab
2026-01-22 17:13           ` Jonathan Cameron
2026-01-22 17:13             ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 03/13] scripts/qmp_helper: add support for FRU Memory Poison Mauro Carvalho Chehab
2026-01-21 12:27   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 04/13] scripts/qmp_helper: make send_cper() more generic Mauro Carvalho Chehab
2026-01-21 12:30   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 05/13] scripts/qmp_helper: fix raw_data logic Mauro Carvalho Chehab
2026-01-21 12:35   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 06/13] scripts/qmp_helper: add support for a timeout logic Mauro Carvalho Chehab
2026-01-21 12:39   ` Jonathan Cameron via qemu development
2026-01-21 15:56     ` Mauro Carvalho Chehab
2026-01-23 16:16       ` Jonathan Cameron via qemu development
2026-01-26 11:23         ` Mauro Carvalho Chehab
2026-01-26 11:29           ` Mauro Carvalho Chehab
2026-01-26 12:27             ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 07/13] scripts/ghes_inject: add a logic to decode CPER Mauro Carvalho Chehab
2026-01-21 13:27   ` Jonathan Cameron via qemu development
2026-01-21 16:24     ` Mauro Carvalho Chehab
2026-01-22 16:23     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 08/13] scripts/ghes_inject: exit 1 if command was not sent Mauro Carvalho Chehab
2026-01-21 13:28   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 09/13] scripts/ghes_inject: add a handler for PCIe bus error Mauro Carvalho Chehab
2026-01-21 13:32   ` Jonathan Cameron via qemu development
2026-01-21 13:33     ` Jonathan Cameron via qemu development
2026-02-06 12:52       ` Jonathan Cameron via qemu development
2026-01-21 16:26     ` Mauro Carvalho Chehab
2026-01-22 16:42     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 10/13] scripts/ghes_inject: add support for fuzzy logic testing Mauro Carvalho Chehab
2026-01-21 13:37   ` Jonathan Cameron via qemu development
2026-01-21 16:35     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 11/13] scripts/ghes_inject: add a raw error inject command Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 12/13] scripts/ghes_inject: print help if no command specified Mauro Carvalho Chehab
2026-01-21 13:42   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 13/13] scripts/ghes_inject: improve help message Mauro Carvalho Chehab
2026-01-21 13:43   ` Jonathan Cameron via qemu development [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121134335.00001c2b@huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=crosa@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=jsnow@redhat.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mst@redhat.com \
    --cc=shiju.jose@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.