All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron via qemu development <qemu-devel@nongnu.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Michael S Tsirkin <mst@redhat.com>,
	Shiju Jose <shiju.jose@huawei.com>, <qemu-devel@nongnu.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 08/13] scripts/ghes_inject: exit 1 if command was not sent
Date: Wed, 21 Jan 2026 13:28:04 +0000	[thread overview]
Message-ID: <20260121132804.0000501d@huawei.com> (raw)
In-Reply-To: <746cc65bbde60ebe2232b048d6448d19466601c5.1768993993.git.mchehab+huawei@kernel.org>

On Wed, 21 Jan 2026 12:25:16 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> add a return code to subparser func() and return 1 if the
> command failed.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
>  scripts/arm_processor_error.py | 2 +-
>  scripts/ghes_inject.py         | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/arm_processor_error.py b/scripts/arm_processor_error.py
> index 73d069f070d4..d9845adb0c0a 100644
> --- a/scripts/arm_processor_error.py
> +++ b/scripts/arm_processor_error.py
> @@ -473,4 +473,4 @@ def send_cper(self, args):
>  
>          self.data = data
>  
> -        qmp_cmd.send_cper(cper_guid.CPER_PROC_ARM, self.data)
> +        return qmp_cmd.send_cper(cper_guid.CPER_PROC_ARM, self.data)
> diff --git a/scripts/ghes_inject.py b/scripts/ghes_inject.py
> index 9a235201418b..6ac917d0b5db 100755
> --- a/scripts/ghes_inject.py
> +++ b/scripts/ghes_inject.py
> @@ -43,7 +43,8 @@ def main():
>  
>      args = parser.parse_args()
>      if "func" in args:
> -        args.func(args)
> +        if not args.func(args):
> +            sys.exit(1)
>      else:
>          sys.exit(f"Please specify a valid command for {sys.argv[0]}")
>  



  reply	other threads:[~2026-01-21 13:28 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 11:25 [PATCH 00/13] Add more commands to scripts/ghes_inject.py Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 01/13] scripts/qmp_helper: add a return code to send_cper Mauro Carvalho Chehab
2026-01-21 12:08   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 02/13] scripts/qmp_helper: add missing CXL UEFI GUID Mauro Carvalho Chehab
2026-01-21 12:26   ` Jonathan Cameron
2026-01-21 12:26     ` Jonathan Cameron via qemu development
2026-01-21 15:45     ` Mauro Carvalho Chehab
2026-01-22 10:52       ` Jonathan Cameron
2026-01-22 10:52         ` Jonathan Cameron via qemu development
2026-01-22 15:08         ` Mauro Carvalho Chehab
2026-01-22 17:13           ` Jonathan Cameron
2026-01-22 17:13             ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 03/13] scripts/qmp_helper: add support for FRU Memory Poison Mauro Carvalho Chehab
2026-01-21 12:27   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 04/13] scripts/qmp_helper: make send_cper() more generic Mauro Carvalho Chehab
2026-01-21 12:30   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 05/13] scripts/qmp_helper: fix raw_data logic Mauro Carvalho Chehab
2026-01-21 12:35   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 06/13] scripts/qmp_helper: add support for a timeout logic Mauro Carvalho Chehab
2026-01-21 12:39   ` Jonathan Cameron via qemu development
2026-01-21 15:56     ` Mauro Carvalho Chehab
2026-01-23 16:16       ` Jonathan Cameron via qemu development
2026-01-26 11:23         ` Mauro Carvalho Chehab
2026-01-26 11:29           ` Mauro Carvalho Chehab
2026-01-26 12:27             ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 07/13] scripts/ghes_inject: add a logic to decode CPER Mauro Carvalho Chehab
2026-01-21 13:27   ` Jonathan Cameron via qemu development
2026-01-21 16:24     ` Mauro Carvalho Chehab
2026-01-22 16:23     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 08/13] scripts/ghes_inject: exit 1 if command was not sent Mauro Carvalho Chehab
2026-01-21 13:28   ` Jonathan Cameron via qemu development [this message]
2026-01-21 11:25 ` [PATCH 09/13] scripts/ghes_inject: add a handler for PCIe bus error Mauro Carvalho Chehab
2026-01-21 13:32   ` Jonathan Cameron via qemu development
2026-01-21 13:33     ` Jonathan Cameron via qemu development
2026-02-06 12:52       ` Jonathan Cameron via qemu development
2026-01-21 16:26     ` Mauro Carvalho Chehab
2026-01-22 16:42     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 10/13] scripts/ghes_inject: add support for fuzzy logic testing Mauro Carvalho Chehab
2026-01-21 13:37   ` Jonathan Cameron via qemu development
2026-01-21 16:35     ` Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 11/13] scripts/ghes_inject: add a raw error inject command Mauro Carvalho Chehab
2026-01-21 11:25 ` [PATCH 12/13] scripts/ghes_inject: print help if no command specified Mauro Carvalho Chehab
2026-01-21 13:42   ` Jonathan Cameron via qemu development
2026-01-21 11:25 ` [PATCH 13/13] scripts/ghes_inject: improve help message Mauro Carvalho Chehab
2026-01-21 13:43   ` Jonathan Cameron via qemu development

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121132804.0000501d@huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=crosa@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=jsnow@redhat.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mst@redhat.com \
    --cc=shiju.jose@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.