* [android-common:android17-6.18 19/19] sound/soc/codecs/nau8325.c:425 nau8325_clksrc_choose() warn: inconsistent indenting
@ 2026-01-21 9:06 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-01-21 9:06 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
Hi Jaroslav,
First bad commit (maybe != root cause):
tree: https://android.googlesource.com/kernel/common android17-6.18
head: 2aeb340753d0e3533439d7647f568cba7214e573
commit: 79bc3bdf36bc29037cb4a5fe0cd8e4d93101ef7f [19/19] ASoC: nau8325: add missing build config
config: i386-randconfig-141-20260121 (https://download.01.org/0day-ci/archive/20260121/202601211751.aOlZhQB9-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601211751.aOlZhQB9-lkp@intel.com/
smatch warnings:
sound/soc/codecs/nau8325.c:425 nau8325_clksrc_choose() warn: inconsistent indenting
vim +425 sound/soc/codecs/nau8325.c
c0a3873b9938bfa Seven Lee 2024-03-27 384
c0a3873b9938bfa Seven Lee 2024-03-27 385 static int nau8325_clksrc_choose(struct nau8325 *nau8325,
c0a3873b9938bfa Seven Lee 2024-03-27 386 const struct nau8325_srate_attr **srate_table,
c0a3873b9938bfa Seven Lee 2024-03-27 387 int *n1_sel, int *mult_sel, int *n2_sel)
c0a3873b9938bfa Seven Lee 2024-03-27 388 {
1123b37d894768b Krzysztof Kozlowski 2025-12-03 389 int i, j, mclk, ratio;
1123b37d894768b Krzysztof Kozlowski 2025-12-03 390 int mclk_max = 0, ratio_sel = 0, n2_max = 0;
c0a3873b9938bfa Seven Lee 2024-03-27 391
c0a3873b9938bfa Seven Lee 2024-03-27 392 if (!nau8325->mclk || !nau8325->fs)
c0a3873b9938bfa Seven Lee 2024-03-27 393 goto proc_err;
c0a3873b9938bfa Seven Lee 2024-03-27 394
c0a3873b9938bfa Seven Lee 2024-03-27 395 /* select sampling rate and MCLK_SRC */
c0a3873b9938bfa Seven Lee 2024-03-27 396 *srate_table = target_srate_attribute(nau8325->fs);
c0a3873b9938bfa Seven Lee 2024-03-27 397 if (!*srate_table)
c0a3873b9938bfa Seven Lee 2024-03-27 398 goto proc_err;
c0a3873b9938bfa Seven Lee 2024-03-27 399
c0a3873b9938bfa Seven Lee 2024-03-27 400 /* First check clock from MCLK directly, decide N2 for MCLK_SRC.
c0a3873b9938bfa Seven Lee 2024-03-27 401 * If not good, consider 1/N1 and Multiplier.
c0a3873b9938bfa Seven Lee 2024-03-27 402 */
c0a3873b9938bfa Seven Lee 2024-03-27 403 ratio = nau8325_clksrc_n2(nau8325, *srate_table, nau8325->mclk, n2_sel);
c0a3873b9938bfa Seven Lee 2024-03-27 404 if (ratio != NAU8325_MCLK_FS_RATIO_NUM) {
c0a3873b9938bfa Seven Lee 2024-03-27 405 *n1_sel = 0;
c0a3873b9938bfa Seven Lee 2024-03-27 406 *mult_sel = CLK_PROC_BYPASS;
c0a3873b9938bfa Seven Lee 2024-03-27 407 *n2_sel = MCLK_SRC;
c0a3873b9938bfa Seven Lee 2024-03-27 408 goto proc_done;
c0a3873b9938bfa Seven Lee 2024-03-27 409 }
c0a3873b9938bfa Seven Lee 2024-03-27 410
c0a3873b9938bfa Seven Lee 2024-03-27 411 /* Get MCLK_SRC through 1/N, Multiplier, and then 1/N2. */
c0a3873b9938bfa Seven Lee 2024-03-27 412 for (i = 0; i < ARRAY_SIZE(mclk_n1_div); i++) {
c0a3873b9938bfa Seven Lee 2024-03-27 413 for (j = 0; j < ARRAY_SIZE(mclk_n3_mult); j++) {
c0a3873b9938bfa Seven Lee 2024-03-27 414 mclk = nau8325->mclk << mclk_n3_mult[j].param;
c0a3873b9938bfa Seven Lee 2024-03-27 415 mclk = mclk / mclk_n1_div[i].param;
c0a3873b9938bfa Seven Lee 2024-03-27 416 ratio = nau8325_clksrc_n2(nau8325,
c0a3873b9938bfa Seven Lee 2024-03-27 417 *srate_table, mclk, n2_sel);
c0a3873b9938bfa Seven Lee 2024-03-27 418 if (ratio != NAU8325_MCLK_FS_RATIO_NUM &&
c0a3873b9938bfa Seven Lee 2024-03-27 419 (mclk_max < mclk || i > *n1_sel)) {
c0a3873b9938bfa Seven Lee 2024-03-27 420 mclk_max = mclk;
c0a3873b9938bfa Seven Lee 2024-03-27 421 n2_max = *n2_sel;
c0a3873b9938bfa Seven Lee 2024-03-27 422 *n1_sel = i;
c0a3873b9938bfa Seven Lee 2024-03-27 423 *mult_sel = j;
c0a3873b9938bfa Seven Lee 2024-03-27 424 ratio_sel = ratio;
c0a3873b9938bfa Seven Lee 2024-03-27 @425 goto proc_done;
c0a3873b9938bfa Seven Lee 2024-03-27 426 }
c0a3873b9938bfa Seven Lee 2024-03-27 427 }
c0a3873b9938bfa Seven Lee 2024-03-27 428 }
c0a3873b9938bfa Seven Lee 2024-03-27 429 if (mclk_max) {
c0a3873b9938bfa Seven Lee 2024-03-27 430 *n2_sel = n2_max;
c0a3873b9938bfa Seven Lee 2024-03-27 431 ratio = ratio_sel;
c0a3873b9938bfa Seven Lee 2024-03-27 432 goto proc_done;
c0a3873b9938bfa Seven Lee 2024-03-27 433 }
c0a3873b9938bfa Seven Lee 2024-03-27 434
c0a3873b9938bfa Seven Lee 2024-03-27 435 proc_err:
c0a3873b9938bfa Seven Lee 2024-03-27 436 dev_dbg(nau8325->dev, "The MCLK %d is invalid. It can't get MCLK_SRC of 256/400/500 FS (%d)",
c0a3873b9938bfa Seven Lee 2024-03-27 437 nau8325->mclk, nau8325->fs);
c0a3873b9938bfa Seven Lee 2024-03-27 438 return -EINVAL;
c0a3873b9938bfa Seven Lee 2024-03-27 439 proc_done:
c0a3873b9938bfa Seven Lee 2024-03-27 440 dev_dbg(nau8325->dev, "nau8325->fs=%d,range=0x%x, %s, (n1,mu,n2,dmu):(%d,%d,%d), MCLK_SRC=%uHz (%d)",
c0a3873b9938bfa Seven Lee 2024-03-27 441 nau8325->fs, (*srate_table)->range,
c0a3873b9938bfa Seven Lee 2024-03-27 442 (*srate_table)->max ? "MAX" : "MIN",
c0a3873b9938bfa Seven Lee 2024-03-27 443 *n1_sel == CLK_PROC_BYPASS ?
c0a3873b9938bfa Seven Lee 2024-03-27 444 CLK_PROC_BYPASS : mclk_n1_div[*n1_sel].param,
c0a3873b9938bfa Seven Lee 2024-03-27 445 *mult_sel == CLK_PROC_BYPASS ?
c0a3873b9938bfa Seven Lee 2024-03-27 446 CLK_PROC_BYPASS : 1 << mclk_n3_mult[*mult_sel].param,
c0a3873b9938bfa Seven Lee 2024-03-27 447 1 << mclk_n2_div[*n2_sel].param,
c0a3873b9938bfa Seven Lee 2024-03-27 448 (*srate_table)->mclk_src[ratio],
c0a3873b9938bfa Seven Lee 2024-03-27 449 (*srate_table)->mclk_src[ratio] / nau8325->fs);
c0a3873b9938bfa Seven Lee 2024-03-27 450
c0a3873b9938bfa Seven Lee 2024-03-27 451 return 0;
c0a3873b9938bfa Seven Lee 2024-03-27 452 }
c0a3873b9938bfa Seven Lee 2024-03-27 453
:::::: The code at line 425 was first introduced by commit
:::::: c0a3873b9938bfaa77bd337cad33266a50a6583f ASoC: nau8325: new driver
:::::: TO: Seven Lee <wtli@nuvoton.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-01-21 9:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-21 9:06 [android-common:android17-6.18 19/19] sound/soc/codecs/nau8325.c:425 nau8325_clksrc_choose() warn: inconsistent indenting kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.