* [LTP] [PATCH] vma05: fix the needs_cmds format
@ 2026-01-22 11:18 Li Wang via ltp
2026-01-22 12:06 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Li Wang via ltp @ 2026-01-22 11:18 UTC (permalink / raw)
To: ltp
Fixes: 39a28444272 ("lib: Add support option for .needs_cmds")
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Wei Gao <wegao@suse.com>
---
testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
index 34a82162c..b9654e80c 100755
--- a/testcases/kernel/mem/vma/vma05.sh
+++ b/testcases/kernel/mem/vma/vma05.sh
@@ -26,7 +26,14 @@
# {
# "needs_root": true,
# "needs_tmpdir": true,
-# "needs_cmds": ["gdb", "uname"],
+# "needs_cmds": [
+# {
+# "cmd": "gdb"
+# },
+# {
+# "cmd": "uname"
+# }
+# ],
# "save_restore": [
# ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
# ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
--
2.52.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] vma05: fix the needs_cmds format
2026-01-22 11:18 [LTP] [PATCH] vma05: fix the needs_cmds format Li Wang via ltp
@ 2026-01-22 12:06 ` Petr Vorel
2026-01-22 12:18 ` Wei Gao via ltp
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2026-01-22 12:06 UTC (permalink / raw)
To: Li Wang; +Cc: ltp
Hi Li,
> Fixes: 39a28444272 ("lib: Add support option for .needs_cmds")
> Signed-off-by: Li Wang <liwang@redhat.com>
> Cc: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
> diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> index 34a82162c..b9654e80c 100755
> --- a/testcases/kernel/mem/vma/vma05.sh
> +++ b/testcases/kernel/mem/vma/vma05.sh
> @@ -26,7 +26,14 @@
> # {
> # "needs_root": true,
> # "needs_tmpdir": true,
> -# "needs_cmds": ["gdb", "uname"],
> +# "needs_cmds": [
> +# {
> +# "cmd": "gdb"
> +# },
> +# {
> +# "cmd": "uname"
> +# }
> +# ],
Good catch, thanks!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> # "save_restore": [
> # ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
> # ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] vma05: fix the needs_cmds format
2026-01-22 12:06 ` Petr Vorel
@ 2026-01-22 12:18 ` Wei Gao via ltp
2026-01-22 12:49 ` Li Wang via ltp
0 siblings, 1 reply; 4+ messages in thread
From: Wei Gao via ltp @ 2026-01-22 12:18 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On Thu, Jan 22, 2026 at 01:06:04PM +0100, Petr Vorel wrote:
> Hi Li,
>
> > Fixes: 39a28444272 ("lib: Add support option for .needs_cmds")
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > Cc: Wei Gao <wegao@suse.com>
> > ---
> > testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
>
> > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> > index 34a82162c..b9654e80c 100755
> > --- a/testcases/kernel/mem/vma/vma05.sh
> > +++ b/testcases/kernel/mem/vma/vma05.sh
> > @@ -26,7 +26,14 @@
> > # {
> > # "needs_root": true,
> > # "needs_tmpdir": true,
> > -# "needs_cmds": ["gdb", "uname"],
> > +# "needs_cmds": [
> > +# {
> > +# "cmd": "gdb"
> > +# },
> > +# {
> > +# "cmd": "uname"
> > +# }
> > +# ],
>
> Good catch, thanks!
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
Thanks!
Reviewed-by: Wei Gao <wegao@suse.com>
> Kind regards,
> Petr
>
> > # "save_restore": [
> > # ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
> > # ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-22 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 11:18 [LTP] [PATCH] vma05: fix the needs_cmds format Li Wang via ltp
2026-01-22 12:06 ` Petr Vorel
2026-01-22 12:18 ` Wei Gao via ltp
2026-01-22 12:49 ` Li Wang via ltp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.