From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Sasha Levin <sashal@kernel.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Chia-I Wu <olvaffe@gmail.com>,
Karunika Choo <karunika.choo@arm.com>,
kernel@collabora.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 3/4] drm/panthor: Add tracepoint for hardware utilisation changes
Date: Fri, 23 Jan 2026 12:45:42 -0700 [thread overview]
Message-ID: <20260123194542.GA75720@ax162> (raw)
In-Reply-To: <3154579.irdbgypaU6@workhorse>
On Fri, Jan 23, 2026 at 01:52:19PM +0100, Nicolas Frattaroli wrote:
> On Friday, 23 January 2026 05:02:21 Central European Standard Time Sasha Levin wrote:
> > With this commit, I'm seeing:
> >
> > In file included from drivers/gpu/drm/panthor/panthor_trace.h:86,
> > from drivers/gpu/drm/panthor/panthor_gpu.c:26:
> > ./include/trace/define_trace.h:118:42: fatal error: ./panthor_trace.h: No such file or directory
> > 118 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> >
> > I think we need to add in 'CFLAGS_panthor_gpu.o := -I$(src)' to the Makefile
> > too, but I haven't tested that yet.
> >
> >
>
> Huh, puzzling that I never ran into this build failure.
>
> Doing another build right now, I still can't reproduce it even on a clean
> build without ccache. Your fix looks appropriate though judging by the LWM[1]
> series on event tracepoints.
>
> I'll submit a fix for this.
You will only see this when building in-tree (i.e., no O= or
KBUILD_OUTPUT) because $(src) and $(obj) are only added to the include
path automatically when building out of tree (see scripts/Makefile.lib,
search for 'ifdef building_out_of_srctree'), which could explain why you
(and presumably Mark doing -next) have not seen this error yet.
$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- O=build defconfig drivers/gpu/drm/panthor/panthor_gpu.o
$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- defconfig drivers/gpu/drm/panthor/panthor_gpu.o
In file included from drivers/gpu/drm/panthor/panthor_trace.h:86,
from drivers/gpu/drm/panthor/panthor_gpu.c:26:
./include/trace/define_trace.h:118:42: fatal error: ./panthor_trace.h: No such file or directory
118 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
Cheers,
Nathan
next prev parent reply other threads:[~2026-01-23 19:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 12:57 [PATCH v10 0/4] Add a few tracepoints to panthor Nicolas Frattaroli
2026-01-16 12:57 ` [PATCH v10 1/4] drm/panthor: Rework panthor_irq::suspended into panthor_irq::state Nicolas Frattaroli
2026-01-16 13:21 ` Boris Brezillon
2026-01-16 15:55 ` Steven Price
2026-01-16 12:57 ` [PATCH v10 2/4] drm/panthor: Extend IRQ helpers for mask modification/restoration Nicolas Frattaroli
2026-01-16 13:41 ` Boris Brezillon
2026-01-16 14:41 ` Nicolas Frattaroli
2026-01-16 15:06 ` Boris Brezillon
2026-01-16 15:56 ` Steven Price
2026-01-16 12:57 ` [PATCH v10 3/4] drm/panthor: Add tracepoint for hardware utilisation changes Nicolas Frattaroli
2026-01-16 13:59 ` Boris Brezillon
2026-01-16 15:56 ` Steven Price
2026-01-23 4:02 ` Sasha Levin
2026-01-23 12:52 ` Nicolas Frattaroli
2026-01-23 19:45 ` Nathan Chancellor [this message]
2026-01-16 12:57 ` [PATCH v10 4/4] drm/panthor: Add gpu_job_irq tracepoint Nicolas Frattaroli
2026-01-16 14:00 ` Boris Brezillon
2026-01-16 15:56 ` Steven Price
2026-01-22 14:40 ` [PATCH v10 0/4] Add a few tracepoints to panthor Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123194542.GA75720@ax162 \
--to=nathan@kernel.org \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karunika.choo@arm.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=olvaffe@gmail.com \
--cc=sashal@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.