From: Ido Schimmel <idosch@nvidia.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Jiri Pirko <jiri@resnulli.us>, Breno Leitao <leitao@debian.org>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv4: don't call inetdev_init() if device is no longer registered
Date: Sun, 25 Jan 2026 14:15:51 +0200 [thread overview]
Message-ID: <20260125121551.GA83275@shredder> (raw)
In-Reply-To: <29ffd5ac-07b1-4424-ad3f-8304a28d2946@I-love.SAKURA.ne.jp>
On Sun, Jan 25, 2026 at 08:21:08PM +0900, Tetsuo Handa wrote:
> We would need to update team driver side not to trigger dev_set_mtu().
> Below diff passed the reproducer, but I don't know whether it is safe
> to trigger dev_set_mtu() for team_uninit() and team_del_slave() and
> the err_port_enter: label of team_port_add()...
I just checked and the same issue was fixed in the bond driver in commit
f51048c3e07b ("bonding: avoid NETDEV_CHANGEMTU event when unregistering
slave"), so I would try a similar fix in team.
A solution in the core would be better, but I don't know if it's
possible and the blast radius would also be bigger, so it's something to
think about for net-next.
next prev parent reply other threads:[~2026-01-25 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 5:11 [PATCH] ipv4: don't call inetdev_init() if device is no longer registered Tetsuo Handa
2026-01-25 8:58 ` Ido Schimmel
2026-01-25 11:21 ` Tetsuo Handa
2026-01-25 12:15 ` Ido Schimmel [this message]
2026-01-25 14:35 ` [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave Tetsuo Handa
2026-01-26 2:35 ` David Ahern
2026-01-26 11:08 ` Tetsuo Handa
2026-01-27 7:38 ` Jiri Pirko
2026-01-27 7:42 ` Ido Schimmel
2026-01-27 12:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260125121551.GA83275@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.