All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Jiri Pirko <jiri@resnulli.us>, Breno Leitao <leitao@debian.org>,
	"David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave
Date: Tue, 27 Jan 2026 09:42:53 +0200	[thread overview]
Message-ID: <20260127074253.GA244149@shredder> (raw)
In-Reply-To: <ece4365f-906c-44e2-80c9-ab73f91f7fb5@I-love.SAKURA.ne.jp>

Patch prefix should be "[PATCH net]". See:

https://docs.kernel.org/process/maintainer-netdev.html

On Sun, Jan 25, 2026 at 11:35:28PM +0900, Tetsuo Handa wrote:

[...]

Needs a Fixes tag. AFAICT, issue was present since the beginning, so:

Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")

> Reported-by: syzbot+881d65229ca4f9ae8c84@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84
> Suggested-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

Doesn't build for me with CONFIG_NET_TEAM=m:

ERROR: modpost: module team uses symbol __netif_set_mtu from namespace NETDEV_INTERNAL, but does not import it.
make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
make[1]: *** [/images/share/idosch/virtme-build/Makefile:2004: modpost] Error 2
make: *** [Makefile:248: __sub-make] Error 2

Needs:

diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
index 0af2e5aa84fb..a0fe998cc055 100644
--- a/drivers/net/team/team_core.c
+++ b/drivers/net/team/team_core.c
@@ -3014,3 +3014,4 @@ MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Jiri Pirko <jpirko@redhat.com>");
 MODULE_DESCRIPTION("Ethernet team device driver");
 MODULE_ALIAS_RTNL_LINK(DRV_NAME);
+MODULE_IMPORT_NS("NETDEV_INTERNAL");

  parent reply	other threads:[~2026-01-27  7:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-25  5:11 [PATCH] ipv4: don't call inetdev_init() if device is no longer registered Tetsuo Handa
2026-01-25  8:58 ` Ido Schimmel
2026-01-25 11:21   ` Tetsuo Handa
2026-01-25 12:15     ` Ido Schimmel
2026-01-25 14:35       ` [PATCH] team: avoid NETDEV_CHANGEMTU event when unregistering slave Tetsuo Handa
2026-01-26  2:35         ` David Ahern
2026-01-26 11:08           ` Tetsuo Handa
2026-01-27  7:38         ` Jiri Pirko
2026-01-27  7:42         ` Ido Schimmel [this message]
2026-01-27 12:36         ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127074253.GA244149@shredder \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.