All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-next:master 5773/9539] Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'
@ 2026-01-26  3:56 kernel test robot
  2026-01-26  4:01 ` Gao Xiang
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-01-26  3:56 UTC (permalink / raw)
  To: Hongbo Li; +Cc: oe-kbuild-all, Christian Brauner, Gao Xiang, Darrick J. Wong

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
commit: 8806f279244bf300dca2c99735d5a51cd24b86df [5773/9539] iomap: stash iomap read ctx in the private field of iomap_iter
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601261111.vIL9rhgD-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'
>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 5773/9539] Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'
  2026-01-26  3:56 [linux-next:master 5773/9539] Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead' kernel test robot
@ 2026-01-26  4:01 ` Gao Xiang
  2026-01-26  6:18   ` Hongbo Li
  0 siblings, 1 reply; 3+ messages in thread
From: Gao Xiang @ 2026-01-26  4:01 UTC (permalink / raw)
  To: Hongbo Li
  Cc: oe-kbuild-all, Christian Brauner, Darrick J. Wong,
	kernel test robot

Hi Hongbo,

On 2026/1/26 11:56, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
> commit: 8806f279244bf300dca2c99735d5a51cd24b86df [5773/9539] iomap: stash iomap read ctx in the private field of iomap_iter
> config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601261111.vIL9rhgD-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'
>>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'

It seems the kernel-doc isn't updated, could you
submit another iomap patch to fix that?

  608 /**
  609  * iomap_readahead - Attempt to read pages from a file.
  610  * @ops: The operations vector for the filesystem.
  611  * @ctx: The ctx used for issuing readahead.

^ here.

  612  *
  613  * This function is for filesystems to call to implement their readahead
  614  * address_space operation.
  615  *
  616  * Context: The @ops callbacks may submit I/O (eg to read the addresses of
  617  * blocks from disc), and may wait for it.  The caller may be trying to
  618  * access a different page, and so sleeping excessively should be avoided.
  619  * It may allocate memory, but should avoid costly allocations.  This
  620  * function is called with memalloc_nofs set, so allocations will not cause
  621  * the filesystem to be reentered.
  622  */
  623 void iomap_readahead(const struct iomap_ops *ops,
  624                 struct iomap_read_folio_ctx *ctx, void *private)

Thanks,
Gao Xiang



> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 5773/9539] Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead'
  2026-01-26  4:01 ` Gao Xiang
@ 2026-01-26  6:18   ` Hongbo Li
  0 siblings, 0 replies; 3+ messages in thread
From: Hongbo Li @ 2026-01-26  6:18 UTC (permalink / raw)
  To: Gao Xiang
  Cc: oe-kbuild-all, Christian Brauner, Darrick J. Wong,
	kernel test robot



On 2026/1/26 12:01, Gao Xiang wrote:
> Hi Hongbo,
> 
> On 2026/1/26 11:56, kernel test robot wrote:
>> tree:   
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
>> master
>> head:   ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
>> commit: 8806f279244bf300dca2c99735d5a51cd24b86df [5773/9539] iomap: 
>> stash iomap read ctx in the private field of iomap_iter
>> config: x86_64-rhel-9.4 
>> (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/config)
>> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
>> reproduce (this is a W=1 build): 
>> (https://download.01.org/0day-ci/archive/20260126/202601261111.vIL9rhgD-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new 
>> version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: 
>> https://lore.kernel.org/oe-kbuild-all/202601261111.vIL9rhgD-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not 
>>>> described in 'iomap_readahead'
>>>> Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not 
>>>> described in 'iomap_readahead'
> 
> It seems the kernel-doc isn't updated, could you
> submit another iomap patch to fix that?

Ok, thank you to point it out.

Thanks,
Hongbo
> 
>   608 /**
>   609  * iomap_readahead - Attempt to read pages from a file.
>   610  * @ops: The operations vector for the filesystem.
>   611  * @ctx: The ctx used for issuing readahead.
> 
> ^ here.
> 
>   612  *
>   613  * This function is for filesystems to call to implement their 
> readahead
>   614  * address_space operation.
>   615  *
>   616  * Context: The @ops callbacks may submit I/O (eg to read the 
> addresses of
>   617  * blocks from disc), and may wait for it.  The caller may be 
> trying to
>   618  * access a different page, and so sleeping excessively should be 
> avoided.
>   619  * It may allocate memory, but should avoid costly allocations.  This
>   620  * function is called with memalloc_nofs set, so allocations will 
> not cause
>   621  * the filesystem to be reentered.
>   622  */
>   623 void iomap_readahead(const struct iomap_ops *ops,
>   624                 struct iomap_read_folio_ctx *ctx, void *private)
> 
> Thanks,
> Gao Xiang
> 
> 
> 
>>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-26  6:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26  3:56 [linux-next:master 5773/9539] Warning: fs/iomap/buffered-io.c:624 function parameter 'private' not described in 'iomap_readahead' kernel test robot
2026-01-26  4:01 ` Gao Xiang
2026-01-26  6:18   ` Hongbo Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.