All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info
Date: Tue, 27 Jan 2026 19:44:05 -0800	[thread overview]
Message-ID: <20260128034405.GD2718@sol> (raw)
In-Reply-To: <20260128033519.GB30830@lst.de>

On Wed, Jan 28, 2026 at 04:35:19AM +0100, Christoph Hellwig wrote:
> > Is there a reason for this function in particular to be __always_inline?
> > fsverity_get_info() is just inline.
> 
> Without the __always_inline some gcc versions on sparc fail to inline it,
> and cause a link failure due to a reference to fsverity_readahead in
> f2fs_mpage_readpages for non-verity builds.  (reported by the buildbot)

The relevant code is:

    vi = f2fs_need_verity(inode, folio->index);              
    if (vi)                                                  
            fsverity_readahead(vi, folio, nr_pages); 

Where:

    f2fs_need_verity()
        => fsverity_get_info()
            => fsverity_active()

If fsverity_active() needs __always_inline, why don't the other two
functions in the call chain need it?

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@lst.de>
Cc: fsverity@lists.linux.dev, Christian Brauner <brauner@kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	Jaegeuk Kim <jaegeuk@kernel.org>, David Sterba <dsterba@suse.com>,
	Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info
Date: Tue, 27 Jan 2026 19:44:05 -0800	[thread overview]
Message-ID: <20260128034405.GD2718@sol> (raw)
In-Reply-To: <20260128033519.GB30830@lst.de>

On Wed, Jan 28, 2026 at 04:35:19AM +0100, Christoph Hellwig wrote:
> > Is there a reason for this function in particular to be __always_inline?
> > fsverity_get_info() is just inline.
> 
> Without the __always_inline some gcc versions on sparc fail to inline it,
> and cause a link failure due to a reference to fsverity_readahead in
> f2fs_mpage_readpages for non-verity builds.  (reported by the buildbot)

The relevant code is:

    vi = f2fs_need_verity(inode, folio->index);              
    if (vi)                                                  
            fsverity_readahead(vi, folio, nr_pages); 

Where:

    f2fs_need_verity()
        => fsverity_get_info()
            => fsverity_active()

If fsverity_active() needs __always_inline, why don't the other two
functions in the call chain need it?

- Eric


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-01-28  3:44 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26  4:50 fsverity cleanups, speedup and memory usage optimization v3 Christoph Hellwig
2026-01-26  4:50 ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 01/16] fs,fsverity: reject size changes on fsverity files in setattr_prepare Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] [PATCH 01/16] fs, fsverity: " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 02/16] fs,fsverity: clear out fsverity_info from common code Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] [PATCH 02/16] fs, fsverity: " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 03/16] ext4: don't build the fsverity work handler for !CONFIG_FS_VERITY Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 12:22   ` Jan Kara
2026-01-26 12:22     ` [f2fs-dev] " Jan Kara
2026-01-26 19:27   ` Darrick J. Wong
2026-01-26 19:27     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26  4:50 ` [PATCH 04/16] f2fs: " Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 05/16] fsverity: pass struct file to ->write_merkle_tree_block Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 06/16] fsverity: start consolidating pagecache code Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 07/16] fsverity: don't issue readahead for non-ENOENT errors from __filemap_get_folio Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 19:11   ` Darrick J. Wong
2026-01-26 19:11     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26 20:53     ` Eric Biggers
2026-01-26 20:53       ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-27  6:00       ` Christoph Hellwig
2026-01-27  6:00         ` [f2fs-dev] " Christoph Hellwig
2026-01-27  6:20         ` Eric Biggers
2026-01-27  6:20           ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-27  6:28           ` Darrick J. Wong
2026-01-27  6:28             ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-27  6:38             ` Christoph Hellwig
2026-01-27  6:38               ` [f2fs-dev] " Christoph Hellwig
2026-01-28  0:57               ` Eric Biggers
2026-01-28  0:57                 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-27  6:36           ` Christoph Hellwig
2026-01-27  6:36             ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 08/16] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 19:26   ` Darrick J. Wong
2026-01-26 19:26     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26 20:37     ` Eric Biggers
2026-01-26 20:37       ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-26  4:50 ` [PATCH 09/16] fsverity: constify the vi pointer in fsverity_verification_context Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 19:13   ` Darrick J. Wong
2026-01-26 19:13     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-28  3:22   ` Eric Biggers
2026-01-28  3:22     ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-28  3:32     ` Christoph Hellwig
2026-01-28  3:32       ` [f2fs-dev] " Christoph Hellwig
2026-01-28  3:41       ` Eric Biggers
2026-01-28  3:41         ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-28  3:48         ` Christoph Hellwig
2026-01-28  3:48           ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 10/16] fsverity: deconstify the inode pointer in struct fsverity_info Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 19:13   ` Darrick J. Wong
2026-01-26 19:13     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26  4:50 ` [PATCH 11/16] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:50 ` [PATCH 12/16] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 12:25   ` Jan Kara
2026-01-26 12:25     ` [f2fs-dev] " Jan Kara
2026-01-26 19:17   ` Darrick J. Wong
2026-01-26 19:17     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26  4:50 ` [PATCH 13/16] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-01-26  4:50   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 12:27   ` Jan Kara
2026-01-26 12:27     ` [f2fs-dev] " Jan Kara
2026-01-26  4:51 ` [PATCH 14/16] f2fs: " Christoph Hellwig
2026-01-26  4:51   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:51 ` [PATCH 15/16] btrfs: " Christoph Hellwig
2026-01-26  4:51   ` [f2fs-dev] " Christoph Hellwig
2026-01-26  4:51 ` [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-01-26  4:51   ` [f2fs-dev] " Christoph Hellwig
2026-01-26 19:35   ` Darrick J. Wong
2026-01-26 19:35     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-26 20:40   ` Eric Biggers
2026-01-26 20:40     ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-27  6:15     ` Christoph Hellwig
2026-01-27  6:15       ` [f2fs-dev] " Christoph Hellwig
2026-01-28  3:28   ` Eric Biggers
2026-01-28  3:28     ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-28  3:35     ` Christoph Hellwig
2026-01-28  3:35       ` [f2fs-dev] " Christoph Hellwig
2026-01-28  3:44       ` Eric Biggers [this message]
2026-01-28  3:44         ` Eric Biggers via Linux-f2fs-devel
2026-01-28  3:48         ` Christoph Hellwig
2026-01-28  3:48           ` [f2fs-dev] " Christoph Hellwig
2026-01-28  3:59           ` Eric Biggers
2026-01-28  3:59             ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128034405.GD2718@sol \
    --to=ebiggers@kernel.org \
    --cc=aalbersh@redhat.com \
    --cc=brauner@kernel.org \
    --cc=chao@kernel.org \
    --cc=dsterba@suse.com \
    --cc=fsverity@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.