From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: fsverity cleanups, speedup and memory usage optimization v4
Date: Wed, 28 Jan 2026 16:07:02 -0800 [thread overview]
Message-ID: <20260129000702.GD2024@quark> (raw)
In-Reply-To: <20260128152630.627409-1-hch@lst.de>
On Wed, Jan 28, 2026 at 04:26:12PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> this series has a hodge podge of fsverity enhances that I looked into as
> part of the review of the xfs fsverity support series.
>
> The first part calls fsverity code from VFS code instead of requiring
> boilerplate in the file systems.
>
> The first patch fixes a bug in btrfs as part of that, as btrfs was missing
> a check. An xfstests test case for this was submitted already.
> Can we expedite this fix?
>
> The middle part optimizes the fsverity read path by kicking off readahead
> for the fsverity hashes from the data read submission context, which in my
> simply testing showed huge benefits for sequential reads using dd.
> I haven't been able to get fio to run on a preallocated fio file, but
> I expect random read benefits would be significantly better than that
> still.
To get things going, I've applied patches 1-6 to
https://git.kernel.org/pub/scm/fs/fsverity/linux.git/log/?h=for-next
I couldn't go further, due to the bugs in patches 7 and 8.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@lst.de>
Cc: fsverity@lists.linux.dev, Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Andrey Albershteyn <aalbersh@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Jaegeuk Kim <jaegeuk@kernel.org>, David Sterba <dsterba@suse.com>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] fsverity cleanups, speedup and memory usage optimization v4
Date: Wed, 28 Jan 2026 16:07:02 -0800 [thread overview]
Message-ID: <20260129000702.GD2024@quark> (raw)
In-Reply-To: <20260128152630.627409-1-hch@lst.de>
On Wed, Jan 28, 2026 at 04:26:12PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> this series has a hodge podge of fsverity enhances that I looked into as
> part of the review of the xfs fsverity support series.
>
> The first part calls fsverity code from VFS code instead of requiring
> boilerplate in the file systems.
>
> The first patch fixes a bug in btrfs as part of that, as btrfs was missing
> a check. An xfstests test case for this was submitted already.
> Can we expedite this fix?
>
> The middle part optimizes the fsverity read path by kicking off readahead
> for the fsverity hashes from the data read submission context, which in my
> simply testing showed huge benefits for sequential reads using dd.
> I haven't been able to get fio to run on a preallocated fio file, but
> I expect random read benefits would be significantly better than that
> still.
To get things going, I've applied patches 1-6 to
https://git.kernel.org/pub/scm/fs/fsverity/linux.git/log/?h=for-next
I couldn't go further, due to the bugs in patches 7 and 8.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-01-29 0:07 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 15:26 fsverity cleanups, speedup and memory usage optimization v4 Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 01/15] fs,fsverity: reject size changes on fsverity files in setattr_prepare Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] [PATCH 01/15] fs, fsverity: " Christoph Hellwig
2026-02-17 21:14 ` patchwork-bot+f2fs
2026-02-17 21:14 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-01-28 15:26 ` [PATCH 02/15] fs,fsverity: clear out fsverity_info from common code Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] [PATCH 02/15] fs, fsverity: " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 03/15] ext4: don't build the fsverity work handler for !CONFIG_FS_VERITY Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 04/15] f2fs: " Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 05/15] fsverity: pass struct file to ->write_merkle_tree_block Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 06/15] fsverity: start consolidating pagecache code Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 07/15] fsverity: don't issue readahead for non-ENOENT errors from __filemap_get_folio Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 16:32 ` Darrick J. Wong
2026-01-28 16:32 ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-28 23:48 ` Eric Biggers
2026-01-28 23:48 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-30 5:48 ` Christoph Hellwig
2026-01-30 5:48 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 08/15] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 16:33 ` Darrick J. Wong
2026-01-28 16:33 ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-28 22:56 ` Eric Biggers
2026-01-28 22:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-01-28 23:22 ` Darrick J. Wong
2026-01-28 23:22 ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-01-30 5:55 ` Christoph Hellwig
2026-01-30 5:55 ` [f2fs-dev] " Christoph Hellwig
2026-01-30 5:51 ` Christoph Hellwig
2026-01-30 5:51 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 09/15] fsverity: deconstify the inode pointer in struct fsverity_info Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 10/15] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 11/15] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 12/15] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 16:28 ` Jan Kara
2026-01-28 16:28 ` [f2fs-dev] " Jan Kara
2026-01-28 15:26 ` [PATCH 13/15] f2fs: " Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 14/15] btrfs: " Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-28 15:26 ` [PATCH 15/15] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-01-28 15:26 ` [f2fs-dev] " Christoph Hellwig
2026-01-29 0:07 ` Eric Biggers [this message]
2026-01-29 0:07 ` [f2fs-dev] fsverity cleanups, speedup and memory usage optimization v4 Eric Biggers via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129000702.GD2024@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.