Re: [PATCH v2 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jan 25, 2026 at 09:37:08PM -0800, Pavan Chebbi wrote:
> Create an additional auxiliary device to support fwctl.
> The next patch will create bnxt_fwctl and bind to this
> device.
> 
> Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++--
>  include/linux/bnxt/ulp.h                      |  1 +
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> index 4cdfc9641639..13159c0515bb 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> @@ -62,6 +62,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx)
>  
>  static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{
>  	.name		= "rdma",
> +}, {
> +	.name		= "fwctl",
>  }};

I would expect the name to be part of auxiliary_driver initialization
and not dynamically added.

  5113 static struct auxiliary_driver mlx5r_driver = {
  5114         .name = "rdma",
  5115         .probe = mlx5r_probe,
  5116         .remove = mlx5r_remove,
  5117         .id_table = mlx5r_id_table,
  5118 };

Thanks